From: "Noé Lopez via Guix-patches via" <guix-patches@gnu.org>
To: 74956@debbugs.gnu.org
Cc: "Noé Lopez" <noe@xn--no-cja.eu>
Subject: [bug#74956] [PATCH] build: pack: Fix unexpected type in assert-utf8-local.
Date: Thu, 19 Dec 2024 01:15:05 +0100 [thread overview]
Message-ID: <7498899ac5e19362bdaae45c2bf185bb10709a71.1734567208.git.noelopez@free.fr> (raw)
From: Noé Lopez <noelopez@free.fr>
getenv returns #f if the environment variable does not exist, causing a type
error since string=? expects a string.
* guix/build/pack.scm (assert-utf8-locale): Handle unset environment variable.
Change-Id: Idbe7a33a4c8453b8f4ffe6245c32c1373020fb06
---
guix/build/pack.scm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/guix/build/pack.scm b/guix/build/pack.scm
index fcb1da2a6c..1b28101469 100644
--- a/guix/build/pack.scm
+++ b/guix/build/pack.scm
@@ -72,7 +72,7 @@ (define* (tar-base-options #:key tar compressor)
(define (assert-utf8-locale)
"Verify the current process is using the en_US.utf8 locale."
- (unless (string=? "unset for tests" (getenv "GUIX_LOCPATH"))
+ (unless (string=? "unset for tests" (or (getenv "GUIX_LOCPATH") ""))
(unless (false-if-exception (setlocale LC_ALL "en_US.utf8"))
(error "environment not configured for en_US.utf8 locale"))))
base-commit: 1a62f687e504c67f26693f3bc60a90e503ab4ea9
--
2.46.0
reply other threads:[~2024-12-19 0:15 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7498899ac5e19362bdaae45c2bf185bb10709a71.1734567208.git.noelopez@free.fr \
--to=guix-patches@gnu.org \
--cc=74956@debbugs.gnu.org \
--cc=noe@xn--no-cja.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).