From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id CLbnMd764WHedQEAgWs5BA (envelope-from ) for ; Fri, 14 Jan 2022 23:36:14 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id EKikKt764WHgewEAG6o9tA (envelope-from ) for ; Fri, 14 Jan 2022 23:36:14 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 77F2521D9E for ; Fri, 14 Jan 2022 23:36:14 +0100 (CET) Received: from localhost ([::1]:60478 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n8VB7-0006q2-No for larch@yhetil.org; Fri, 14 Jan 2022 17:36:13 -0500 Received: from eggs.gnu.org ([209.51.188.92]:39006) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n8VAw-0006pf-Er for guix-patches@gnu.org; Fri, 14 Jan 2022 17:36:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:45598) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n8VAw-0004qM-5x for guix-patches@gnu.org; Fri, 14 Jan 2022 17:36:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n8VAw-0007vq-4R for guix-patches@gnu.org; Fri, 14 Jan 2022 17:36:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#53222] [PATCH] gnu: autokey fix paths. Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 14 Jan 2022 22:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53222 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: John Kehayias Cc: 53222@debbugs.gnu.org, Nicolas Goaziou Received: via spool by 53222-submit@debbugs.gnu.org id=B53222.164219972930446 (code B ref 53222); Fri, 14 Jan 2022 22:36:02 +0000 Received: (at 53222) by debbugs.gnu.org; 14 Jan 2022 22:35:29 +0000 Received: from localhost ([127.0.0.1]:38501 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8VAP-0007v0-0v for submit@debbugs.gnu.org; Fri, 14 Jan 2022 17:35:29 -0500 Received: from andre.telenet-ops.be ([195.130.132.53]:46534) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8VAM-0007ur-80 for 53222@debbugs.gnu.org; Fri, 14 Jan 2022 17:35:27 -0500 Received: from [172.20.10.5] ([188.189.236.18]) by andre.telenet-ops.be with bizsmtp id imbP2600K0QVvpG01mbQgr; Fri, 14 Jan 2022 23:35:24 +0100 Message-ID: <7459eb594a85d02eb744c9bd5b83941576990aab.camel@telenet.be> From: Maxime Devos Date: Fri, 14 Jan 2022 23:35:18 +0100 In-Reply-To: References: Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-H+2jbz5kuetwZ8AWHayz" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1642199724; bh=cl5PBqQ41HlmrhH1P6NbYtfkR6un2YWUQ9qIZSJi6RU=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=D9lHm2BBxVq1y+EqK11eBWeBcHakDgEnv++bHJ/r0E8A8PpJmrp3R/V/dPpRP+Jn4 xun1Er8WFur/Q4MTegx3bXCiGxD084n3dLXNG8cJwvQRONnXCq9HBoGwKxcH+yQiFM UZn72e+6bvu7+88SxtEVUm/ndvAN56bwh68MJu9agJtadNdW3bunUL/I+kBZ9MQxfR jcuaF2yiBUBDCENiJFz5lruR3ORsIdPfQTrD5fH9srBNatoFc4NyP+L0/d6LqwrX0r XGKRiqFcm9RW68X3GJScT6/yqkuRZIxdF6J4sRB0HbeSGJjwn+Yifoal9xfu29tzug Apt94wfAmQ9sA== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1642199774; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=cl5PBqQ41HlmrhH1P6NbYtfkR6un2YWUQ9qIZSJi6RU=; b=lhdycJQO+MEKWbqQi3RREg7QKxFb9oW+iVQWbk0OVXSx1nvIDKWJolOi/DvSholw6V2h3v H+GXC62W+Td1U5hJazDjsbbkB3MVtLgmTMI42nCPPbaPv/8tmcuVAHbq7fSg9ZwGNjhqz9 1g2tBFfh4wcIbiYGsfqF03wz1znemRNCrwGRV/RwP80hZKpsXxvE9SnI9aitMfg/vYz4kR zXt8UAGMrfC8hfCojExTizzP3EknjV5obQuewI2Qwc+KgoAbZLvDtGbpVtkPCvuQdlD68e ce1Qw203BwcxabzLkheL6N2+cQf2byz5KJH/hdk6zumPY4Nz0a10q6+BPTpd9g== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1642199774; a=rsa-sha256; cv=none; b=NNOROBJ4EFJkDmcxzNzmw4JE44XXIAHUjpPx31WB1vzIeBivFtLnc5KJNzxq+Spg5y5SHM Q7hTyITOWEcoDP9gZByT70PKtB7dKT06bgfv0VnxrcGCZ1pTaK+Gzofr5KXmMagfrP9EWK fKhClET6nqZC1Bghx61BL7tSiMdZILW52jw0PUOHKy3oNTyBkpgk+p8irFozMfQa6IfGJI ZSSUWUuKV5uBT5k+vxo1ZJbqpv4bb8caxCQzKyoMege7c0X6mVQu2WhTjz5pt/eQrCzm1/ YK7vRsN2CDZLx89OtYnmFKEYLk/LdXA86Ylnhd5ZS/V1HgTxTgG4w0oEfsNe3w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b=D9lHm2BB; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -5.22 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b=D9lHm2BB; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 77F2521D9E X-Spam-Score: -5.22 X-Migadu-Scanner: scn0.migadu.com X-TUID: p8xXt7A5W3s8 --=-H+2jbz5kuetwZ8AWHayz Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable John Kehayias schreef op vr 14-01-2022 om 20:40 [+0000]: > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (add-after 'insta= ll 'wrap-autokey > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0 (string-append "\"" (search-input-file inputs > "bin/zenity") "\""))) > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 (substitute* "autokey-shell" > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 (("'ipython3'") > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0 (string-append "'" (which "ipython3") "'")) > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 (("'python3'") > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0 (string-append "'" (which "python3") "'"))))) Wouldn't these also need to use use 'search-input-file'? I think I've mentioned before why 'search-input-file' needs to be used in these kind of contexts instead of 'which' (something with cross-compilation), if not I can explain. > [in propagated inputs] > + python-ipython > + wmctrl > + zenity Do we need propagation here? I don't quite see the need here and propagation can cause trouble like profile conflcts during partial upgrades (i.e. "guix install foo" after "guix pull" without "guix package -u") FWIW autokey is never used as library (except for autokey scripts but I assume autokey scripts are interpreted in the same process as autokey?)=C2=A0and wrap-program sets GUIX_PYTHONPATH so I think all python libraries here could be depropagated? Though that might be getting out of scope of the original patch, so only if you want to investigate. Othderwise, the patch you attached LGTM. Greetings, Maxime. --=-H+2jbz5kuetwZ8AWHayz Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYeH6phccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7n6gAP9Q6YsyGvAE3WrRvs5PBH4HQ5Q0 EXRTcMWHl8p2QUxTyQD+P4+0eMxA/b++7kgRoANbCFyJu3Bs3qbaSjnxnTkYmwg= =srNQ -----END PGP SIGNATURE----- --=-H+2jbz5kuetwZ8AWHayz--