From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id clEqMCdJKGBobAAA0tVLHw (envelope-from ) for ; Sat, 13 Feb 2021 21:48:23 +0000 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id oHmNKydJKGDsbwAAbx9fmQ (envelope-from ) for ; Sat, 13 Feb 2021 21:48:23 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 718A316154 for ; Sat, 13 Feb 2021 22:48:23 +0100 (CET) Received: from localhost ([::1]:39968 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lB2m6-0003cM-Jk for larch@yhetil.org; Sat, 13 Feb 2021 16:48:22 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:51424) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lB2lm-0003Xw-FZ for guix-patches@gnu.org; Sat, 13 Feb 2021 16:48:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:51861) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lB2lm-00025i-25 for guix-patches@gnu.org; Sat, 13 Feb 2021 16:48:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lB2ll-0006Om-Vu for guix-patches@gnu.org; Sat, 13 Feb 2021 16:48:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#45889] Nextcloud Client (v8) Resent-From: Leo Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 13 Feb 2021 21:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45889 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Raghav Gururajan , 45889@debbugs.gnu.org Received: via spool by 45889-submit@debbugs.gnu.org id=B45889.161325283924543 (code B ref 45889); Sat, 13 Feb 2021 21:48:01 +0000 Received: (at 45889) by debbugs.gnu.org; 13 Feb 2021 21:47:19 +0000 Received: from localhost ([127.0.0.1]:35174 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lB2l5-0006Nm-4j for submit@debbugs.gnu.org; Sat, 13 Feb 2021 16:47:19 -0500 Received: from mailrelay.tugraz.at ([129.27.2.202]:17070) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lB2l2-0006Nb-Np for 45889@debbugs.gnu.org; Sat, 13 Feb 2021 16:47:18 -0500 Received: from nijino.local (217-149-165-242.nat.highway.telekom.at [217.149.165.242]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4DdP8w6lStz3xr0; Sat, 13 Feb 2021 22:47:12 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1613252833; bh=4KmCgUZGQZLk1Pw+vDG2cLWx+FpDQPSnlVktu791a8s=; h=Subject:From:To:Date:In-Reply-To:References; b=sn+rYgy7AmfVOvi3BBwIEFY3bC/TkHW1XfrNWTZb35+l0fzu2Sp4lyfm0Aa8ed7SV kAXqI7vvIgp6Kan3vBAUIlwxdvzbWicGM6PjJZiu6HYj2+Y8r5bWPDYG6ifNo9Foag wjx48fuTWzx7rXWCr0J41j9wsOsEs058fPfaGeGA= Message-ID: <73f0495c29ee82c2a16a96cc2825f19bd88b4ab4.camel@student.tugraz.at> From: Leo Prikler Date: Sat, 13 Feb 2021 22:47:11 +0100 In-Reply-To: <3c07544c-97fe-88b1-2e80-ec5cfb87d4ec@raghavgururajan.name> References: <609483b4-c583-cbf0-4b2a-4daf6c4feb98@raghavgururajan.name> <8b239920351c99a887835c98fd9a3892b9cfd0f5.camel@student.tugraz.at> <3c07544c-97fe-88b1-2e80-ec5cfb87d4ec@raghavgururajan.name> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.116 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -1.26 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tugraz.at header.s=mailrelay header.b=sn+rYgy7; dmarc=fail reason="SPF not aligned (relaxed)" header.from=student.tugraz.at (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 718A316154 X-Spam-Score: -1.26 X-Migadu-Scanner: scn0.migadu.com X-TUID: +vl87sI7cEFj Hi Raghav, Am Samstag, den 13.02.2021, 15:36 -0500 schrieb Raghav Gururajan: > Hi Leo! > > > Is cmake really needed? I know that meson falls back to cmake if > > pkg- > > config fails and also supports output to cmake, but meson/ninja > > should > > be the default. > > Yes, it is used to generate `.cmake` files inder '[out]/lib/cmake'. Fair enough. > > Could you try packaging those for Guix as well? > > They don't have dedicated build scripts. That may be an issue. You might want to check which of those are perhaps optional, so that you don't need to pull them in. For example it appears you're also deleting libcrashreporter-qt with no replacement. kmessagewidget appears to be a part of KDE core. If anything there is strictly necessary for building, we should perhaps define a package variant, that has a slightly patched kmessagewidget. qtlockedfile and qtsingleapplication appear to be part of [1], a sort of metapackage, from which you could spawn multiple descriptions. For qtokenizer, I am really not sure. > > As with your telegram patch, I personally think the ordering is > > wrong > > here. > > I changed it in v8. LGTM. > > You might want to regexp the middle part in case it is changed. > > I could use PKGCONFIG_GETVAR\\(.+\\) but that would conflict with > other > PKGCONFIG_GETVAR lines now or in future. Okay, but you can do something like PKGCONFIG_GETVAR\\(.+ _install_dir\\), assuming that such variables should generally only be bound once. To be honest, I don't know enough CMake to tell, whether that is a good idea, however. > > What does this achieve exactly? > > It configures the build-system to install modules in output "out" > instead of Qt's (input) path. In that case, the comment should probably read something along the lines of "Make sure, that is installed under $prefix." Regards, Leo [1] https://github.com/qtproject/qt-solutions