unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Justin Veilleux <terramorpha@cock.li>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 54068@debbugs.gnu.org, Maxime Devos <maximedevos@telenet.be>
Subject: [bug#54068] [PATCH] Add xmrig and p2pool
Date: Tue, 5 Apr 2022 14:57:53 -0400	[thread overview]
Message-ID: <73ba1436-5434-c771-258d-d3a97f3ff5df@cock.li> (raw)
In-Reply-To: <87pmlvmxqq.fsf_-_@gnu.org>

Hi.

Most issues Maxime raised I can solve easily. The bundling part, 
however, I am unfamiliar with.

Regarding the high consumption of energy, I think, having read thread, I 
think everyone would agree
that a warning in the description would be beneficial.

Finally, since I submitted the patch, I discovered that xmrig, in it's 
default state, will donate 1% of it's runtime to the developpers' pool. 
I don't know what is guix's policy on this matter, but I will assume we 
want it disabled.

I'm going to fix the issues raised and send an updated patch.

Cheers,
Justin.






  reply	other threads:[~2022-04-05 18:59 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-19 23:12 [bug#54068] [PATCH] Add xmrig and p2pool Justin Veilleux
2022-02-20 10:14 ` Maxime Devos
2022-02-20 10:17 ` Maxime Devos
2022-04-05 14:05   ` Ludovic Courtès
2022-04-05 18:57     ` Justin Veilleux [this message]
2022-04-06 10:29       ` Maxime Devos
2022-04-06 15:33         ` Justin Veilleux
2022-04-06 18:24           ` Maxime Devos
2022-04-06 19:46             ` Justin Veilleux
2022-04-06 19:53             ` Justin Veilleux
2022-08-12 15:45               ` bug#54068: " Guillaume Le Vaillant
2022-04-06  0:51     ` [bug#54068] " Justin Veilleux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=73ba1436-5434-c771-258d-d3a97f3ff5df@cock.li \
    --to=terramorpha@cock.li \
    --cc=54068@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    --cc=maximedevos@telenet.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).