* [bug#36866] [PATCH] added trezord package
@ 2019-07-31 0:11 mjbecze
2019-08-01 1:38 ` Martin Becze
0 siblings, 1 reply; 6+ messages in thread
From: mjbecze @ 2019-07-31 0:11 UTC (permalink / raw)
To: 36866
---
gnu/packages/trezor.scm | 48 +++++++++++++++++++++++++++++++++++++++++
1 file changed, 48 insertions(+)
create mode 100644 gnu/packages/trezor.scm
diff --git a/gnu/packages/trezor.scm b/gnu/packages/trezor.scm
new file mode 100644
index 0000000000..6da61d7f56
--- /dev/null
+++ b/gnu/packages/trezor.scm
@@ -0,0 +1,48 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright � 2018 Pierre Neidhardt <mail@ambrevar.xyz>
+;;; Copyright � 2019 Tobias Geerinckx-Rice <me@tobias.gr>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or
(at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix. If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (gnu packages trezor)
+ #:use-module (guix licenses)
+ #:use-module (guix packages)
+ #:use-module (guix git-download)
+ #:use-module (guix download)
+ #:use-module (guix build-system go)
+ #:use-module (gnu packages golang))
+
+(define-public trezord
+ (package
+ (name "trezord")
+ (version "2.0.17")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (string-append
+ "https://github.com/trezor/trezord-go/archive/v" version
+ ".tar.gz"))
+ (sha256
+ (base32
"1r68yb1q8v3vbxi95gsq1nfjw2v59sykchrbbc2kppy3cymfk411"))
+ (file-name (string-append name "-" version "-source"))))
+ (build-system go-build-system)
+ (arguments
+ '(#:import-path "github.com/trezor/trezord-go"))
+ (home-page "https://trezor.io")
+ (synopsis "Trezor Communication Daemon aka Trezor Bridge (written
in Go)")
+ (description "This allows a Trezor hardware wallet to communicate
to the Trezor
+ wallet.")
+ (license lgpl3+)))
--
2.22.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [bug#36866] [PATCH] added trezord package
2019-07-31 0:11 [bug#36866] [PATCH] added trezord package mjbecze
@ 2019-08-01 1:38 ` Martin Becze
2019-08-01 6:12 ` Julien Lepiller
0 siblings, 1 reply; 6+ messages in thread
From: Martin Becze @ 2019-08-01 1:38 UTC (permalink / raw)
To: 36866
heyyy does anyone know if this is the correct way to open a PR to guix?
kinda missing easy github mode here... lol
^ permalink raw reply [flat|nested] 6+ messages in thread
* [bug#36866] [PATCH] added trezord package
2019-08-01 1:38 ` Martin Becze
@ 2019-08-01 6:12 ` Julien Lepiller
2019-08-01 6:48 ` Julien Lepiller
0 siblings, 1 reply; 6+ messages in thread
From: Julien Lepiller @ 2019-08-01 6:12 UTC (permalink / raw)
To: Martin Becze, 36866
Le 1 août 2019 03:38:53 GMT+02:00, Martin Becze <mjbecze@riseup.net> a écrit :
>heyyy does anyone know if this is the correct way to open a PR to guix?
>kinda missing easy github mode here... lol
Hey Martin,
You're on the right track. Now, you just have to send your patches to this bug (36866@debbugs.gnu.org) with git send-email. If there's only one patch, you may send it as an attachment instead, but send-email is the prefered way.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [bug#36866] [PATCH] added trezord package
2019-08-01 6:12 ` Julien Lepiller
@ 2019-08-01 6:48 ` Julien Lepiller
2019-08-01 19:31 ` [bug#36866] [PATCH 2/2] fixed copyright line and use git-fetch mjbecze
0 siblings, 1 reply; 6+ messages in thread
From: Julien Lepiller @ 2019-08-01 6:48 UTC (permalink / raw)
To: Martin Becze, 36866
Le 1 août 2019 08:12:25 GMT+02:00, Julien Lepiller <julien@lepiller.eu> a écrit :
>Le 1 août 2019 03:38:53 GMT+02:00, Martin Becze <mjbecze@riseup.net> a
>écrit :
>>heyyy does anyone know if this is the correct way to open a PR to
>guix?
>>kinda missing easy github mode here... lol
>
>Hey Martin,
>
>You're on the right track. Now, you just have to send your patches to
>this bug (36866@debbugs.gnu.org) with git send-email. If there's only
>one patch, you may send it as an attachment instead, but send-email is
>the prefered way.
Hi again,
For some reason I didn't see your previous email with the patch, but I do now. Can you make sure the copyright line at the beginning is correct? It should only mentionned people who worked on that file, including you.
Github tarballs are autogenerated, but get regenerated from time to time and they are not stable. We prefer to use tge git-fetch method for github, since it is more stable. There thould be plenty of examples in the repo, but we can take care of that. Otherwise, nice patch! Could you send an updated one to this bug number? Thank you!
^ permalink raw reply [flat|nested] 6+ messages in thread
* [bug#36866] [PATCH 2/2] fixed copyright line and use git-fetch
2019-08-01 6:48 ` Julien Lepiller
@ 2019-08-01 19:31 ` mjbecze
2019-08-01 20:16 ` bug#36866: " Julien Lepiller
0 siblings, 1 reply; 6+ messages in thread
From: mjbecze @ 2019-08-01 19:31 UTC (permalink / raw)
To: Julien Lepiller; +Cc: 36866
---
gnu/packages/trezor.scm | 17 ++++++++---------
1 file changed, 8 insertions(+), 9 deletions(-)
diff --git a/gnu/packages/trezor.scm b/gnu/packages/trezor.scm
index 6da61d7f56..9f43d67175 100644
--- a/gnu/packages/trezor.scm
+++ b/gnu/packages/trezor.scm
@@ -1,6 +1,5 @@
;;; GNU Guix --- Functional package management for GNU
-;;; Copyright � 2018 Pierre Neidhardt <mail@ambrevar.xyz>
-;;; Copyright � 2019 Tobias Geerinckx-Rice <me@tobias.gr>
+;;; Copyright � 2019 Martin Becze <mjbecze@riseup.net>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -28,16 +27,16 @@
(define-public trezord
(package
(name "trezord")
- (version "2.0.17")
+ (version "v2.0.17")
(source
(origin
- (method url-fetch)
- (uri (string-append
- "https://github.com/trezor/trezord-go/archive/v" version
- ".tar.gz"))
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/trezor/trezord-go.git")
+ (commit version)))
(sha256
- (base32
"1r68yb1q8v3vbxi95gsq1nfjw2v59sykchrbbc2kppy3cymfk411"))
- (file-name (string-append name "-" version "-source"))))
+ (base32
"0nqzpq0i3crh0i4r1cppja5sn3rwi1fv9afxzwzv63096x5l30a7"))
+ (file-name (git-file-name name version))))
(build-system go-build-system)
(arguments
'(#:import-path "github.com/trezor/trezord-go"))
--
2.22.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-08-01 20:17 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-07-31 0:11 [bug#36866] [PATCH] added trezord package mjbecze
2019-08-01 1:38 ` Martin Becze
2019-08-01 6:12 ` Julien Lepiller
2019-08-01 6:48 ` Julien Lepiller
2019-08-01 19:31 ` [bug#36866] [PATCH 2/2] fixed copyright line and use git-fetch mjbecze
2019-08-01 20:16 ` bug#36866: " Julien Lepiller
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).