From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id CABbAdehA2L/0QAAgWs5BA (envelope-from ) for ; Wed, 09 Feb 2022 12:13:27 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id oMw6OtahA2LdcQEA9RJhRA (envelope-from ) for ; Wed, 09 Feb 2022 12:13:26 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B7551101F5 for ; Wed, 9 Feb 2022 12:13:26 +0100 (CET) Received: from localhost ([::1]:36242 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nHkub-00033c-Uy for larch@yhetil.org; Wed, 09 Feb 2022 06:13:25 -0500 Received: from eggs.gnu.org ([209.51.188.92]:45474) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nHknp-0003Bo-Jl for guix-patches@gnu.org; Wed, 09 Feb 2022 06:06:26 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:56141) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nHknR-0005um-UJ for guix-patches@gnu.org; Wed, 09 Feb 2022 06:06:21 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nHknR-0000sZ-KZ for guix-patches@gnu.org; Wed, 09 Feb 2022 06:06:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#53648] [PATCH] gnu: fcitx5-gtk: Add GTK 4 support. Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 09 Feb 2022 11:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53648 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Zhu Zihao Cc: 53648@debbugs.gnu.org Received: via spool by 53648-submit@debbugs.gnu.org id=B53648.16444047313336 (code B ref 53648); Wed, 09 Feb 2022 11:06:01 +0000 Received: (at 53648) by debbugs.gnu.org; 9 Feb 2022 11:05:31 +0000 Received: from localhost ([127.0.0.1]:50038 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nHkmw-0000rj-Qz for submit@debbugs.gnu.org; Wed, 09 Feb 2022 06:05:31 -0500 Received: from michel.telenet-ops.be ([195.130.137.88]:52146) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nHkmu-0000ra-W1 for 53648@debbugs.gnu.org; Wed, 09 Feb 2022 06:05:29 -0500 Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a]) by michel.telenet-ops.be with bizsmtp id sz5S260094UW6Th06z5SMJ; Wed, 09 Feb 2022 12:05:27 +0100 Message-ID: <7352ac1f2762ffe4f24f22427a5ab1d56ba9237b.camel@telenet.be> From: Maxime Devos Date: Wed, 09 Feb 2022 12:05:20 +0100 In-Reply-To: <86wni4yeg9.fsf@163.com> References: <86ilu09yzs.fsf@163.com> <8635kwasnn.fsf@163.com> <86czjz8fmt.fsf@163.com> <86pmnyyooc.fsf@163.com> <86wni4yeg9.fsf@163.com> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-yUjwLrEo1QjtYfrmbaKr" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1644404727; bh=1hnOhYiOiCXGXQ8nksn2GMHMyrFNHTXPIgeI/LzKKA4=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=XZTTEO91FOtGPP6avEZFCQMBic6rxJwAIHY14TXhSf0K5/5yRfCk47uahQTMFWYYD Yj1ayGDTLmV/QZyJol58V2yHaHhP7zwZF2JrYT1kNPwUM6O+leBTXGoRwZ3NLEnRuf LH0l+rr3cOblum5PeGpWj40WvLLImlbx8PTK95C4fzfGnppl5d1E/iJwKg7TOGioik f0phnLtKidQ++FIMH7XXZd64J9FYluMaNAwnRG7CKhNlpeI6GBeuhonmjdBH481Tpz sOY08dfkIrY/Jl88lAzxIkSRS4POf7aA3c5U84x79crptSie4cyKurRdz66pvqvD3a V1paWIp8L156g== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1644405206; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=1hnOhYiOiCXGXQ8nksn2GMHMyrFNHTXPIgeI/LzKKA4=; b=ioAYd/6SiDGDMD1WpfDA3GmMrDWXXbCX7aZhhD4fiSTTxz1ROjgj5ZvQKoilBr3PQHfbjS Ir6/hJfFsfOd/YPFDlc/PhWE1FCDGdeDGnH8jWFsZMfrMuMtMcsDIHsA4PGGP4vWOzvjur FUOtU+j96LDB4QJ28haihaLocpf6ZEH4G9nfjApPr+7omjj/4TlM89swvxp1dYtIbpxmpO Au7pky9i5x5x/bV2gjhV45bu175p9Ih+842FqCspG5lQmuKDKs1W+wMa6NAyybiYRqf/hj Kenn4QbxKZZJdAVbk2o5RSFGIcmdfqg8zGs3LFN1OP+JwCGTolG7lfhxMWK+lg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1644405206; a=rsa-sha256; cv=none; b=o08qkwofMCfbdXgQB8McelRy3hPhCnW8j8HY5AnX/PrM1e1tSLAtyQw0IDttptFaa/vGMV osaXd1qHcyHlwl68RKORsz8gnnwCPQF+bLh6m2ioC44OW+xsy/aLht9Rv9Fxg42dqHhZZn co3p1jfdmIsckeKO0mj0IF2rnGz76glWg6MlGC3Qq9QDhPMEvmtYSB00rihbHguu5FV+B4 d9s9TYCAgfe+eB0EDHAqKbqHGesFD7oWN44XS9H/mBakoFHD9ijkmPNlMyj5e9bnS0kSJo bRYvExeK4C2JxM9r/BLvkcdssNw5alt/TE72UbLa99wkMC1mUxJiZjpHNEqwbA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b=XZTTEO91; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -5.13 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b=XZTTEO91; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: B7551101F5 X-Spam-Score: -5.13 X-Migadu-Scanner: scn0.migadu.com X-TUID: JTdAMLDaAz1j --=-yUjwLrEo1QjtYfrmbaKr Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Zhu Zihao schreef op wo 09-02-2022 om 10:12 [+0800]: > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (lamb= da* (#:key outputs #:allow-other-keys) Since you're doing #$output:FOO instead of (assoc-ref outputs "foo") below now, 'outputs' is now unused, so this can be simplified to (lambda _ ; <-- no (#:key outputs #:allow-other-keys) argument list needed ;; Take care of [...] (define (split-immodule gtk-version output) [...]) [...]) > + (description "Fcitx5-gtk provides following functionality in corresp= onding As previously mentioned, a few definite articles would seem to be in place: =E2=80=98Fcitx5-gtk provides _the_ following functionality in _the_ corresp= onding output:=E2=80=99 (emphasis mine). Otherwise, LGTM, although I didn't test it. Greetings, Maxime. --=-yUjwLrEo1QjtYfrmbaKr Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYgOf8BccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7h89AQCUPCbbQs5AYl5vdUOSjUWKPSRr IxpJvGQ9YJLHdIRhUgEA2uqD8BoYd+QzPTqFiNs05s3vLR4oKlKtwrjowb3c0w0= =u0dN -----END PGP SIGNATURE----- --=-yUjwLrEo1QjtYfrmbaKr--