From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id oI4nMdHQzmVcgAAAqHPOHw:P1 (envelope-from ) for ; Fri, 16 Feb 2024 04:04:49 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id oI4nMdHQzmVcgAAAqHPOHw (envelope-from ) for ; Fri, 16 Feb 2024 04:04:49 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=protonmail.com header.s=protonmail3 header.b=LEzSBXDG; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1708052689; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=pjfVKGe+O/5FChCJ9b7qJMzQh/hZn7aKMI/f3fD3SiQ=; b=a0pi5zLtJBNUeGcanhVjt2pZZTfweDyqzHH/IURYA0VxsTilDKE2t15Q4xpfYYYo6cIKwj rU4DgcaGDlLLmFdTLk3uN8nAKxqxuWhTP6YcWmaBMtWgez9QZR9P6EoQ9D/yILAjnzaKYT WU3P582C1wVe1zz+Vpf5YtvYXCuCWs5lK8fQgAWoSD+Gd9rBbAgmnRJq1tRERBUSXmQFUm 6EInUhsGVzzg5NrO2VkS7ta+eipHIo0dA7IBph8LK83Bz+l1Ppq8NHio/RbcS3wNn2DXbt PAYMZmeoy3m4KmlB0V8UcepGFcIMFh46Ul6luDwNssrd/aypg8kzre7eP0e/IA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=protonmail.com header.s=protonmail3 header.b=LEzSBXDG; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1708052689; a=rsa-sha256; cv=none; b=Ho4+/P20cMOvUFeIqqgDc78xuLDaTOcJp6cygP07ILPuqG0fnYHCo3hq2zizp67E4mWNPc CdL2dZWS3tYT3UAo2m4bKs4wc+j7BZIHLAhFAKNIWmPUKsuhysNBF97RJ1C1Z2CcHczVCw ldDWgL1k+S1wqTctRl/A5PESYS3q8a84lTKz84sE9KntHJsHH8a6/k2hhJrIyDwkyt1/km 5vixnuF2Jy51hdr6OHbbShGMx91mIQ0q+JOT5mk2CquuGKFdmQEFOP4QUmu0EeevJCuuoG QdZB8XTCMQ6mvz8+wdhCN8LgEcRiUUy30R8w+XJqP7tEozrO52lO+OJTPihGgw== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6744415B64 for ; Fri, 16 Feb 2024 04:04:49 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1raoWs-0006TQ-DP; Thu, 15 Feb 2024 22:04:46 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1raoWq-0006T2-7C for guix-patches@gnu.org; Thu, 15 Feb 2024 22:04:44 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1raoWo-0008KC-SG for guix-patches@gnu.org; Thu, 15 Feb 2024 22:04:42 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1raoX7-0006i1-QQ for guix-patches@gnu.org; Thu, 15 Feb 2024 22:05:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#69131] [PATCH 2/2] gnu: podman: Update to 4.9.3. Resent-From: Skyler Ferris Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 16 Feb 2024 03:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69131 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 69131@debbugs.gnu.org Received: via spool by 69131-submit@debbugs.gnu.org id=B69131.170805267025746 (code B ref 69131); Fri, 16 Feb 2024 03:05:01 +0000 Received: (at 69131) by debbugs.gnu.org; 16 Feb 2024 03:04:30 +0000 Received: from localhost ([127.0.0.1]:57717 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1raoWb-0006hB-5V for submit@debbugs.gnu.org; Thu, 15 Feb 2024 22:04:29 -0500 Received: from mail-4316.protonmail.ch ([185.70.43.16]:46425) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1raoWY-0006gx-Hx for 69131@debbugs.gnu.org; Thu, 15 Feb 2024 22:04:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1708052641; x=1708311841; bh=pjfVKGe+O/5FChCJ9b7qJMzQh/hZn7aKMI/f3fD3SiQ=; h=Date:To:From:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=LEzSBXDGptd/ZsDSoB13M1+CtNGCBvLLc9Q7uDXbwEUrO1YlnfmtWHWTMZa+z9Zc1 op0r5JDVHBj7Q3LDhWOqbV+vAz8Pb/0qqCuXZAD6WmaqJ5z6/A6NpGCm5FZOQwc53I 22GZqE1N/SQz/l5SBr+W1oarhSqCgawWPqiGQiL53NL4PO6OFGJM9I+LukX6L4CLiY ClNlH1NqFU+gLtkDBXsvhKnfVYkXRFKHtJUXW5MyrpuRHEDwNHRcUzIl2l58fV5TDy PvHJvoZ0Zv+qHdfutUd0e2I2fjkdqD7sy6ZydVmBumj06CsTf42NG48ScdI/jvjI9F dFHgg3byQ+/IA== Date: Fri, 16 Feb 2024 03:03:46 +0000 Message-ID: <72fb933f-f28f-459b-88fc-ee3dc7581def@protonmail.com> In-Reply-To: <564fa27db3acf9ab25ebb8887023c34a0f41930c.1707938222.git.~@wolfsden.cz> References: <564fa27db3acf9ab25ebb8887023c34a0f41930c.1707938222.git.~@wolfsden.cz> Feedback-ID: 40635331:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Skyler Ferris X-ACL-Warn: , Skyler Ferris via Guix-patches From: Skyler Ferris via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -6.98 X-Spam-Score: -6.98 X-Migadu-Queue-Id: 6744415B64 X-Migadu-Scanner: mx13.migadu.com X-TUID: n4/XaXnsrGye "Update podman" review notes: The following checklist is based on the items listed in the manual (22.7=20 "Submitting Patches"). Each checklist item may have one of the following=20 statuses: C: Commitable. This item looks as expected for a final commit. CC: Commitable with Context. Like commitable, but some notes have been=20 added providing context about anything notable or unusual. These notes=20 are provided for transparency or to set expectations for the committer=20 and should not be interpreted as meaning that I object to the patch. MR: Minor Repair. There is something about the patch which I think=20 should ideally be changed, but I do not think that the commit should be=20 held up for this reason alone. A: Attention. Something in the patch needs attention from the author,=20 the committer, or both. Resolving the matter may or may not require a=20 change to the patch. Blank: I did not review this aspect of the patch. [CC] Applies cleanly (commit bd87416648929f38c0173f047776d7675ea8a10d,=20 after applying the previous commit in this series) [CC] Cryptographic hash [C ] Synopsis & Description [C ] Package license matches source license [C ] No compiler warnings [CC] `guix lint` output [CC] `guix style` output [C ] Package builds (my host is an x86_64 Xen guest) [=C2=A0 ] Builds for other architectures [=C2=A0 ] No bundled software [CC] Works in container with minimal inputs [C ] `guix size` output [CC] Dependent packages (`guix refresh --list-dependent PACKAGE`) [C ] `guix build --rounds=3D2` [C ] Gender-neutral wording [C ] One set of related changes [=C2=A0 ] Simulated guix pull # Applies Cleanly Git reported that there were some "whitespace errors" due to spaces=20 before tabs. This is because the commit includes a new patch and the=20 patch applies to a file that uses tabs. The diff format requires that a=20 space appears before the tabs, so this error is erroneous. # Cryptographic hash A key with a fingerprint of 968479a1aff927e37d1a566bb5690eeebb952194=20 verified a checkout that hashes to the same value as found in the=20 package. This key is listed on the Ubuntu keyserver=20 (https://keyserver.ubuntu.com/pks/lookup?search=3DB5690EEEBB952194&fingerpr= int=3Don&op=3Dindex)=20 with two signatures from other keys. One of them is a key that only has=20 a self-signature, the other has a large number of other signatures and=20 claims to belong to Andy Brody=20 (https://keyserver.ubuntu.com/pks/lookup?op=3Dvindex&search=3D0xc7090b1a5f5= 7cdc5).=20 The key was not found on the OpenPGP keyserver. The only UID attached to=20 the key is "GitHub ", implying that the GitHub=20 server is ultimately responsible for maintaining source integrity. # guix lint output Guix lint reports 2 issues neither of which require action. It states that the new version is "probably vulnerable to=20 CVE-2022-2989". However, the discussion at=20 https://bugzilla.redhat.com/show_bug.cgi?id=3D2121445 indicates that fix=20 is implemented by=20 https://github.com/containers/podman/pull/15696/commits/21540161f20daffd884= eba99b2cc31373c9a0ec4.=20 My copy of the checkout contains commit=20 d82a41687e614d9ac8b2d169dee47fe226835e4c which has an identical diff. It also states that line 396 is too long, but this is due to a long=20 string which consists of a single "word" (a path). # guix style output The tool wants to change the formatting of the majority of lines in this=20 package, which were not changed in this patch, leading to a much larger=20 diff than what has been submitted. # Container with minimal inputs I ran the following command: ``` $ ./pre-inst-env guix shell -C podman -- podman ps ``` This caused podman to print 2 warnings and 1 error in addition to the=20 header line for containers (as I do not have any containers on my=20 system, I expected the remaining output to be blank). The warnings &=20 error were related to "/" not being a shared mount (it's not) and=20 operating in rootless mode (the output made sense based on rootless.md=20 in the root of the repository). # Dependent packages There is one dependent package, distrobox, which continues to build=20 successfully after applying this patch.