unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Maxime Devos <maximedevos@telenet.be>
To: "Artyom V. Poptsov" <poptsov.artyom@gmail.com>
Cc: 56768@debbugs.gnu.org
Subject: [bug#56768] [PATCH] gnu: engineering: Add qucs-s.
Date: Sat, 6 Aug 2022 13:42:53 +0200	[thread overview]
Message-ID: <72ecfa9d-33f0-7074-33da-ddde61d99ade@telenet.be> (raw)
In-Reply-To: <87v8rfxf06.fsf@gmail.com>


[-- Attachment #1.1.1: Type: text/plain, Size: 2689 bytes --]


On 30-07-2022 08:59, Artyom V. Poptsov wrote:
>> ... as you have observed, things work even when they aren't propagated
>> (at least for qtbase etc., ngspice and octave have not yet been
>> tested).
> I usually put into "propagated-inputs" packages that provide some binary
> that the current package use in the runtime.
>
> So do you mean that I should rely only on "inputs" package property, and
> the inputs will be propagated anyway if they're in use by the package?
>
Yes to the first (at least in this case, propagation is sometimes hard 
to avoid), no to the second. Propagation happens only for 
propagated-inputs; however, if they are 'in use' by the package by 
ending up in the references, then the GC won't remove the store items. 
The GC and propagation are independent mechanisms.

> Less experimentally, the propagated- in propagated-inputs means only 
> that: propagation -- the dependencies are still installed even if they 
> aren't propagated, because the substitute* inserts a reference so the 
> GC knows to not delete it, the only difference is that the dependency 
> isn't automatically put in the profile when not propagating. 

Here, I meant with 'installed' = entry in /gnu/store is downloaded or 
built and kept, not 'added to ~/.guix-profile or equivalent' -- the 
latter is propagation.

> So the next time Qucs-S run it gets the paths from the configuration
> file.
>
> I changed the substitutions so Qucs-S will ignore the paths to Octave
> and NGSpice from the configuration and will always use the paths
> provided by Guix.  Also any custom paths to Octave and NGSpice will be
> overwritten in the config when the application exits.
>
> That is sub-optimal in my view as we're messing up with the application
> configuration logic and if a user wants to change those paths he or she
> will be able to remove the config and set the paths in the startup
> configuration dialogue, but the settings will have no effect; that will
> be a bit confusing.
>
> Yet at least Qucs-S will always use the right Octave/NGSpice path from
> GNU Guix.
>
> What do you think?
>
> Here's the patch.

It's not ideal that the ngspice cannot be overridden in the 
configuration, but OTOH we have --with-input. I think it's acceptable, 
though if there are any users that would like to override in the 
configuration, we might need to propagate it again and remove the 
substitute* -- or better, though more work: patch qucs-s to use the 
configuration when explicitly set by the user and don't write 
/gnu/store/... inside it automatically, with /gnu/store/... as a 
fallback when it is not set.

Greetings,
Maxime.


[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 929 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]

  reply	other threads:[~2022-08-06 11:43 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-25 20:02 [bug#56768] [PATCH] gnu: engineering: Add qucs-s Artyom V. Poptsov
2022-07-26 18:07 ` Maxime Devos
2022-07-29 15:26   ` Artyom V. Poptsov
2022-07-29 16:17     ` Maxime Devos
2022-07-30  6:59       ` Artyom V. Poptsov
2022-08-06 11:42         ` Maxime Devos [this message]
2022-08-06 10:15 ` Jean Pierre De Jesus DIAZ via Guix-patches via
2022-09-04 16:00 ` Artyom V. Poptsov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=72ecfa9d-33f0-7074-33da-ddde61d99ade@telenet.be \
    --to=maximedevos@telenet.be \
    --cc=56768@debbugs.gnu.org \
    --cc=poptsov.artyom@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).