From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id oLx1AIPf7GAVBgEAgWs5BA (envelope-from ) for ; Tue, 13 Jul 2021 02:34:11 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id eNnBN4Lf7GDiGQAAB5/wlQ (envelope-from ) for ; Tue, 13 Jul 2021 00:34:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8F2CC1BA9E for ; Tue, 13 Jul 2021 02:34:10 +0200 (CEST) Received: from localhost ([::1]:39614 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m36NF-0001TF-KC for larch@yhetil.org; Mon, 12 Jul 2021 20:34:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48894) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m36N8-0001RM-T1 for guix-patches@gnu.org; Mon, 12 Jul 2021 20:34:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:55758) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m36N8-00039b-Lb for guix-patches@gnu.org; Mon, 12 Jul 2021 20:34:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m36N8-0006np-BW for guix-patches@gnu.org; Mon, 12 Jul 2021 20:34:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#48443] [PATCH 1/2] gnu: Add texlive-libkpathsea. Resent-From: Thiago Jung Bauermann Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 13 Jul 2021 00:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48443 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Leo Prikler Cc: 48443@debbugs.gnu.org Received: via spool by 48443-submit@debbugs.gnu.org id=B48443.162613638626087 (code B ref 48443); Tue, 13 Jul 2021 00:34:02 +0000 Received: (at 48443) by debbugs.gnu.org; 13 Jul 2021 00:33:06 +0000 Received: from localhost ([127.0.0.1]:39071 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m36ME-0006mh-7J for submit@debbugs.gnu.org; Mon, 12 Jul 2021 20:33:06 -0400 Received: from mx.kolabnow.com ([95.128.36.41]:62586) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m36MB-0006mB-UA for 48443@debbugs.gnu.org; Mon, 12 Jul 2021 20:33:04 -0400 Received: from localhost (unknown [127.0.0.1]) by ext-mx-out001.mykolab.com (Postfix) with ESMTP id 72122A6F; Tue, 13 Jul 2021 02:32:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kolabnow.com; h= content-type:content-type:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:date:subject:subject :from:from:received:received:received; s=dkim20160331; t= 1626136376; x=1627950777; bh=4gqbvRn1WpvsBRz45tFUsK4xOMQe1JS9FPd jMvIT+vE=; b=L6Qzni5nWuFn/Ga2RvB+sQOdjA0wYN32X8suPZAuXzGYimcgaVU NCOQVqd5GpVWTCaiU4gvbdir4HyT5+qvnEVQpgPfcxfSu7s1eplKUrJPhEtqRt6P yYezNu7dgMyKUFGmZadgJHxYuuh178zWxzteydGtU/kUDIwDCiU+ajJ9aUnFBlS+ rSANRFRh3PqzjsjJqLQgO02J0X6DEkFMdkSKhUy80+hxr4S+QbCata7bN/p/g/xr CUNN7kYVqCKvPlS64jPdgDbNi5kUIhRarD1whGfn+plItt2sNvlLTtN9/tfgLauK AaILEhACRvPqmKydSk1ddO+MM0jpDHzGXIlbh4tDjds/m6jEHtll0N6YafgOFItE 7nFZdb1yQ6ffZK17Jzb9NEQdklO+4/bRPlH4gSoBWpZ3+bMyE8LAQ0Zyz1hewBbV 55j0s+y78fo3vGlr/84Yi3GupA9SWY5rP+G2PeZHEnqdbJLw2fd6SfvAH1tFg78W 5OPVMK2MVfByRZyF1j95Z+EccEdGIM9kI4Q4G8NwjoumzSHx9gFMLVJzn19a7B0t hKC+wlYEYFx2h8+pMka71/a6SULWs6E3bK6oytVrPATnsfCboAqV2oj1bYb0QJpY NnoAaPK0CGe4nRScRYNhuneNxcEPYbZhdjidLJfwSim0Pyhk0R1yCHLU= X-Virus-Scanned: amavisd-new at mykolab.com Received: from mx.kolabnow.com ([127.0.0.1]) by localhost (ext-mx-out001.mykolab.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id iaJhrlfxDERv; Tue, 13 Jul 2021 02:32:56 +0200 (CEST) Received: from int-mx003.mykolab.com (unknown [10.9.13.3]) by ext-mx-out001.mykolab.com (Postfix) with ESMTPS id 02EFA63E; Tue, 13 Jul 2021 02:32:54 +0200 (CEST) Received: from ext-subm003.mykolab.com (unknown [10.9.6.3]) by int-mx003.mykolab.com (Postfix) with ESMTPS id E69731BF0; Tue, 13 Jul 2021 02:32:53 +0200 (CEST) Date: Mon, 12 Jul 2021 21:32:47 -0300 Message-ID: <7264704.8eCzXKmJsZ@popigai> In-Reply-To: <20210515144230.22035-1-leo.prikler@student.tugraz.at> References: <20210515144230.22035-1-leo.prikler@student.tugraz.at> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: Thiago Jung Bauermann X-ACL-Warn: , Thiago Jung Bauermann via Guix-patches From: Thiago Jung Bauermann via Guix-patches via X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1626136450; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=4gqbvRn1WpvsBRz45tFUsK4xOMQe1JS9FPdjMvIT+vE=; b=YWETHJ6Nd93GmXDtPrrU71HZy/QzUJPOuYyJ7v/4fBsCQpJH4OseBcDADA7kVczxAByFKX /XjyGi9sxubegFtZJNFPR5r5sTIvCRQfc4jSJLunzV90fSgxKiy0I0RgdRt7UT5lIzFuhH nSwb2DtTfTyoPIOgDK15OgjkB4ptdReNabNzexG/pYO+o7ZBEnGOdJdiH6g/8Pz8+dQf6y InE48xcgJ2+yOjZKd7VNyV/0TSssiVDdFX6tUkpGzl3WfcqJUrAq97kfPV4LZw3PZMvMn0 e14u9tVQkftnNNCPJSyF2N59WtX2FZZeS0QjOy6SmzGLcW7B+1ZwzE3CzBj0Lw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1626136450; a=rsa-sha256; cv=none; b=bzTaHb3Z0gRQFVo2p2IpS8ltAPL7BWHovTMV8RIS1gF+yUyJ7erEHwTgjsPorZFe8sXHwH oiRKq+mPM6tS96k1uh94Cj64UdB14BW2bdeSsvH8YVw1+mNF9TlMEVOBqL20kL9fWURnIz 1ayfzIkCphht2HCiK9dURSsx9g1GE2kM7f6SoHxqB0JToCUf0jove9fcaEerTc0ssoFWcS 6SGFjSM5/RbchsIr/VMQ8eJWXmCPbtFWPnqQiFcwgTrktKFd/pmteawPehnGBV9Z8g577n S9GTcJiDKIk39KvDaBIbw0HsJfZrKYVklW/BrX0GKiX0PTDtySIk/B1+MNrjRQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=kolabnow.com header.s=dkim20160331 header.b=L6Qzni5n; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -2.41 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=kolabnow.com header.s=dkim20160331 header.b=L6Qzni5n; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 8F2CC1BA9E X-Spam-Score: -2.41 X-Migadu-Scanner: scn0.migadu.com X-TUID: WytMaymVrzRr Hello Leo, I have very little experience creating Guix packages, but I spent some time working on the TeX Live ones recently so hopefully my comments=20 and suggestions below are helpful. I like adding a separate package for libkpathsea, and it=E2=80=99s what oth= er=20 distros such as Debian and Ubuntu do. Thank you for implementing it. I just= =20 have a few comments below: Em s=C3=A1bado, 15 de maio de 2021, =C3=A0s 11:42:29 -03, Leo Prikler escre= veu: > * gnu/packages/tex.scm (texlive-libkpathsea): New variable. > --- > gnu/packages/tex.scm | 32 ++++++++++++++++++++++++++++++++ > 1 file changed, 32 insertions(+) >=20 > diff --git a/gnu/packages/tex.scm b/gnu/packages/tex.scm > index b9eeb0e792..3e8384eaad 100644 > --- a/gnu/packages/tex.scm > +++ b/gnu/packages/tex.scm > @@ -457,6 +457,38 @@ This package contains the binaries.") > (license (license:fsf-free > "https://www.tug.org/texlive/copying.html")) (home-page > "https://www.tug.org/texlive/"))) >=20 > +(define-public texlive-libkpathsea > + (package/inherit texlive-bin According to a recent message from Ludo=C2=B9, =E2=80=98package/inherit=E2= =80=99 is meant to be=20 used in specific situations, and IIUC it doesn=E2=80=99t apply here: > It should also be (package (inherit =E2=80=A6) =E2=80=A6) rather than (pa= ckage/inherit > =E2=80=A6). The latter is only useful when defining variants of a packag= e (same > version, same code) where the same security updates would apply. I also wonder whether inheriting from texlive-bin is the best option. One=20 disadvantage is that it makes this package too sensitive to changes in=20 texlive-bin. As an example, it doesn=E2=80=99t work anymore with the versio= n in=20 core-updates because in the branch, the =E2=80=98postint=E2=80=99 phase has= been renamed to=20 =E2=80=98post-install=E2=80=99. Also, I assume many texlive-bin inputs aren= =E2=80=99t needed for=20 texlive-kpathsea, causing unnecessary work when building texlive-libkpathsea and packages depending on it such as evince. In addition, if it were a separate package then texlive-bin could be made=20 to use it, rather than shipping its own copy. > + (name "texlive-libkpathsea") > + (source > + (origin > + (inherit (package-source texlive-bin)) Perhaps a =E2=80=98texlive-source-src=E2=80=99 variable analogous to =E2=80= =98texlive-extra-src=E2=80=99=20 and =E2=80=98texlive-texmf-src=E2=80=99 would be useful? > + (snippet > + `(begin > + ,(origin-snippet (package-source texlive-bin)) > + (with-directory-excursion "texk" > + (let ((preserved-directories '("." ".." "kpathsea"))) > + (for-each > + delete-file-recursively > + (scandir "." > + (lambda (file) > + (and (not (member file > preserved-directories)) + (eq? 'directory > (stat:type (stat file))))))))))))) + (arguments > + (substitute-keyword-arguments (package-arguments texlive-bin) > + ((#:configure-flags flags) > + `(cons* "--disable-all-pkgs" "--enable-kpathsea" > + "--enable-shared" ,flags)) > + ((#:phases phases) > + `(modify-phases ,phases > + (delete 'configure-ghostscript-executable) > + (delete 'use-code-for-new-poppler) > + (delete 'patch-dvisvgm-build-files) > + (delete 'disable-failing-test) > + (replace 'postint > + (lambda* (#:key inputs outputs #:allow-other-keys) > + (with-directory-excursion "texk/kpathsea" > + (invoke "make" "install")))))))))) If you decide to continue inheriting from texlive-bin, you=E2=80=99d also n= eed to=20 change the synopsis and description. =2D-=20 Thanks, Thiago =C2=B9 https://lists.gnu.org/archive/html/guix-patches/2021-07/msg00610.html