From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id MA9GDDcbc2AwEgAAgWs5BA (envelope-from ) for ; Sun, 11 Apr 2021 17:52:23 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id ODYJBjcbc2ADRQAAbx9fmQ (envelope-from ) for ; Sun, 11 Apr 2021 15:52:23 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A8F80A559 for ; Sun, 11 Apr 2021 17:52:21 +0200 (CEST) Received: from localhost ([::1]:35956 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lVcNo-0004UO-RA for larch@yhetil.org; Sun, 11 Apr 2021 11:52:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55950) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lVcNY-0004NF-7w for guix-patches@gnu.org; Sun, 11 Apr 2021 11:52:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:44221) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lVcNW-0001Un-L1 for guix-patches@gnu.org; Sun, 11 Apr 2021 11:52:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lVcNW-0008KV-JW for guix-patches@gnu.org; Sun, 11 Apr 2021 11:52:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#47582] [PATCH 2/2] gnu: Add python-pysctp. Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 11 Apr 2021 15:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47582 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Hartmut Goebel , 47582@debbugs.gnu.org Received: via spool by 47582-submit@debbugs.gnu.org id=B47582.161815630131993 (code B ref 47582); Sun, 11 Apr 2021 15:52:02 +0000 Received: (at 47582) by debbugs.gnu.org; 11 Apr 2021 15:51:41 +0000 Received: from localhost ([127.0.0.1]:55767 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lVcNA-0008Jv-NX for submit@debbugs.gnu.org; Sun, 11 Apr 2021 11:51:41 -0400 Received: from baptiste.telenet-ops.be ([195.130.132.51]:35344) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lVcN8-0008Jm-GJ for 47582@debbugs.gnu.org; Sun, 11 Apr 2021 11:51:39 -0400 Received: from ptr-bvsjgyjmffd7q9timvx.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:aaf1:9810:a0b8:a55d]) by baptiste.telenet-ops.be with bizsmtp id rTrb2400h0mfAB401TrcZS; Sun, 11 Apr 2021 17:51:36 +0200 Message-ID: <70afbbd7c248c27ddb9b7df9e454ad8697d354d1.camel@telenet.be> From: Maxime Devos Date: Sun, 11 Apr 2021 17:51:32 +0200 In-Reply-To: <2fc79c7d-9e4f-fa92-408d-0d8962aac5a5@crazy-compilers.com> References: <7403e614931a4e0763650380cd0e0da4db4ec888.1617463189.git.h.goebel@crazy-compilers.com> <35e212d90dd9d99a273e6c667cbd92b41b80219f.1617463189.git.h.goebel@crazy-compilers.com> <8aa40a9619cca1efe195f6007fc007a306919023.camel@telenet.be> <8a02c752caf7b2cbcfbedaca4dba945ca3aa6f50.camel@telenet.be> <2fc79c7d-9e4f-fa92-408d-0d8962aac5a5@crazy-compilers.com> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-Pw3lo+RtP1jGh18Px5Aw" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r21; t=1618156296; bh=991Dm1m2Yy/MFyEbIT07zGq0cYal96e0ekaIWVSnziw=; h=Subject:From:To:Date:In-Reply-To:References; b=lNj7xGEX8eed02qymDMVPwqJXGKouRHHgsxIhO9QvsJ2WfJbRbUn1oXmXPyEAYyAy V8pkKWZkvapS81ZvUsaaX/qPcVb6Il1KAq3Mg41yZ3iW/3Hg2PE9AGvU4HFP3EIwU1 eTYrLtCIpX+h79GcJNKXA/CPLXG5P5xiO7P18laMmLbjVDqqmKLj6aTYs0dE1oaSwp jmQzZVMY+SzkTkyM8mwvJI/xE8mMwBExTDYonnOSONONk4Wqkgr2gwLRiK8MByS1/T 0iEI7jTEKEODD0UgC45zJIXsHH/YAAJHa8I/U96UPc8BS8lOMDCwUy42WRvUm9hRP9 OffCY1eLk1P/A== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1618156341; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=991Dm1m2Yy/MFyEbIT07zGq0cYal96e0ekaIWVSnziw=; b=Li0VUyxCaRyqB4EHuDhoigTYfhR3PVC4nJUgOYajCY2R5O6dKCIR1Blost9waQcDQKXtDE YFv5cIj73UC5+VvpLqj48BL0r7CD+iQdgOcQ66inrnLFdlpajb9EZDt/6BeZrcAfc6fofn Zf7fEfFdo+KF9LiJYAITv51+2vglBKTmGCcXStUArGhrYyLS4WWTK+6b/S9VYU84mY/sS9 MoORfVbgRSgVk1GkrCc9Ez1EN3XfFW3BrjItqzBi7jzniwQeHsPRBLAsJBdvJX+qtC+Qka JG/qCKl1XLOWttzW+X0T6dNRCpWqxCw3r/drkyPqPfgOoLPDaJRXlsC/kJGjBw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1618156341; a=rsa-sha256; cv=none; b=F55Pr9jbqBsuoTc6kW7uB5YqvA5O/SdSOFmBHAgu1qGAy14mkdHJ2/BcbjtZ+58N0OmA3L 3R41WsnruhRiVmWmVTM9+5nB943nmqgzfRzY2itdXoveTezk9GRDV0l7MOr+new1anff4d Ffe1EuPnxaZjS4CXcMiXbjihu0NhjIQNm/vmPEwDQ2r/9DLWu+7YkNU6fGAWa3PExOCxYT Ngu4wbuEZlG0EOXAsW32KfeRoy/tHZFdwAZeYlYbfJpggYw5JuOPysGNT6cCJhfog0T+f7 fg6WAdMIKOO3qbS9rTb+wTAHhvjx0zvRyPmnxHFzWqiuLTcDIKOEQ1iXNI+nLw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r21 header.b=lNj7xGEX; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.94 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r21 header.b=lNj7xGEX; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: A8F80A559 X-Spam-Score: -1.94 X-Migadu-Scanner: scn0.migadu.com X-TUID: jogp0E0c8+Il --=-Pw3lo+RtP1jGh18Px5Aw Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sun, 2021-04-11 at 17:07 +0200, Hartmut Goebel wrote: > Thanks for the review. I applied most of the changes and poushed as > 03e80cf42240f65346713ff414eb2ca628ef0884 >=20 > If did not apply >=20 > > Suggestion: replace (getenv "C_INCLUDE_PATH") with > > (getenv ,(if (%current-target-system) > > "CROSS_C_INCLUDE_PATH" > > "C_INCLUDE_PATH")). > > Likewise for LIBRARY_PATH. I could be wrong about how/when "CROSS_C_INCLUDE_PATH" or "C_INCLUDE_PATH" = should be used. I don't agree with the following reasoning however: > since "CROSS_C" is used on 14 times in gnu/packages/*.scm and not at all > in guix/build*. So I assume this is not the way to implement > cross-compiling :-) ... as many (much more than 14) packages have cross-compilation bugs. For example, try searching for "CC=3Dgcc". Practically all usages are inco= rrect, they should use ,(string-append "CC=3D" (cc-for-target)) instead. gcc =3D *not* the cross-compiler (cc-for-target): when cross-compiling, something like "aarch64-linux-gnu-gc= c", otherwise simply "gcc". I've submitted a patch adding a linter, and a patch series fixing some of t= he buggy packages (at least instances of "CC=3Dgcc", there may be other bugs). Links: https://issues.guix.gnu.org/47676, https://issues.guix.gnu.org/47693 Greetings, Maxime. --=-Pw3lo+RtP1jGh18Px5Aw Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYHMbBBccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7hNPAQCwhZSXlOHO90kCh8mJTeTtgWK9 n9UwxfbXhmpgiYAKggD/fGBa93Vy7Q7Mt62cd1za22RzkmVcaOawwDqdu8jeOQw= =Y4Uj -----END PGP SIGNATURE----- --=-Pw3lo+RtP1jGh18Px5Aw--