From: Maxime Devos <maximedevos@telenet.be>
To: Christopher Baines <mail@cbaines.net>, 47288@debbugs.gnu.org
Subject: [bug#47288] [PATCH] guix: http-client: Tweak http-multiple-get error handling.
Date: Sun, 21 Mar 2021 09:36:42 +0100 [thread overview]
Message-ID: <70ae9918cfe06c3dcce6764f170a96b55e275d4d.camel@telenet.be> (raw)
In-Reply-To: <20210321004338.31867-1-mail@cbaines.net>
[-- Attachment #1: Type: text/plain, Size: 1908 bytes --]
On Sun, 2021-03-21 at 00:43 +0000, Christopher Baines wrote:
> This isn't meant to change the way errors are handled, and arguably makes the
> code harder to read, but it's a uninformed attempt to improve the
> performance (following on from a performance regression in
> 205833b72c5517915a47a50dbe28e7024dc74e57).
>
> I'm guessing something about Guile internals makes calling (loop ...) within
> the catch bit less performant than avoiding this and calling (loop ...) after
> the catch bit has finished. Since this happens lots, this seems to be
> sufficient to make guix weather a lot slower than it was before.
I took a look at the code, and it seems we did somthing like:
(let loop VARS
(match sent
NON-LOOPING-CASES
(STUFF
(catch #t
THUNK-THAT-MIGHT-CALL-LOOP-IN-TAIL-POSITION
SOME-HANDLER-THAT-DOES-NOT-CALL-LOOP)
A small demonstration of what could go wrong with such a construction
(run this in the Guile REPL):
(let loop ((attempts-todo 20))
(catch 'oops
(lambda ()
(if (<= 0 attempts-todo)
(loop (- attempts-todo 1))
(throw 'oops)))
(lambda _ (display 'too-bad!) (newline) (backtrace))))
Output:
too-bad!
Backtrace:
In ice-9/boot-9.scm:
1731:15 19 (with-exception-handler #<procedure 7f73c7e615a0 at ice-9/boot-9.scm:1815:7 (exn)> _ # _ …)
[The previous line repeated 17 times]
1731:15 1 (with-exception-handler #<procedure 7f73c7e61240 at ice-9/boot-9.scm:1815:7 (exn)> _ # _ …)
In unknown file:
0 (backtrace #<undefined>)
With this construction, we were nesting exception handlers within exception handlers
... So in hindsight it doesn't seem surprising this isn't very performant.
(THUNK-THAT-MIGHT-CALL-LOOP-IN-TAIL-POSITION itself is not called in the tail-position
of the '(let loop ...)' form.)
Hope that sheds some light on the matter,
Maxime
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]
next prev parent reply other threads:[~2021-03-21 8:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-21 0:43 [bug#47288] [PATCH] guix: http-client: Tweak http-multiple-get error handling Christopher Baines
2021-03-21 0:56 ` [bug#47288] [PATCH v2] " Christopher Baines
2021-03-24 14:55 ` [bug#47288] [PATCH] " Ludovic Courtès
2021-03-25 11:09 ` Christopher Baines
2021-03-24 14:55 ` Ludovic Courtès
2021-03-21 8:36 ` Maxime Devos [this message]
2021-03-25 11:03 ` [bug#47288] [PATCH v3 1/2] " Christopher Baines
2021-03-25 11:03 ` [bug#47288] [PATCH v3 2/2] guix: http-client: Refactor http-multiple-get Christopher Baines
2021-03-25 22:20 ` [bug#47288] [PATCH] guix: http-client: Tweak http-multiple-get error handling Ludovic Courtès
2021-03-26 8:39 ` Christopher Baines
2021-03-27 17:15 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=70ae9918cfe06c3dcce6764f170a96b55e275d4d.camel@telenet.be \
--to=maximedevos@telenet.be \
--cc=47288@debbugs.gnu.org \
--cc=mail@cbaines.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).