From: Maxime Devos <maximedevos@telenet.be>
To: Charles <charles.b.jackson@protonmail.com>,
Julien Lepiller <julien@lepiller.eu>
Cc: "53704@debbugs.gnu.org" <53704@debbugs.gnu.org>
Subject: [bug#53704] Bump
Date: Sat, 12 Feb 2022 12:35:29 +0100 [thread overview]
Message-ID: <708d9f2b29e09f3906d36ecefc8c273bb589d1b4.camel@telenet.be> (raw)
In-Reply-To: <3c9dxjEeXYXD76uUQgjwTlqZOtOb7IFb8FX50AHQoH9bc-bapcr6kxnaouHjVYd3CaIPjKPiuUwZ6tx6VW-YRPKUMri5i_mLx4du5ux81a8=@protonmail.com>
[-- Attachment #1: Type: text/plain, Size: 2454 bytes --]
Charles via Guix-patches via schreef op za 12-02-2022 om 00:30 [+0000]:
> + (source
> + (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url
> "https://github.com/visualboyadvance-m/visualboyadvance-m/")
> + (commit (string-append "v" version))))
> + (file-name (git-file-name name version))
> + (sha256
> + (base32
> "1kgpbvng3c12ws0dy92zc0azd94h0i3j4vm7b67zc8mi3pqsppdg"))
> + (patches (search-patches "visualboyadvance-m-fix-
> rpath.patch"))))
The iniparser package is bundled in src/common/iniparser.c and
src/common/iniparser.h.
A part of a variant of zlib is in src/common/memgzio.c and
src/common/memgzio.h. I think it's ok in this case, since it appears
to be modified for use in visualboyadvance-m. However, the license of
zlib needs to be respected:
/* gzio.c -- IO on .gz files
* Copyright (C) 1995-2002 Jean-loup Gailly.
* For conditions of distribution and use, see copyright notice in
zlib.h
*
* Compile this file with -DNO_DEFLATE to avoid the compression code.
*/
I don't see zlib.h anywhere and the zlib license requires preserving
the license notice:
3. This notice may not be removed or altered from any source
distribution.
There is another problem: the version in visualboyadvance-m is old
(2002, according to the copyright line) while there have been
quite a few bugfixes since then (https://www.zlib.net/ChangeLog.txt).
Another bundled library: src/common/dictionary.c and
src/common/dictionary.h.
There is also src/filters/bilinear.cpp which is extracted from Exult
(GPL2+ licensed), but it appears that the copyright+license header was
not preserved, while preserving that is a requirement of the GPL IIUC?
The files in src/filters/xBRZ are GPL3 licensed, so 'license:gpl2+'
in the package definition seems inaccurate. It is unclear of GPL3-only
or GPL3-or-later was meant.
The file src/gba/debugger-expr-lex.cpp and src/gba/debugger-expr-
yacc.cpp are generated by flex and Bison, can they be generated during
the build?
libretro is bundled in src/libretro, can it be unbundled?
src/expr.cpp and src/expr.cpp.h are generated files, not source code.
A part of glibc is bundled in src/sdl/getopt1.c, src/sdl/getopt.c
and src/sdl/getopt.h.
wxwidgets is bundled in src/wx.
Greetings,
Maxime.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]
next prev parent reply other threads:[~2022-02-12 11:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-01 17:36 [bug#53704] Add Visualboyadvance-m Charles via Guix-patches via
2022-02-11 6:51 ` [bug#53704] Bump Charles via Guix-patches via
2022-02-11 7:05 ` Julien Lepiller
2022-02-12 0:30 ` Charles via Guix-patches via
2022-02-12 9:54 ` Maxime Devos
2022-02-12 10:11 ` Maxime Devos
2022-02-12 11:35 ` Maxime Devos [this message]
2022-02-12 12:17 ` Maxime Devos
2022-02-12 13:31 ` Maxime Devos
2022-02-12 23:45 ` Charles via Guix-patches via
2022-02-27 0:19 ` Charles via Guix-patches via
2022-02-27 10:52 ` Maxime Devos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=708d9f2b29e09f3906d36ecefc8c273bb589d1b4.camel@telenet.be \
--to=maximedevos@telenet.be \
--cc=53704@debbugs.gnu.org \
--cc=charles.b.jackson@protonmail.com \
--cc=julien@lepiller.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).