From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36978) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e57P3-0006Dl-55 for guix-patches@gnu.org; Thu, 19 Oct 2017 05:46:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e57Ot-00014f-Fi for guix-patches@gnu.org; Thu, 19 Oct 2017 05:46:13 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:40424) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e57Ot-00014V-CT for guix-patches@gnu.org; Thu, 19 Oct 2017 05:46:03 -0400 Subject: [bug#28841] [PATCH 02/24] =?UTF-8?Q?gnu:=C2=A0Add?= java-tomcat. Resent-Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Thu, 19 Oct 2017 11:45:28 +0200 From: julien lepiller In-Reply-To: <87d15k428g.fsf@elephly.net> References: <20171014233216.49c852f7@lepiller.eu> <20171014222349.12902-1-julien@lepiller.eu> <20171014222349.12902-2-julien@lepiller.eu> <87d15k428g.fsf@elephly.net> Message-ID: <708a71e62e147b8e0e9e93de4870d844@lepiller.eu> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: 28841@debbugs.gnu.org Le 2017-10-18 22:42, Ricardo Wurmus a écrit : > Hi again, > >> * gnu/packages/java.scm (java-tomcat): New variable. >> --- > > […] > >> + (inputs >> + `(("java-eclipse-jdt-core" ,java-eclipse-jdt-core))) > > Actually … I’m *very* surprised that this is the only input here. I > remember trying to package this early on, but failing because there > were > so many unpackaged dependencies. > > Are you sure this is the only required input here? Do the sources come > with bundled jars? I've added this to a phase: (for-each delete-file (find-files "." ".*.jar$")) and it still builds correctly, so i'm fairly confident that's the only required dependency. The tests though have a lot of dependencies that are fetched by the build script, but it's disabled in the "properties" phase (I should use a different phase though, because it has nothing to do with properties). Now I have no idea how tomcat is supposed to work. I only need it because it has a more recent version of the servlet api that is required at least by jetty, and that part at least is correct. Maybe some of the dependencies are actually run-time dependencies? At first I wanted to create only a java-tomcat-servlet-api package, but I can't use the upstream build.xml for that. I will apply all your suggestions of course. Thank you for the review!