From: Ahmad Draidi via Guix-patches via <guix-patches@gnu.org>
To: 70285@debbugs.gnu.org
Cc: Ahmad Draidi <a.r.draidi@redscript.org>, ludo@gnu.org
Subject: [bug#70285] [PATCH v2 3/3] services: cuirass: Remove use-substitutes? configuration option.
Date: Thu, 2 May 2024 05:37:49 +0400 [thread overview]
Message-ID: <703c8515cdde9c643d687e527a1f4b0e568d7889.1714613869.git.a.r.draidi@redscript.org> (raw)
In-Reply-To: <afc3d0e937cd07def1c13fd1f2a687f8e50b7faa.1714613869.git.a.r.draidi@redscript.org>
As of Cuirass commit 9a1452ee021c9f773424961cfeef47ca0b7c5c5a, this option
seems to be unused and kept for back compatibility there.
* gnu/services/cuirass.scm (<cuirass-configuration>): Remove use-substitutes?
field.
(cuirass-shepherd-service): Remove the option.
* doc/guix.texi (Continuous Integration): Remove option documentation.
Change-Id: I933550ce76eecdf918b07891aa8212fd30a7c87e
---
v2 changes: None
doc/guix.texi | 4 ----
gnu/services/cuirass.scm | 4 ----
2 files changed, 8 deletions(-)
diff --git a/doc/guix.texi b/doc/guix.texi
index 1f97a2796e..0ddf75693a 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -34459,10 +34459,6 @@ Continuous Integration
specifications records. The specification record is described in the
Cuirass manual (@pxref{Specifications,,, cuirass, Cuirass}).
-@item @code{use-substitutes?} (default: @code{#f})
-This allows using substitutes to avoid building every dependencies of a job
-from source.
-
@item @code{one-shot?} (default: @code{#f})
Only evaluate specifications and build derivations once.
diff --git a/gnu/services/cuirass.scm b/gnu/services/cuirass.scm
index f430c38a69..f68b4dc5a2 100644
--- a/gnu/services/cuirass.scm
+++ b/gnu/services/cuirass.scm
@@ -117,8 +117,6 @@ (define-record-type* <cuirass-configuration>
(default "localhost"))
(specifications cuirass-configuration-specifications)
;gexp that evaluates to specification-alist
- (use-substitutes? cuirass-configuration-use-substitutes? ;boolean
- (default #f))
(one-shot? cuirass-configuration-one-shot? ;boolean
(default #f))
(fallback? cuirass-configuration-fallback? ;boolean
@@ -147,7 +145,6 @@ (define (cuirass-shepherd-service config)
(config-file (scheme-file
"cuirass-specs.scm"
(cuirass-configuration-specifications config)))
- (use-substitutes? (cuirass-configuration-use-substitutes? config))
(one-shot? (cuirass-configuration-one-shot? config))
(fallback? (cuirass-configuration-fallback? config))
(extra-options (cuirass-configuration-extra-options config))
@@ -182,7 +179,6 @@ (define (cuirass-shepherd-service config)
parameters))
'())
#$@(if remote-server '("--build-remote") '())
- #$@(if use-substitutes? '("--use-substitutes") '())
#$@(if one-shot? '("--one-shot") '())
#$@(if fallback? '("--fallback") '())
#$@extra-options)
--
2.41.0
prev parent reply other threads:[~2024-05-02 1:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-08 17:48 [bug#70285] [PATCH 0/3] Cuirass service config options work Ahmad Draidi via Guix-patches via
2024-04-08 17:54 ` [bug#70285] [PATCH 1/3] services: cuirass: Use separate extra options for cuirass web process Ahmad Draidi via Guix-patches via
2024-04-08 17:54 ` [bug#70285] [PATCH 2/3] services: cuirass: Add new configuration options Ahmad Draidi via Guix-patches via
2024-04-29 21:33 ` Ludovic Courtès
2024-05-02 1:36 ` Ahmad Draidi via Guix-patches via
2024-05-04 16:21 ` bug#70285: " Ludovic Courtès
2024-04-08 17:54 ` [bug#70285] [PATCH 3/3] services: cuirass: Remove use-substitutes? configuration option Ahmad Draidi via Guix-patches via
2024-05-02 1:37 ` [bug#70285] [PATCH v2 1/3] services: cuirass: Use separate extra options for cuirass web process Ahmad Draidi via Guix-patches via
2024-05-02 1:37 ` [bug#70285] [PATCH v2 2/3] services: cuirass: Add new configuration options Ahmad Draidi via Guix-patches via
2024-05-02 1:37 ` Ahmad Draidi via Guix-patches via [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=703c8515cdde9c643d687e527a1f4b0e568d7889.1714613869.git.a.r.draidi@redscript.org \
--to=guix-patches@gnu.org \
--cc=70285@debbugs.gnu.org \
--cc=a.r.draidi@redscript.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).