From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id 0HsPHSlF7Ga6nwAAe85BDQ:P1 (envelope-from ) for ; Thu, 19 Sep 2024 15:37:13 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id 0HsPHSlF7Ga6nwAAe85BDQ (envelope-from ) for ; Thu, 19 Sep 2024 17:37:13 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b="HmJQDW/e"; dkim=fail ("headers rsa verify failed") header.d=rimm.ee header.s=herman header.b=JOjxsDw6; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1726760233; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=61BiW5h4gSPtwL7hoFt3W+OvONW0h79bZCfR/Z647y8=; b=jNolrwF6bsJ2FWlA5msYXmzO0htXeACzn5sKJqam0WiCA7ynZZE/CZQwuwT4DlWP9uVfuf 5/KPD2kJYgJbXuT60vTYn8RWFlcgtx0wLrbPj6OKEcKtty4bj8nRgkWcjlWzLWCA+wIKxM oBXGVaAzsigaxxB1rGACi1/5olSHqjCim5ZF/9k0WLS9g3aqkXxx6r5yvi4RbbGvx/wwkZ yRu8LsLvvnXJCmcqwr4TpcGi61b+iQMpyWYbJLZdRejZu635nQsKlpH0pBrEpfSNqBLQtr WpfzQhapZYrYlIqu8YJKyfBisIc5agIi57aEe6qXEXbi7i2QtQTlEKdGFFJs5g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b="HmJQDW/e"; dkim=fail ("headers rsa verify failed") header.d=rimm.ee header.s=herman header.b=JOjxsDw6; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1726760233; a=rsa-sha256; cv=none; b=U4sXh015C+X0qIP9ebJC/wGL4RQYrbhyRO32dr2lA/OECvDKfuG3dsAwimJOCC27WSEwwP 81w+qEtspYqjEhcXpJVPEDZLnvhXGgcG+CMvvKrEaCp+vwismlmvYbK5/R2k/ve7y7MdSs zY3VpWQ9JJgAJHx4nDM4GtshQCOh9LYcXXhVBijLBuZ5qLinuYwzzHOjjNnl3TDQEFE9nq WEAD1ZBXy9ap+a4DJBWixfqOgbKR0bnXLDc5iVlvd7EVLyxdUouuVXZ5nBjai12d1P5pwW CujBvpadFDqOSggnn6SoJOFnVOODOp9lRMZC8wwS+U5dUxVvyIF3u8nvHJNGrQ== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id AFCCE5C16 for ; Thu, 19 Sep 2024 17:37:12 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1srJD4-0004wi-KP; Thu, 19 Sep 2024 11:36:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1srJD2-0004wE-VN for guix-patches@gnu.org; Thu, 19 Sep 2024 11:36:45 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1srJD2-0003BS-MM for guix-patches@gnu.org; Thu, 19 Sep 2024 11:36:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=In-Reply-To:MIME-Version:References:From:Date:To:Subject; bh=61BiW5h4gSPtwL7hoFt3W+OvONW0h79bZCfR/Z647y8=; b=HmJQDW/ebLl2jmQIeHZciZuwL6bZYTdI6x3pRfHkFs9xC5F1cB0mghUd032ZosIxua6hQ5SAABbL8MXTPgwcMxzSi4jKE3+ABAJEvaL+I9cc8fqdOGEZVyEJGG/KEX3XeetKR7XCRoF6Kqe7RVzW9v5cpmYUGxt+eTO64no4qFAz3IlGKAcrdBpT9ehA5fwaWiMsEXeG4UyeERUZoit6UfGZLZnXADSLvbDdxm2eu8jbcFAtKMYRFokPtZQUZhNaVBFFX9+XVp2F2ycJ3x4V6SNJaRphzzLRl84h+BxfKWRuWB/LL9gRU/IJJ75ioHprB4gjWG2/UFWFzYF7Yq7+jg==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1srJDK-0006Je-1J for guix-patches@gnu.org; Thu, 19 Sep 2024 11:37:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#72457] [PATCH v5 00/15] Rewrite bootloader subsystem. Resent-From: Herman Rimm Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 19 Sep 2024 15:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72457 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 72457@debbugs.gnu.org Cc: Lilah Tascheter Received: via spool by 72457-submit@debbugs.gnu.org id=B72457.172676020324248 (code B ref 72457); Thu, 19 Sep 2024 15:37:01 +0000 Received: (at 72457) by debbugs.gnu.org; 19 Sep 2024 15:36:43 +0000 Received: from localhost ([127.0.0.1]:33267 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1srJD0-0006J1-QO for submit@debbugs.gnu.org; Thu, 19 Sep 2024 11:36:43 -0400 Received: from 81-205-150-117.fixed.kpn.net ([81.205.150.117]:38329 helo=email.rimm.ee) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1srJCx-0006If-BW for 72457@debbugs.gnu.org; Thu, 19 Sep 2024 11:36:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rimm.ee; s=herman; t=1726760172; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=61BiW5h4gSPtwL7hoFt3W+OvONW0h79bZCfR/Z647y8=; b=JOjxsDw6rjuszGOyqnulMS+zAVnBGb8a/tnyCmz+kDWZ63tBi0kZURB1p97TJVJjd7V+dH 6SAEiuJtPDhnZESfXQ8/FmoVE+C6dxWISK5ifKmYaI9E3s8jVLEBheX1eTaC72pqmGRwZI HgzhKL5hIEb2aOb+jfWFAS7DjKMpIHQDHL4YtN6eqppNgCIPjAd2+199YUyxSFngFn/nOu d/SR6bs70Et9fDWDMPYr1k+O1iVYUthEfJBsgqY5kdjRZAuCtVyRbxh/ajnoetMM016O4F fD+9/w6JlR/xXOw4q42u+5LKh3IwES68CbBL8W0en7gL4Dm/Y02j1lj7Q6btfA== Received: by 81-205-150-117.fixed.kpn.net (OpenSMTPD) with ESMTPSA id 5f9e62b5 (TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO); Thu, 19 Sep 2024 15:36:11 +0000 (UTC) Date: Thu, 19 Sep 2024 17:35:29 +0200 Message-ID: <6v2spbtqb66twxchy4wkmoq6fyjqtrr2g3mhotwignplqwjxl4@qpeqf5d6hxow> References: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Herman Rimm X-ACL-Warn: , Herman Rimm via Guix-patches From: Herman Rimm via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Queue-Id: AFCCE5C16 X-Migadu-Scanner: mx11.migadu.com X-Spam-Score: -6.51 X-Migadu-Spam-Score: -6.51 X-TUID: k1JwbmL9a7Tx On Tue, Sep 17, 2024 at 05:20:05PM -0500, Lilah Tascheter wrote: > > I would like to submit a rewritten patch series.  Basically, it would > > consist of patches #4, #6, #12, #13, and #14. > since efi's getting split out, would it make sense to split #6 out too? > though, that could pose issues if it gets forgotten and the others get > merged. your choice! I would rather not adapt the existing Raspberry Pi bootloader to the new system. > > I want to submit #1, #2, #3, #5 and #15 to issue #73202 > so, #73202'd end up being a general cleanup of the current bootloader > system, right? I feel #2 wouldn't quite fit there, seeing as it just > adds the infastructure needed for #4. #73202 is also preparation for this issue. I think #2 is big enough for it to reviewed on its own outside of this issue, and that #73202 is small enough to fit #2. > > #7, #8, #9, #10 (excl. efibootmgr) and #11 to #68524. > I'll send an unmerge to #68524 then! Thanks. > > Parts of patch #4 which fit better with #73202 or function standalone > > would be submitted to #73202.  Finally, #4 will be split into seven > > to ten patches, hopefully making referring to changes easier and > > review less demanding. > this sounds great! but, > good fucking luck splitting up #4. a ton of the changes are > interconnected, and it'll be a pain to do so if you don't want some > commits to just not compile. if you can pull it off, that'd be amazing! I don't intend for the commits to compile. It's to adequately describe the changes while fitting each commit message on a monitor and to give reviewers the choice of squashing them together into one working commit. > > [1]: https://codeberg.org/herman_rimm/guix > typo in gnu/build/bootloader.scm "thtat", also > gnu/system/install.scm(embedded-installation-os) operating-system- > bootloader's default is '(), not #f. otherwise, this looks great!!! Fixed, thanks. > I'm also thinking now, since you mentioned the operating-system- > bootloader sanitizer in a previous email, it'd probably be a good idea > to expand the sanitizer to detect for 'part type targets too. a simple > /dev/.*[0-9] regex should work well? I can write a quick patch up for > you, or you can just include that when making the new patch series if > you'd prefer? I had stashed the changes I made to warn-update-targets. I do try to create branches and fixup commits instead to better track changes. Anyway, maybe you can send a diff based on/relative to: ;; Based on report-duplicate-field-specifier from (guix records). (define (report-duplicate-type-field targets) "Report the first target with duplicate type among TARGETS." (let loop ((targets targets) (seen '())) (match targets ((target rest ...) (let (type (bootloader-target-type target))) (when (memq type seen) (error loc (G_ "target with duplicate type~%") duplicate)) (loop rest (cons type seen))) (() #t)))) (define-with-syntax-properties (warn-update-targets (targets properties)) (let ((targets (if (list? targets) targets (list targets))) (loc (source-properties->location properties))) (define string->target (match-lambda ((? bootloader-target? target) target) ((? string? s) (if (string-prefix? "/dev" s) (bootloader-target (type 'disk) (device s)) (bootloader-target (type 'esp) (offset 'root) (path s)))) (x (error loc (G_ "invalid target '~a'~%") x)))) ;; XXX: Should this be an error? (when (any string? targets) (warning loc (G_ "the 'targets' field should now contain \ records, inferring a best guess, this might break!~%"))) (let* ((targets (map string->target targets))) (report-duplicate-type-field targets) targets))) > > [2]: ... > looks like the failure here was caused by cpan failing to build, which > shouldn't be (hopefully isn't) a result of this patchset. what does the > build log mentioned say? I think because the build log was on a VFS I couldn't access it directly. But why do these packages need to be built at all? > thanks so much for all the help, by the way :) No problem. Cheers, Herman