From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id oMpeO64o5mWMegAAe85BDQ:P1 (envelope-from ) for ; Mon, 04 Mar 2024 21:01:51 +0100 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id oMpeO64o5mWMegAAe85BDQ (envelope-from ) for ; Mon, 04 Mar 2024 21:01:51 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; none Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C2DF224476 for ; Mon, 4 Mar 2024 21:01:50 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rhEVE-00054m-4V; Mon, 04 Mar 2024 15:01:36 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rhEVB-00051q-T3 for guix-patches@gnu.org; Mon, 04 Mar 2024 15:01:33 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rhEVA-0001rK-Qx for guix-patches@gnu.org; Mon, 04 Mar 2024 15:01:33 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rhEVe-0000Kh-Hm for guix-patches@gnu.org; Mon, 04 Mar 2024 15:02:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#67260] [PATCH emacs-team v11 0/7] You thought it was term/internal.el, but it was me, Dio! Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 04 Mar 2024 20:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67260 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Andrew Tropin , 67260@debbugs.gnu.org Cc: cox.katherine.e+guix@gmail.com, Suhail Received: via spool by 67260-submit@debbugs.gnu.org id=B67260.17095824721207 (code B ref 67260); Mon, 04 Mar 2024 20:02:02 +0000 Received: (at 67260) by debbugs.gnu.org; 4 Mar 2024 20:01:12 +0000 Received: from localhost ([127.0.0.1]:44982 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rhEUp-0000JO-KE for submit@debbugs.gnu.org; Mon, 04 Mar 2024 15:01:12 -0500 Received: from mail-ej1-f68.google.com ([209.85.218.68]:53351) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rhEUo-0000JA-96 for 67260@debbugs.gnu.org; Mon, 04 Mar 2024 15:01:11 -0500 Received: by mail-ej1-f68.google.com with SMTP id a640c23a62f3a-a458b6d9cfeso78607866b.2 for <67260@debbugs.gnu.org>; Mon, 04 Mar 2024 12:00:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709582375; x=1710187175; darn=debbugs.gnu.org; h=mime-version:user-agent:references:in-reply-to:date:cc:to:from :subject:message-id:from:to:cc:subject:date:message-id:reply-to; bh=lHGaixC8GpoQ+129rwYCQcmWZPfNXK8+gR1IM5lMbPU=; b=PSEdMzoNYZeuGFq2R0p0YxoGYh6JH0DtCQE75/r4RE63ROLmZO7TRGEXKzmCE+eokN hSkus/VNOU17+QiFV5rCS0Cvbvk6pR7anHFjqHdMTNr6/tN1SNDNV719lEvEjW/2X0lX 9qudy+07FEV939sVpfi1lJ2ciENw4itsEsf0WHcHIwWp9ahsDjz67q1ImhLud2mH28CF kr/7CuInQMxGsgqdBg4I3zuWNqeqeBP0PiDHqj2D8COj4t/xfBnrw0KlRIu/69PjC+aq QKeZro290hWiBx2jscxGuJzLyAlwSWAwyBmNpHhi8d0QCBkirRhspRTwlcKYPRNmpXSN wiwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709582375; x=1710187175; h=mime-version:user-agent:references:in-reply-to:date:cc:to:from :subject:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=lHGaixC8GpoQ+129rwYCQcmWZPfNXK8+gR1IM5lMbPU=; b=eWLgREdbHwoiiLZ3u/IyOBW3uYxtdlrXrPsvyRFeUThnclrZAHamqjLiyB+R9ORmOb ariULjKUJyzBReqtRPzaT2ZPX1pJw6zHpOtY7TLi9MruwYc6UrTjm4n6t5+yBlPSNfVF JL8yWnezx+eEma8vIgbUEqsFzTHeDLuhRIV33cdt2TvU8UovrXtIxoZ+p3qVafABhb5c RuE4kTcFq7/DNpr8FNJ9ob6T6IVrFX2/eom4n4JMznK5WPEe+Usi9iU2aluc8ZR2bavK /Fu7F1lRXi5EAaJF+MTnaXTIp1A6whLBp58udyl/38Pp/wex7xJP9mYAHpun672WkYIJ npzA== X-Forwarded-Encrypted: i=1; AJvYcCUgYY6aNEJQePYyH/y2rI7WKmBYZJ5vR+Xid6silPgZ5MVoRcUxV+eXQ7D/i4vmJOPD+dtzNmlHZ2yDs0SsViCDE/U5IsA= X-Gm-Message-State: AOJu0YyPjkjTRYo0OnBAGUcKJNzqo5Jf41H+9mAUNTiIHwCYf1tnVcwR eQhY47BjinOxfcr1Xik5sKSHjp750hnq1/UCdVnACYygDEo+BKcu X-Google-Smtp-Source: AGHT+IHBTBa6R95aY7n6P1fFD4sYiaflSvtP3dPd8O4HRCjySbYkG4CuQAMG67UMKUhLF4vr4NJciQ== X-Received: by 2002:a17:906:b00c:b0:a44:c1a9:ee37 with SMTP id v12-20020a170906b00c00b00a44c1a9ee37mr5731253ejy.61.1709582374449; Mon, 04 Mar 2024 11:59:34 -0800 (PST) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id z19-20020a170906075300b00a44cf710cc3sm3203178ejb.182.2024.03.04.11.59.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Mar 2024 11:59:34 -0800 (PST) Message-ID: <6eb2791017ee33d78afc480d9aa68498c1c5a8c1.camel@gmail.com> From: Liliana Marie Prikler Date: Mon, 04 Mar 2024 20:59:32 +0100 In-Reply-To: <87il22bhal.fsf@trop.in> References: <87il22bhal.fsf@trop.in> Content-Type: multipart/mixed; boundary="=-Ldn0F9+yx8pWgleDiQ7g" User-Agent: Evolution 3.46.4 MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx10.migadu.com X-Migadu-Spam-Score: -4.00 X-Spam-Score: -4.00 X-Migadu-Queue-Id: C2DF224476 X-TUID: wtdvXdfwkicK --=-Ldn0F9+yx8pWgleDiQ7g Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Am Montag, dem 04.03.2024 um 10:13 +0300 schrieb Andrew Tropin: > On 2024-02-24 09:04, Liliana Marie Prikler wrote: >=20 > > After a week of debugging the internals of how Emacs compiles, > > loads, > > and dumps (!) its .eln-files, I finally came up with the perfectly > > cursed mix that enables us to actually load *and* graft our > > natively > > compiled packages with ease. > >=20 > > In unrelated news, I feel like I should wear a witch hat for faster > > development cycles. > >=20 > > Liliana Marie Prikler (7): > > =C2=A0 gnu: emacs: Build trampolines. > > =C2=A0 gnu: emacs: Don't hash file names in native compilation. > > =C2=A0 gnu: emacs: Check integrity of native-compiled files. > > =C2=A0 gnu: emacs: Disable jit compilation. > > =C2=A0 build-system: emacs: Compute relative file names. > > =C2=A0 gnu: emacs-org: Fix native builds. > > =C2=A0 gnu: emacs-magit: Fix native builds. > >=20 > > =C2=A0Makefile.am=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= |=C2=A0=C2=A0 1 + > > =C2=A0gnu/local.mk=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |= =C2=A0=C2=A0 2 + > > =C2=A0.../aux-files/emacs/comp-integrity.el=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0 | 126 +++++++ > > =C2=A0gnu/packages/emacs-xyz.scm=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= |=C2=A0 10 +- > > =C2=A0gnu/packages/emacs.scm=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0 |=C2=A0 20 +- > > =C2=A0.../emacs-disable-jit-compilation.patch=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 |=C2=A0 19 + > > =C2=A0.../emacs-native-comp-fix-filenames.patch=C2=A0=C2=A0=C2=A0=C2=A0= | 338 > > ++++++++++++++++++ > > =C2=A0guix/build/emacs-utils.scm=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= |=C2=A0=C2=A0 4 +- > > =C2=A08 files changed, 516 insertions(+), 4 deletions(-) > > =C2=A0create mode 100644 gnu/packages/aux-files/emacs/comp-integrity.el > > =C2=A0create mode 100644 gnu/packages/patches/emacs-disable-jit- > > compilation.patch > > =C2=A0create mode 100644 gnu/packages/patches/emacs-native-comp-fix- > > filenames.patch > >=20 > >=20 > > base-commit: aae61f54ff6acf5cc0e0355dc85babf29f625660 >=20 > For usual emacs it seems to work, (require 'magit) with clean eln > cache > doesn't trigger any builds. For emacs-pgtk it fails to build emacs: >=20 > guix time-machine -- > url=3D'https://git.guix-patches.cbaines.net/git/guix-patches'=C2=A0-- > branch=3Dissue-67260 --disable-authentication -- shell emacs-pgtk > emacs-magit --pure -E '.*GTK.*|.*XDG.*|.*DISPLAY.*' -- emacs -Q >=20 > --8<---------------cut here---------------start------------->8--- > =C2=A0=C2=A0 passed=C2=A0 94/97=C2=A0 expect-window-right-native (0.00241= 2 sec) > Test expect-x-dnd-init-frame-native backtrace: > =C2=A0 signal(void-function (x-dnd-init-frame)) > =C2=A0 apply(signal (void-function (x-dnd-init-frame))) > =C2=A0 (setq value-477 (apply fn-475 args-476)) > =C2=A0 (unwind-protect (setq value-477 (apply fn-475 args-476)) (setq > form- > =C2=A0 (if (unwind-protect (setq value-477 (apply fn-475 args-476)) (setq > f > =C2=A0 (let (form-description-479) (if (unwind-protect (setq value-477 > (app > =C2=A0 (let ((value-477 'ert-form-evaluation-aborted-478)) (let (form- > descr > =C2=A0 (let* ((fn-475 #'eq) (args-476 (condition-case err (let ((signal- > hoo > =C2=A0 (lambda nil (let* ((fn-475 #'eq) (args-476 (condition-case err (le= t > =C2=A0 ert--run-test-internal(#s(ert--test-execution-info :test #s(ert- > test > =C2=A0 ert-run-test(#s(ert-test :name expect-x-dnd-init-frame-native > :docum > =C2=A0 ert-run-or-rerun-test(#s(ert--stats :selector t :tests ... :test- > map > =C2=A0 ert-run-tests(t #f(compiled-function (event-type &rest event-args) > # > =C2=A0 ert-run-tests-batch(nil) > =C2=A0 ert-run-tests-batch-and-exit() > =C2=A0 command-line-1(("--load" > "/gnu/store/ql9y5r4ydz4dl8jjf2b2bz9fqhxmbm3 > =C2=A0 command-line() > =C2=A0 normal-top-level() > Test expect-x-dnd-init-frame-native condition: > =C2=A0=C2=A0=C2=A0 (void-function x-dnd-init-frame) > =C2=A0=C2=A0 FAILED=C2=A0 95/97=C2=A0 expect-x-dnd-init-frame-native (0.0= 00082 sec) at > ../../../gnu/store/ql9y5r4ydz4dl8jjf2b2bz9fqhxmbm3x-comp- > integrity.el:1 > Test expect-x-handle-no-bitmap-icon-native backtrace: > =C2=A0 signal(void-function (x-handle-no-bitmap-icon)) > =C2=A0 apply(signal (void-function (x-handle-no-bitmap-icon))) > =C2=A0 (setq value-482 (apply fn-480 args-481)) > =C2=A0 (unwind-protect (setq value-482 (apply fn-480 args-481)) (setq > form- > =C2=A0 (if (unwind-protect (setq value-482 (apply fn-480 args-481)) (setq > f > =C2=A0 (let (form-description-484) (if (unwind-protect (setq value-482 > (app > =C2=A0 (let ((value-482 'ert-form-evaluation-aborted-483)) (let (form- > descr > =C2=A0 (let* ((fn-480 #'eq) (args-481 (condition-case err (let ((signal- > hoo > =C2=A0 (lambda nil (let* ((fn-480 #'eq) (args-481 (condition-case err (le= t > =C2=A0 ert--run-test-internal(#s(ert--test-execution-info :test #s(ert- > test > =C2=A0 ert-run-test(#s(ert-test :name expect-x-handle-no-bitmap-icon- > native > =C2=A0 ert-run-or-rerun-test(#s(ert--stats :selector t :tests ... :test- > map > =C2=A0 ert-run-tests(t #f(compiled-function (event-type &rest event-args) > # > =C2=A0 ert-run-tests-batch(nil) > =C2=A0 ert-run-tests-batch-and-exit() > =C2=A0 command-line-1(("--load" > "/gnu/store/ql9y5r4ydz4dl8jjf2b2bz9fqhxmbm3 > =C2=A0 command-line() > =C2=A0 normal-top-level() > Test expect-x-handle-no-bitmap-icon-native condition: > =C2=A0=C2=A0=C2=A0 (void-function x-handle-no-bitmap-icon) > =C2=A0=C2=A0 FAILED=C2=A0 96/97=C2=A0 expect-x-handle-no-bitmap-icon-nati= ve (0.000111 > sec) at ../../../gnu/store/ql9y5r4ydz4dl8jjf2b2bz9fqhxmbm3x-comp- > integrity.el:1 > =C2=A0=C2=A0 passed=C2=A0 97/97=C2=A0 expect-x-setup-function-keys-native= (0.004165 sec) >=20 > Ran 97 tests, 95 results as expected, 2 unexpected (2024-03-02 > 05:46:28+0000, 0.361428 sec) >=20 > 2 unexpected results: > =C2=A0=C2=A0 FAILED=C2=A0 expect-x-dnd-init-frame-native > =C2=A0=C2=A0 FAILED=C2=A0 expect-x-handle-no-bitmap-icon-native >=20 > error: in phase 'validate-comp-integrity': uncaught exception: > %exception #<&invoke-error program: > "/gnu/store/m01icx06dw1vs1krcj4jbmw71nv430dp-emacs-pgtk- > 29.2/bin/emacs" arguments: ("--batch" "--load" > "/gnu/store/ql9y5r4ydz4dl8jjf2b2bz9fqhxmbm3x-comp-integrity.el" "-f" > "ert-run-tests-batch-and-exit") exit-status: 1 term-signal: #f stop- > signal: #f>=20 > phase `validate-comp-integrity' failed after 0.5 seconds > command "/gnu/store/m01icx06dw1vs1krcj4jbmw71nv430dp-emacs-pgtk- > 29.2/bin/emacs" "--batch" "--load" > "/gnu/store/ql9y5r4ydz4dl8jjf2b2bz9fqhxmbm3x-comp-integrity.el" "-f" > "ert-run-tests-batch-and-exit" failed with status 1 > --8<---------------cut here---------------end--------------->8--- >=20 > Thank you very much for working on it! Try the attached patch and let me know if there's other failing Emacsen. Cheers --=-Ldn0F9+yx8pWgleDiQ7g Content-Disposition: attachment; filename="0001-aux-files-comp-integrity-Adjust-for-emacs-pgtk.patch" Content-Transfer-Encoding: base64 Content-Type: text/x-patch; name="0001-aux-files-comp-integrity-Adjust-for-emacs-pgtk.patch"; charset="UTF-8" RnJvbSAxOWZjMjUyYWI3ZTg2YWQxNDQzYThkMTZmNjg0NjdjNjFiZjIzMTc5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpNZXNzYWdlLUlEOiA8MTlmYzI1MmFiN2U4NmFkMTQ0M2E4ZDE2ZjY4NDY3 YzYxYmYyMzE3OS4xNzA5NTgyMzMwLmdpdC5saWxpYW5hLnByaWtsZXJAZ21haWwuY29tPgpGcm9t OiBMaWxpYW5hIE1hcmllIFByaWtsZXIgPGxpbGlhbmEucHJpa2xlckBnbWFpbC5jb20+CkRhdGU6 IE1vbiwgNCBNYXIgMjAyNCAyMDo1NDo0OSArMDEwMApTdWJqZWN0OiBbUEFUQ0hdIGF1eC1maWxl czogY29tcC1pbnRlZ3JpdHk6IEFkanVzdCBmb3IgZW1hY3MtcGd0ay4KCiogZ251L3BhY2thZ2Vz L2F1eC1maWxlcy9lbWFjcy9jb21wLWludGVncml0eS5lbCAoeC1kbmQtaW5pdC1mcmFtZSk6IFJl cXVpcmUKeC1kbmQuCih4LWhhbmRsZS1uby1iaXRtYXAtaWNvbik6IE9ubHkgdGVzdCB0aGlzIGlm IGl0J3MgYm91bmQuCi0tLQogZ251L3BhY2thZ2VzL2F1eC1maWxlcy9lbWFjcy9jb21wLWludGVn cml0eS5lbCB8IDUgKysrLS0KIDEgZmlsZSBjaGFuZ2VkLCAzIGluc2VydGlvbnMoKyksIDIgZGVs ZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvZ251L3BhY2thZ2VzL2F1eC1maWxlcy9lbWFjcy9jb21w LWludGVncml0eS5lbCBiL2dudS9wYWNrYWdlcy9hdXgtZmlsZXMvZW1hY3MvY29tcC1pbnRlZ3Jp dHkuZWwKaW5kZXggOTY5MmQ5YmY5Ny4uMTkxZTJkZGI5OCAxMDA2NDQKLS0tIGEvZ251L3BhY2th Z2VzL2F1eC1maWxlcy9lbWFjcy9jb21wLWludGVncml0eS5lbAorKysgYi9nbnUvcGFja2FnZXMv YXV4LWZpbGVzL2VtYWNzL2NvbXAtaW50ZWdyaXR5LmVsCkBAIC0xMjUsNSArMTI1LDYgQEAKIChl eHBlY3QtbmF0aXZlIGVtYWNzLXZlcnNpb24pCiAoZXhwZWN0LW5hdGl2ZSBkZWZpbmUtd2lkZ2V0 KQogKGV4cGVjdC1uYXRpdmUgd2luZG93LXJpZ2h0KQotKGV4cGVjdC1uYXRpdmUgeC1kbmQtaW5p dC1mcmFtZSkKLShleHBlY3QtbmF0aXZlIHgtaGFuZGxlLW5vLWJpdG1hcC1pY29uKQorKGV4cGVj dC1uYXRpdmUgeC1kbmQtaW5pdC1mcmFtZSB4LWRuZCkKKyhhbmQgKGJvdW5kcCAneC1oYW5kbGUt bm8tYml0bWFwLWljb24pCisgICAgIChleHBlY3QtbmF0aXZlIHgtaGFuZGxlLW5vLWJpdG1hcC1p Y29uKSkKCmJhc2UtY29tbWl0OiAzZDRmYzkxMGY3MzIyMGY0N2U1ZjI0NTk4NTMzMzNhN2M4M2M1 ZDFkCnByZXJlcXVpc2l0ZS1wYXRjaC1pZDogOTZhZTI0YTM0MTlmY2NlYTE0MmQyNzI2YjExZmYy MGU3OThiZmJkMApwcmVyZXF1aXNpdGUtcGF0Y2gtaWQ6IGU5MDg4NTMyMjRiZmZmZmEyODUwODhk YzZlMzFhYmFmMTJjMTJlMDIKLS0gCjIuNDEuMAoK --=-Ldn0F9+yx8pWgleDiQ7g--