From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:bcc0::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 8FdMFkemcWBudAAAgWs5BA (envelope-from ) for ; Sat, 10 Apr 2021 15:21:11 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id 0E4mEEemcWAHTQAAB5/wlQ (envelope-from ) for ; Sat, 10 Apr 2021 13:21:11 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id EA6CE17565 for ; Sat, 10 Apr 2021 15:21:10 +0200 (CEST) Received: from localhost ([::1]:37574 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lVDXy-0000ri-0Q for larch@yhetil.org; Sat, 10 Apr 2021 09:21:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55658) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lVDXq-0000qS-DD for guix-patches@gnu.org; Sat, 10 Apr 2021 09:21:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:40056) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lVDXq-0007Lt-6K for guix-patches@gnu.org; Sat, 10 Apr 2021 09:21:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lVDXq-0006BY-11 for guix-patches@gnu.org; Sat, 10 Apr 2021 09:21:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#47643] WIP-GNOME Resent-From: Leo Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 10 Apr 2021 13:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47643 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: =?UTF-8?Q?=E5=AE=8B=E6=96=87=E6=AD=A6?= , rg@raghavgururajan.name Cc: leo@famulari.name, 47643@debbugs.gnu.org Received: via spool by 47643-submit@debbugs.gnu.org id=B47643.161806080623696 (code B ref 47643); Sat, 10 Apr 2021 13:21:01 +0000 Received: (at 47643) by debbugs.gnu.org; 10 Apr 2021 13:20:06 +0000 Received: from localhost ([127.0.0.1]:51602 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lVDWw-0006A8-4T for submit@debbugs.gnu.org; Sat, 10 Apr 2021 09:20:06 -0400 Received: from mailrelay.tugraz.at ([129.27.2.202]:12583) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lVDWt-00069x-Q3 for 47643@debbugs.gnu.org; Sat, 10 Apr 2021 09:20:05 -0400 Received: from nijino.local (194-96-13-79.adsl.highway.telekom.at [194.96.13.79]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4FHbFq0z7bz1LBRw; Sat, 10 Apr 2021 15:19:58 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 mailrelay.tugraz.at 4FHbFq0z7bz1LBRw DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1618060800; bh=Zfv1Wp63GsXECkGbFlGtswTvlhmFDvgMGT4CCM7rSz4=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=dzO5AgRXyh+6eG3RlOtaH8UEEEQB3kqcWkInTqZs/874i3lwuQRR56kh9CuCg4lqY Ijfn+81yvOEXkPY8jSiF1jwa1QiQxcDjo4bQAewp0VXtCpH64v19xJTv761j4exo5q ZhEzTZgTZSc6eccfh9ob1WKAkQPfC2MAvwh8qOy8= Message-ID: <6da3be185feabe72da9290926b10a832e8682240.camel@student.tugraz.at> From: Leo Prikler Date: Sat, 10 Apr 2021 15:19:58 +0200 In-Reply-To: References: <20210409183900.24175-1-leo.prikler@student.tugraz.at> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.117 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1618060871; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=Zfv1Wp63GsXECkGbFlGtswTvlhmFDvgMGT4CCM7rSz4=; b=OqLAlaNoBqWoZWGko3D4+jCyFU1tUo2s+Nvq/TiT0D9eRFQWMhbP7bCK6ehi/vkSWLhnVH zcNx7J29y18ePwM2uXdSkUGowedK2YTbmibE6E1q3Q7J1/AOwm6B3CzNTiEGUJo1+Iyu65 OHkxmcPrH2HFKQPGu/oyMca7bqMUkmKLS4DB/i5pDKn9M1X22DNHwzZSRXuqERI0jwwRzT BBwbTq8Pr67chZJyyJV8mnBMPbAeIqzh/BDWnNH04HVf6wqE6UGjylLo1TEzxgcxRtV6cR mCPmFLSBe37SCEjDtBT8e64ndfuvyoIwHoiR4zoWD35nBOVfRALByf97YaWbow== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1618060871; a=rsa-sha256; cv=none; b=Lw+HD4aUwYTuDnPTt+yYHMnalcYBurc0RdT67QAl7Q5trxNrqJUH6Kz2w0n1flVVjKGqgK H1Lq8ZwX8MKYxCuzX0anfKLy4orslr9CnIld1Ni4DL+ARWw4PThggDsOnzGfwg7ZDKQTL3 DifOzRvolSyGOG9m97NXTyK1sqtKkukCTvjGQmVOYIYQlxZaiJGFR9X51Kq8Ny944NW1U2 yykBE9NRFW+vk8cXfyEFCBhHTVB8LdyrG9CutFzNwuVFHLtqBTSfD5R4SATo7r/T5EAV3Q R6s1BkwIeEDcApAKJ6feaUuGQvZTPwFEqS3nzb5VBu/vTfZ0j8/rGRqT0CX8yA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tugraz.at header.s=mailrelay header.b=dzO5AgRX; dmarc=fail reason="SPF not aligned (relaxed)" header.from=student.tugraz.at (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.34 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tugraz.at header.s=mailrelay header.b=dzO5AgRX; dmarc=fail reason="SPF not aligned (relaxed)" header.from=student.tugraz.at (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: EA6CE17565 X-Spam-Score: -1.34 X-Migadu-Scanner: scn0.migadu.com X-TUID: 5Vi2pxsNscMb Hi, Am Samstag, den 10.04.2021, 19:24 +0800 schrieb 宋文武: > Leo Prikler writes: > > > Hi, > > > > I've cleaned up your GStreamer patches a little and rebased them on > > staging. > > The patch set I'm about to send should both apply cleanly and > > build, but I > > haven't yet tested, whether it also runs okay. > > Thank you! > I have replied my reviews to the patches and here will do a summary. > > > Raghav Gururajan (10): > > gnu: gstreamer: Update to 1.18.4. > gtk+ is only used for an example, so I think we can remove it from > inputs. I agree. > > gnu: gst-plugins-base: Update to 1.18.4. > > gnu: gst-plugins-base: Add missing inputs to enable more > > features. > First patch should only make the update, and I think the second patch > have some uncessary inputs. Indeed, it seems this would build fine if we just did a version bump. At least it should if we go by version numbers alone. > > gnu: gst-plugins-good: Update to 1.18.4. > > gnu: gst-plugins-ugly: Update to 1.18.4. > > gnu: gst-libav: Update to 1.18.4. > Trivial updates are good.. > > > gnu: gst-plugins-bad: Update to 1.18.4. > > gnu: gst-plugins-bad: Add missing inputs to enable more features. > > gnu: gst-plugins-bad: Disable few more failing tests. > I think there should be 2 patches, one for update, and one for enable > more features. Disable failing tests should be include into the > first > one which broken tests (or 3 patches if tests are already broken). As far as I know, we already disable some broken tests, but those that we don't disable should be fine. So we should aim for 2 patches here. > > gnu: gst-editing-services: Update to 1.18.4. > Also one for update, one for enable more features if possible. > > And I don't think wrap thoes packages with 'glib-or-gtk? t' with > inputs > as glib-networking, gsettings-desktop-schema are very useful, maybe > I'm > wrong? I think you're right, but it might be my bias as someone already running GNOME. We might want to test, whether gstreamer+gtk works in a pure environment to make sure, that wrapping it is not required in some fringe setting. That said, I find it perfectly acceptable for gstreamer to take these directly from the environment, since it's the same for the plugins themselves. > > gnu/packages/gstreamer.scm | 262 ++++++++++++++++++++++++++++----- > > ---- > > 1 file changed, 199 insertions(+), 63 deletions(-) > > > > -- > > 2.31.1 > > In the end, 2 trivial update patches for gstreamer-docs and gst- > python: Thanks. I'm a bit busy today, so I won't find the time to apply all the suggested changes. Is anyone else interested in forming a v2? Regards, Leo