From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id wDBEKmXV6mWwowAAe85BDQ:P1 (envelope-from ) for ; Fri, 08 Mar 2024 10:07:49 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id wDBEKmXV6mWwowAAe85BDQ (envelope-from ) for ; Fri, 08 Mar 2024 10:07:49 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=troyfigiel.com header.s=MBO0001 header.b=LjNZDtBL; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=troyfigiel.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1709888869; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature:autocrypt:autocrypt; bh=X48fxCyVNE1l6N3011ACyzMMtNp6NIaR8AeO9s4hogM=; b=ekSCC7jEwOD0wT13qf0Kw5xfKrbeGfcT1Vf11tRIw3Fko4QfiyIC7pJcRgoC9uj4sTXI04 mKm/n/C24bfg7OpSyhblrdVMKehkdAcH4eoIe1fbzqlo8/sPa55o0DFxW+6yFMGgkwjRQa /DXncEJBknzkCxr7L70/7w8adWwmDDTw5KnAVgZq/eP1yqRV8WF7XY1qmCPRd0zp20gDfD CfE9BWzB17urqTSgintB+VhBRG4jFjs0BHBeOeuEBsCFiETmP1dnF67b1IdmqVJOoci8rq RMIbz7D0Zj55F59Ro6cvxvQYVxGYYbbZDf3LmCOSeL7oJPiIoj0hxfS6y+yBug== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=troyfigiel.com header.s=MBO0001 header.b=LjNZDtBL; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=troyfigiel.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1709888869; a=rsa-sha256; cv=none; b=LYoH1asaslrejWbGwUumIAvsznp1IShcTYgZNPh5U8OBb98W7PNMSHMwoa9gHM03ttW/2z pyFiklKRmvnvuZOnmsF9BhT05d59GRcLh6OInuavbYOk8heHJuUEFBJecjk+xHbSC1HsWn IuUVAD5q8cHhPwDMB9DBkY9N6PRYjgXt0MvShqzJWU+gT9twNXvdBNauOgr9nUl/DVNmEO cPLrNvCJzCjzXujo6ngD3hOjfC8uFGfDPAjEScKfpGCZT0rEVir5ZWCrWJt9hDn0aywacB +LMhzmLcPDaDcOMDqgVLatzPpVvflX8t0U37LTXXA/YwGnkYaNnYcQfA/6mL4w== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5A8D91F2CF for ; Fri, 8 Mar 2024 10:07:49 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1riWCV-0005jP-QI; Fri, 08 Mar 2024 04:07:35 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1riWCR-0005io-9C for guix-patches@gnu.org; Fri, 08 Mar 2024 04:07:32 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1riWCQ-0002eR-5a for guix-patches@gnu.org; Fri, 08 Mar 2024 04:07:30 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1riWCv-00076S-Ns for guix-patches@gnu.org; Fri, 08 Mar 2024 04:08:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#69376] [PATCH go-team] build-system/go: Allow providing additional test flags. Resent-From: Troy Figiel Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 08 Mar 2024 09:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69376 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 69376@debbugs.gnu.org Cc: Sharlatan Hellseher Received: via spool by 69376-submit@debbugs.gnu.org id=B69376.170988886327266 (code B ref 69376); Fri, 08 Mar 2024 09:08:01 +0000 Received: (at 69376) by debbugs.gnu.org; 8 Mar 2024 09:07:43 +0000 Received: from localhost ([127.0.0.1]:56576 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1riWCd-00075i-8x for submit@debbugs.gnu.org; Fri, 08 Mar 2024 04:07:43 -0500 Received: from mout-p-201.mailbox.org ([80.241.56.171]:37968) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1riWCX-00075K-MB for 69376@debbugs.gnu.org; Fri, 08 Mar 2024 04:07:41 -0500 Received: from smtp1.mailbox.org (smtp1.mailbox.org [10.196.197.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-201.mailbox.org (Postfix) with ESMTPS id 4TrgKF58pVz9t2x; Fri, 8 Mar 2024 10:06:57 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=troyfigiel.com; s=MBO0001; t=1709888817; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=X48fxCyVNE1l6N3011ACyzMMtNp6NIaR8AeO9s4hogM=; b=LjNZDtBLy22R0i20dFjVY+NSNP3SlqmDnpe8ebwow9oo5SHfbyQRgjoHiBdY4Ay/Iqy6Ie 3/FCSPSZEdOKD/mIuwQunMOL2FsJNMU5TfPPr07evYrK7Bir+QF9NYhsqIfMS/UyTtzgUs M9uG7WBLpGEjGm24ecT5PARPLNnOzyxKDS/Osww0bOJCCSRr3XM1OH0AnKq729Z166iVTY NaIsnhSVpVgjeRztjEjS0KIkGhl5yCwW54bMkxmhpq8yob87KO/CQbcVOiZjtpu25xnAPx UDX+VNNxLAekRpH/NxBjQFW168iEo3ku3OdvEkPtoLVQdpOeDysL/7ES+Q6VLA== Message-ID: <6cdf192c-ba7c-4d4b-bcad-6b4fa710ccce@troyfigiel.com> Date: Fri, 8 Mar 2024 10:06:56 +0100 MIME-Version: 1.0 Content-Language: en-US, de-DE, nl References: <87a5noaot3.fsf@troyfigiel.com> <87cys54pid.fsf@gmail.com> From: Troy Figiel Autocrypt: addr=troy@troyfigiel.com; keydata= xsFNBGKp71YBEADDmh9HMTg0Z8/xxf4yT6UX2wO8u0Q2nbOAhzROSabUVyBp8Gz6jLcoFN8x rg8XxxBWTCENBWqKkYG6Z/GgPmeKuacAeZIW7dGYaGu4bZHgLsTqk04J/dM63aVveJJY4M4r KNx0Mew+SYTGrh3NnoSF0+ZIskGGh4NJpXOGUSUihjdddn8ouFDDy01GJ9N2ZWprfWo3ynMA xEHhD6CWniQMkmd+TVKjQt+BC8d+nHlOt6vFoDGH9PehXmmBLyOJAVMAlPMyrN8ZjmbRp91s 4Sz2rqjD2GXFGvKClhyxcr2qEUJmCg/Vp8PiZWOwxA/6BCWuNmrl1d1FhXjMMIzz2y92MOlD 5kQm7/261cuXTJvKZOLmHelY0m7gReWnc9peGPmGeukkdblmjwJTnetzvF/AUXNpS29Nmyie 4PgsAbkmL0PwKCbf+6WRWywRidR1narANINGJHL8MDIgdUwuJsYhD5s10bIsg2dOOxFioOnm kgpWiVLmZSq9bkX+SRyWNL+hDhEbGLnZ5WUOszPXgo9Lo2dCGBr4YkCaxVCCCfgAn8TpgcLQ VW37N75MjEX3kVBGBiiifbQUedKHqMddlUEYLSjpBCNxqF1X5fTuurFrfq8EYcYcQGW5Telh fX1I6md7xt0FDBRAVx8jAvy7Rkt6CeKP7oPNMVfoQ62oMT85JQARAQABzSFUcm95IEZpZ2ll bCA8dHJveUB0cm95ZmlnaWVsLmNvbT7CwY8EEwEKADkCGwMECwkIBwQVCgkIBRYCAwEAAh4F AheAFiEE5HwNzSdo36E4/NzWxnyRgbOJP7AFAmVCwP8CGQEACgkQxnyRgbOJP7DK/A/+L6IY xHhr4ZCz5Mk8s0OHAQTP3ZlAtmjMB+Lg0nwg8hVRzF1O/mCQKaFeKwKgh0I0zZIYucnylG6K KtVoa1ZNrpOCO2Qau7C/j6u7lmZGoEyEf9ePvhpVPcqFXSeehNl/nmaAFuLXTTTvkUubuU2m OEQe1oua/9HQPbd2mlKNjUnj9YmYs9qqF9bcJmT0U2WUg4Jz3DmHQiK175QqJv7fXtIdHzAk BRlJdrslLPOrIDb7WAnXpUQs1bcirKuSFOsyeGn0plh3t0uSm8d3BValRArPMw/h9FldGRXr KycSCIuU/vL94mncXSwIy8ifY4XkcBVvuZ8CbAh3G3iuZ6LLoMsjGmCXkm6Ru9OieC8xmAae 69RYw/zXHoIkW+/nLygEv7+7tMrYTFcUR0RmMvHjiZafnGwHkBCFMojUapcG/EAsSYQzssGP qYLuqIaq2weCYpfNUMDye3rivOKFcO6Aa63lCb1TLy/OVoK0al04WdO+teDJVj88WNyMZu1c SdBYd3lJ9VLSmsBJ0FFksuDyXQqmrN+Uckka+JdKHiADGGaztMHmbJkZ1DZ2jfEh0kJTcCr8 PAXIvTMcgi/BLP3R6u+iHnycypID8pwLIDg3Gg3cLcfeBmCBEAft/Gk5RF0POIL8QAx7IVwu AD4kpM6fkXc6Dq9sl6us38ekm6M7fprOwU0EYqnvVgEQANU4cn+tMmYLMMJA3yeE7JIlY5E+ xZ5qrvNA+UwqTuZGcQH3Th81fsF1qYYiT38fq6GAEImJ19VqVs9f/YGSdkUk1ZA46AwzPuij pFGUm3yL71kCzPblF1zUCzOllc1N7pi3YD+XQr7ggqX/s/MS1uxR9Sgs5coYUT0ygXVOGkSk OQjdQ99B2+BUTos28C2sDfJfCd5ekLCp02EUle527sX8QjyTiTUlu5pvFnCtzO6MWf3loiJb Vi9vA0hQFOnu4jM0TjzIc4vWJpX1oExfFwEsoSVLDQh3CFIoe8wHsRgpIvtWiiRIuaaJawhx ac6mj4yaB2UR/MW8KFpUmqzTgVn8FLt0S0yo1PpleTFT8IsGY8luoyWIaUyNCrjXxrps8yFj HoE54Abb0S6Z15Ko2csG2DR1u4ZtELVsHcF3gZT5q1Nt9BnV8TYi0+vNjVjQ7OODQMOBSIB8 bBEQogtbTxBYvIs57ClYAd0fHssz7fJHaKDbcsZXGWKdiSEQrrfc78tOgmYml997og7SyLg+ YI9X8G4RJiIF9EThRtAKK92i9xktWLLBCl5q5nwRPcObVgy7AiwQBPX1WVR3+Uy6BaeyylPY YIAyM6dHwl4/e5HczR5Nt6pzmnOza8F2JT4blqJd+QVeL+xDtBvzKWLBVZkPJMbwqYS/1MOu 4UdmuNIpABEBAAHCwXYEGAEKACAWIQTkfA3NJ2jfoTj83NbGfJGBs4k/sAUCYqnvVgIbDAAK CRDGfJGBs4k/sAQUD/4xIZxwGDsBc3mf4qnahCEAN3NjyhI/9q2oFGzyN0t9ifh7u7HD5R0F 5WdI2JnOnW3Bjl3YnsMfLg9wHnsT3R1xresf59wXuKQ7UIpqPfMXLZnHtaUP5bmpETvkvybN f0zkekbU27chbmiAOyDB3ApsFQ7lqwvOO0K3+sx94ROsJwb+MDpjGAOewVPk7V0br0twFo2R 5/vtp8cNCg/lKlqWDmJ0fWipxazSzVAMDxn+ci0DB5o5UyHhxc8WgXXLl7t22m7b6kVZ0EKN oEPa7/TvIj1wVDFUFrEMEuJFBMDqZDLdBMZzEsq7O0sHaGifiy0zHRE7Eyfo+9sV0ccSWdeE f5GjoKLtR7MlJ+I9IfHuCl++Gxa+MM8yXfn/tk7vcsGJhewrqqTlvnpMuITCmdTJymgnKS/B jSDDKjgRsZLLzhkE+dVTBZRkHFOGf9rV8+JQRYwqZVIjIEln6EZdfOQIKPll4EY19f9stj7h ptM9jXDTBm4MBxdCdWIRsU19w4TqvitioADjMSZ1MYqQlS6pWQI9tDMJ/mLqKcWrHhar6rwv v/gTpsbePtVR2GkWMjEHE1VS1LKmr+UcWFu3MJIHMd4DFnypp1n1cY+u0emp93JUMDMqa79F G+6Sbeaw5G+/fx8S4hpw63SiA1x8c5PMjKGwx5G4ZZfNwT+mAi6dHA== In-Reply-To: <87cys54pid.fsf@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx12.migadu.com X-Migadu-Spam-Score: 2.62 X-Spam-Score: 2.62 X-Migadu-Queue-Id: 5A8D91F2CF X-TUID: LpNAyYYIZPkn Hi Oleg, On 2024-03-07 23:59, Sharlatan Hellseher wrote: > The patch looks reasonable. Does it allow us to run all available tests > as we discussed in > ? No, not yet. This only allows providing extra test-flags such as "-vet=off" or "-skip ..." for Go 1.20+. An example where this is useful, is go-github-com-wtolson-go-taglib, but I had a couple in my backlog as well. > One nitpick about this section: > --8<---------------cut here---------------start------------->8--- > +;; go test builds a test binary (or multiple binaries), vets the code and then > +;; runs the test binary. Build, test and test binary flags can be provided as > +;; test-flags. See "go help test" and "go help testflag" for more details. > --8<---------------cut here---------------end--------------->8--- > It is a good material for documentation section, how about to move it > from this comment and compile a proper documentation note describing > #:test-flags for go-build-system? > > Something like this: > --8<---------------cut here---------------start------------->8--- > #:test-flags is added. The default is '(). These flags are passed as > arguments to the test command. Note that flags for verbose output is > always enabled on supported backends. > --8<---------------cut here---------------end--------------->8--- > Sourced from > > WDYT? I think that's a great idea. Where would that go exactly? I have only found "guix.texi" and can add a short section there. Is this the correct location? Best wishes, Troy