From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:35124) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jOQcJ-0003WP-FX for guix-patches@gnu.org; Tue, 14 Apr 2020 14:49:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jOQcI-00008e-Al for guix-patches@gnu.org; Tue, 14 Apr 2020 14:49:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:51499) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jOQcI-00008G-5m for guix-patches@gnu.org; Tue, 14 Apr 2020 14:49:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jOQcI-0002PB-2P for guix-patches@gnu.org; Tue, 14 Apr 2020 14:49:02 -0400 Subject: [bug#40440] [PATCH 2/3] gnu: Add mruby-zest. Resent-Message-ID: Message-ID: <6b672f1744ad3a5ce835e7a1068864e2967f9d22.camel@zrythm.org> From: Alexandros Theodotou Date: Tue, 14 Apr 2020 19:48:43 +0100 In-Reply-To: <87blnt7vv4.fsf@cbaines.net> References: <87blnt7vv4.fsf@cbaines.net> Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-NXRR3pxVER2Zqlqza2Tr" MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Christopher Baines Cc: 40440@debbugs.gnu.org --=-NXRR3pxVER2Zqlqza2Tr Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Christopher, Thanks for the review. It would indeed be best to package each dependency first, but I don't really have time to package all those dependencies, and I also don't have much knowledge about ruby. If someone else is willing to do it, please go ahead. Thanks, Alex On Tue, 2020-04-14 at 19:41 +0100, Christopher Baines wrote: > Alexandros Theodotou writes: >=20 > > This patch adds mruby-zest, a dependency of zynfusion. I had some > > help > > from the developer for making it build without connecting to the > > internet. >=20 > Hey Alex, >=20 > Thanks for taking the time to package mruby-zest. >=20 > > +(define-public mruby-zest > > + (package > > + (name "mruby-zest") > > + (version "3.0.5-ba39aabd") > > + (source > > + (origin > > + (method git-fetch) > > + (uri (git-reference > > + ;; this is a meta repo that packs the mruby > > dependencies > > + ;; as submodules > > + (url " > > https://github.com/mruby-zest/mruby-zest-build.git") > > + ;; ghaction branch - suggested by the developer to > > avoid > > + ;; automatic downloading of some unneeded and > > + ;; hard-to-package dependencies used for debugging > > + (commit "ba39aabd8d4ddc5f14137083b6f9a96c536f5f12" > > ) > > + (recursive? #t))) >=20 > So I spotted the use of a "deps" directory, which is a bad sign, as > dependencies should be other packages, not things as part of this > package. >=20 > I then spotted that the source for this package isn't the upstream > Git > repository, but a Git repository that pulls together the mruby-zest > source code, with code from ~16 other Git repositories. >=20 > Would it be possible to create Guix packages for these dependencies? >=20 > I know that would involve quite a bit of work, but unfortunately that > kind of work is necessary to ensure Guix as a collection of packages > can > be maintained in the long term. >=20 > > + (file-name (git-file-name name version)) > > + (sha256 > > + (base32 > > + "1vqzdds30sr982dp7fclg4r19l44rv8pbz6h4a8vcginj494gvjn")) > > )) --=-NXRR3pxVER2Zqlqza2Tr Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEESBMjhK0999huJUuDAi6uQjE9cPMFAl6WBYsACgkQAi6uQjE9 cPP4swf7BDrjKyvRWxTlIOALcMKo4yqJtHOKhqwnDa8A9Zdc9IbWmASRuYNpP7Lz aYTiygm1S958pARV4i2xp7R3vNZ3t/v1OuK8xntinSYX25/Q9u5vrQveNVJ0b6wY NGexnqzZWBrMwN+mGve7zzv0m+0oMtqiidodp68hcA84fNR9YI9BBxtRkn+FpEke 2z6/6989YlzJFttI+jj28RMwQp2piCGgAAxvUbo7qdNnzJirRqP8mw/Ww78G+P92 z26UIVL9ZDn29XrKqBEhtcZFXNK0V/dbSc4QfQD21ryMK9diqVho2LGUdYjE4W49 UPHR833AbYdX0A8/iJUElSDOEzmDCg== =K4VZ -----END PGP SIGNATURE----- --=-NXRR3pxVER2Zqlqza2Tr--