From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id +RKlIDBg+mMRJwAAbAwnHQ (envelope-from ) for ; Sat, 25 Feb 2023 20:23:28 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id AEXwHzBg+mOWMAEAauVa8A (envelope-from ) for ; Sat, 25 Feb 2023 20:23:28 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 54C10BDFD for ; Sat, 25 Feb 2023 20:23:28 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pW08R-0007v7-LB; Sat, 25 Feb 2023 14:23:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pW08N-0007uz-2G for guix-patches@gnu.org; Sat, 25 Feb 2023 14:23:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pW08M-000207-Q7 for guix-patches@gnu.org; Sat, 25 Feb 2023 14:23:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pW08M-0002bq-BP for guix-patches@gnu.org; Sat, 25 Feb 2023 14:23:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#61686] [PATCH] gnu: Add dropwatch. Resent-From: Bruno Victal Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 25 Feb 2023 19:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61686 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Nicolas Goaziou Cc: me@tobias.gr, 61686@debbugs.gnu.org Received: via spool by 61686-submit@debbugs.gnu.org id=B61686.16773529229948 (code B ref 61686); Sat, 25 Feb 2023 19:23:02 +0000 Received: (at 61686) by debbugs.gnu.org; 25 Feb 2023 19:22:02 +0000 Received: from localhost ([127.0.0.1]:41560 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pW07O-0002aD-6Y for submit@debbugs.gnu.org; Sat, 25 Feb 2023 14:22:02 -0500 Received: from smtpm8.myservices.hosting ([185.26.105.209]:50422) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pW07N-0002Zy-8K for 61686@debbugs.gnu.org; Sat, 25 Feb 2023 14:22:01 -0500 Received: from mail1.netim.hosting (unknown [185.26.106.173]) by smtpm8.myservices.hosting (Postfix) with ESMTP id 9E86520D4F; Sat, 25 Feb 2023 20:21:59 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by mail1.netim.hosting (Postfix) with ESMTP id 4954080098; Sat, 25 Feb 2023 20:21:59 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mail1.netim.hosting Received: from mail1.netim.hosting ([127.0.0.1]) by localhost (mail1-2.netim.hosting [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 1t5DPYZcAbVR; Sat, 25 Feb 2023 20:21:59 +0100 (CET) Received: from [192.168.1.239] (unknown [10.192.1.83]) (Authenticated sender: lumen@makinata.eu) by mail1.netim.hosting (Postfix) with ESMTPSA id CCF0880079; Sat, 25 Feb 2023 20:21:58 +0100 (CET) Message-ID: <6ae388b3-fea8-2b3e-d32c-da1119d090a7@makinata.eu> Date: Sat, 25 Feb 2023 19:21:58 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Content-Language: en-US References: <43b683614e136e70894ba395a6759dc714fe2faf.1677006911.git.mirai@makinata.eu> <87cz5znxzx.fsf@nicolasgoaziou.fr> From: Bruno Victal In-Reply-To: <87cz5znxzx.fsf@nicolasgoaziou.fr> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1677353008; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=yEcXS0YHwRKoOcE0OrD1BA1YIUe898xP9oexKudSonw=; b=OdfPKd5XF7L0CkzzsgwOX98P2a9QssssVWxGQApxCuEdXjhFTg28qTo8RZVljEMb3vXHaK 9t+njoCFfrGFizqT12AY35Lg9WSE4jw9yYgzZHLr7fQWlQ0+nu7MyFEY62L8LJvrDiV2Ll 38CLCKco9cKFqgD0l+uzCAO+eDBhfxJ1g3ELE7bk/XRF892hs9PFx+YHnDddckw8oPAEq8 nzd3p7bQ19aUaFHS5L4kMa64UoopneAvYDxq61j7jf0yL3RIfSabw5a+ANsc0hXuRYLbup tKugwSNruuExL72ewd20bz/61WFwYHQKYYZy1Hr3MAzL9aK8/P8Z3/yhSS85AA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1677353008; a=rsa-sha256; cv=none; b=AS/oNJ2ogyZw5MyjfXqlT6ltIVYL2p/INR6ZDTmV7/xSCp/xgI9Ti6w9SKWs4R/pIdlXr9 rQ/Jcb9usk/WYAf0ioV6wbcEqoINfnRHrMKIr3hLKxGPKxwceofdBywXDT5a+I+TFZ4SPc giILKZ7R/JZwskDb6YD9y7tgccZf/qydbVNljxnLwN/Kglbl3V4PmIL9RA03xINB15vcv1 o1C4a8a5hduEmUxnPJJQRHLUrn6Fbh407oZaSC41OjZuNI+YjgBGjqfbkYVWPVTJINRVRi W7s33TbetUCxZlPyTSL9QXIb/MKRG0CMtSC+8mkaVR18vOsQYl3De9j76S9UlA== X-Spam-Score: -3.18 X-Migadu-Queue-Id: 54C10BDFD X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.18 X-TUID: rC1CzfYdYIxO Hi Nicolas, On 2023-02-24 10:44, Nicolas Goaziou wrote: >> Note: the kernel option NET_DROP_MONITOR must be set for this package >> to work. > > Do you think it is worth mentioning in the description? AFAICT, Guix > does not set this option by default. With e701f67246680c81dd111cf7136b936bf7d8718b, this is now set by default. >> +(define-public dropwatch >> + (package >> + (name "dropwatch") >> + (version "1.5.4") >> + (source (origin >> + (method git-fetch) >> + (uri (git-reference >> + (url "https://github.com/nhorman/dropwatch.git") > > You can drop the ".git" suffix here. Is there a reason for dropping the suffix for GitHub? AFAIK it "works" but it's not the same url that they give out for cloning. >> + (commit (string-append "v" version)))) > > You also need to add > > (file-name (git-file-name name version)) > > for proper naming in the store. Is this always required? I assumed the default if unspecified was "good enough" and that snippet was used for repositories with problematic names. >> + (home-page "https://github.com/nhorman/dropwatch") >> + (synopsis "Kernel dropped packet monitor") >> + (description >> + "dropwatch is an interactive utility for monitoring and > > Nicpick: dropwatch —> Dropwatch Noted. > >> +recording packets that are dropped by the kernel. It provides the commands > > You need separate sentences with two spaces, per Texinfo syntax. This is actually not strictly necessary for strings embedded in scm files. The texinfo extractor is smart enough to automatically space the strings for us here. You can verify this behavior with 'guix search dropwatch' and see that it automatically inserts two spaces correctly. Cheers, Bruno