From: Maxime Devos <maximedevos@telenet.be>
To: Alex Griffin <a@ajgrf.com>, 53912@debbugs.gnu.org
Subject: [bug#53912] [PATCH 3/5] system: image: Add wsl-tarball support.
Date: Tue, 15 Feb 2022 17:31:46 +0100 [thread overview]
Message-ID: <6a73b33bc1ca7f8e9bfa5805608207f02e9aa282.camel@telenet.be> (raw)
In-Reply-To: <87wni3ck2v.fsf@ajgrf.com>
[-- Attachment #1: Type: text/plain, Size: 1235 bytes --]
Alex Griffin via Guix-patches via schreef op do 10-02-2022 om 06:27
[+0000]:
> (with-directory-excursion image-root
> + (when #$wsl?
> + ;; WSL requires /bin/sh. Will be overwritten by
> system
> + ;; activation.
> + (symlink #$root-shell "./bin/sh")
> +
> + ;; WSL requires /bin/mount to access the host
> fs.
> + (symlink #+(file-append util-linux "/bin/mount")
> + "./bin/mount"))
I would change this to
(with-directory-excursion image-root
#$@(if wsl?
;; Comment ...
#~((symlink ...)
(symlink ...)
#~())
other things ...)
such that the tarball could be built without building util-linux.
Also, (symlink #+(file-append util-linux ...) "./bin/mount") seems
wrong here when cross-compiling, wouldn't a 'mount' compiled for --
target be required instead of a 'mount' compiled for --system when
cross-compiling? Do you mean #$(file-append ...) instead?
Greetings,
Maxime.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]
next prev parent reply other threads:[~2022-02-15 16:34 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-10 6:05 [bug#53912] [PATCH 0/5] WIP Add WSL support Alex Griffin via Guix-patches via
2022-02-10 6:12 ` [bug#53912] [PATCH 1/5] scripts: Fix typo Alex Griffin via Guix-patches via
2022-02-10 6:22 ` [bug#53912] [PATCH 2/5] system: image: Add tarball support Alex Griffin via Guix-patches via
2022-04-11 10:34 ` [bug#53912] [PATCH 0/5] WIP Add WSL support Ludovic Courtès
2022-02-10 6:27 ` [bug#53912] [PATCH 3/5] system: image: Add wsl-tarball support Alex Griffin via Guix-patches via
2022-02-15 14:10 ` Liliana Marie Prikler
2022-02-15 16:28 ` Maxime Devos
2022-02-15 16:31 ` Maxime Devos [this message]
2022-02-10 6:31 ` [bug#53912] [PATCH 4/5] system: Add wsl module Alex Griffin via Guix-patches via
2022-02-10 6:35 ` [bug#53912] [PATCH 5/5] image: Add wsl image Alex Griffin via Guix-patches via
2022-04-11 10:41 ` [bug#53912] [PATCH 0/5] WIP Add WSL support Ludovic Courtès
2022-04-26 7:15 ` Mathieu Othacehe
2022-06-04 0:31 ` Christine Lemmer-Webber
2022-09-11 12:23 ` Mathieu Othacehe
2022-09-25 11:56 ` bug#53912: " Mathieu Othacehe
2022-08-11 16:27 ` [bug#53912] " Jacob MacDonald
2022-08-11 21:32 ` [bug#53912] [PATCH 0/5] WIP Add " Stefan via Guix-patches via
2022-08-11 22:31 ` Jacob MacDonald
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a73b33bc1ca7f8e9bfa5805608207f02e9aa282.camel@telenet.be \
--to=maximedevos@telenet.be \
--cc=53912@debbugs.gnu.org \
--cc=a@ajgrf.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).