unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Julien Lepiller <julien@lepiller.eu>
To: zimoun <zimon.toutoune@gmail.com>,
	Christopher Baines <mail@cbaines.net>,
	Csepp <raingloom@riseup.net>
Cc: pukkamustard@posteo.net, 58174@debbugs.gnu.org
Subject: [bug#58174] [PATCH 1/3] gnu: Add ocaml-domain-name.
Date: Tue, 22 Nov 2022 15:42:23 +0100	[thread overview]
Message-ID: <6FF3ECFC-B6FD-472E-AD8D-5BCCB82DB3C2@lepiller.eu> (raw)
In-Reply-To: <86k03ndvr8.fsf@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 2264 bytes --]

I don't have a strong opinion. Having mirage stuff in ocaml.scm is only because I didn't pay attention. We could move tgem to mirage.scm.

I agree moving stuff to ocaml-xyz and other subtopics could be good, but it's unrelated to this patcg series, so it shouldn't block it.

Le 22 novembre 2022 13:22:19 GMT+01:00, zimoun <zimon.toutoune@gmail.com> a écrit :
>Hi,
>
>On Tue, 22 Nov 2022 at 10:01, Christopher Baines <mail@cbaines.net> wrote:
>
>> I'm fine with mirage specific stuff going in a mirage module, my issue
>> is that these first packages are not mirage specific, so I'd like to see
>> the separate module be more general (e.g. about networking), or for them
>> to just go in the ocaml module.
>
>Indeed, these 3 packages should be in (gnu packages ocaml) to be
>consistent with the current organization––MirageOS packages are already
>in this module:
>
>--8<---------------cut here---------------start------------->8---
>./ocaml.scm:1169:            (url "https://github.com/mirage/bigarray-compat")
>./ocaml.scm:1587:              (url "https://github.com/mirage/ocaml-base64")
>./ocaml.scm:2448:           (url "https://github.com/mirage/alcotest")
>./ocaml.scm:2595:            (url "https://github.com/mirage/mmap")
>./ocaml.scm:3807:              (url "https://github.com/mirage/ocaml-cstruct")
>./ocaml.scm:3822:            (url "https://github.com/mirage/ocaml-hex")
>./ocaml.scm:3847:    (url "https://github.com/mirage/ezjsonm")
>./ocaml.scm:3902:    (url "https://github.com/mirage/ocaml-uri")
>./ocaml.scm:8149:      (url "https://github.com/mirage/either")
>./ocaml.scm:8428:     (url "https://github.com/mirage/ocaml-cohttp")
>--8<---------------cut here---------------end--------------->8---
>
>
>About an OCaml module restructure: Well, in the module (gnu packages
>ocaml), I count 291 packages, from compilers to standalone program
>(unison) or libraries (ocaml-<something>).
>
>IMHO, to be consistent with other build system, the structure should be:
>
> - (gnu packages ocaml): contains OCaml compilers and toolchain
> - (gnu packages ocaml-xyz): contains libraries and standalone program
> - and maybe other (gnu packages ocaml-<subtopic>)?
>
>OCaml team, WDYT?
>
>Cheers,
>simon

[-- Attachment #2: Type: text/html, Size: 2721 bytes --]

  reply	other threads:[~2022-11-22 14:43 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-29 16:47 [bug#58174] [PATCH 1/3] gnu: Add ocaml-domain-name raingloom
2022-09-29 16:47 ` [bug#58173] [PATCH 2/3] gnu: Add ocaml-macaddr raingloom
2022-09-29 16:47 ` [bug#58172] [PATCH 3/3] gnu: Add ocaml-ipaddr raingloom
2022-11-21 13:51 ` [bug#58174] [PATCH 1/3] gnu: Add ocaml-domain-name Christopher Baines
2022-11-21 17:08   ` zimoun
2022-11-22  8:29     ` Christopher Baines
2022-11-21 17:11   ` Csepp
2022-11-22 10:01     ` Christopher Baines
2022-11-22 12:22       ` zimoun
2022-11-22 14:42         ` Julien Lepiller [this message]
2022-11-22 12:30       ` Csepp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6FF3ECFC-B6FD-472E-AD8D-5BCCB82DB3C2@lepiller.eu \
    --to=julien@lepiller.eu \
    --cc=58174@debbugs.gnu.org \
    --cc=mail@cbaines.net \
    --cc=pukkamustard@posteo.net \
    --cc=raingloom@riseup.net \
    --cc=zimon.toutoune@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).