From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 2HDVC+O41WAXagAAgWs5BA (envelope-from ) for ; Fri, 25 Jun 2021 13:07:15 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id YELyBuO41WC3YQAA1q6Kng (envelope-from ) for ; Fri, 25 Jun 2021 11:07:15 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8A7E81CDF1 for ; Fri, 25 Jun 2021 13:07:14 +0200 (CEST) Received: from localhost ([::1]:52666 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lwjg1-0004A2-Ju for larch@yhetil.org; Fri, 25 Jun 2021 07:07:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46536) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lwjfp-00049A-Vu for guix-patches@gnu.org; Fri, 25 Jun 2021 07:07:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:33403) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lwjfp-0006iy-Oo for guix-patches@gnu.org; Fri, 25 Jun 2021 07:07:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lwjfp-0004iz-IP for guix-patches@gnu.org; Fri, 25 Jun 2021 07:07:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#49203] [PATCH 1/2] gnu: Add ocaml-uri-sexp. Resent-From: Julien Lepiller Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 25 Jun 2021 11:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49203 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Xinglu Chen ,Adu O'Hara Cc: 49203@debbugs.gnu.org Received: via spool by 49203-submit@debbugs.gnu.org id=B49203.162461917718091 (code B ref 49203); Fri, 25 Jun 2021 11:07:01 +0000 Received: (at 49203) by debbugs.gnu.org; 25 Jun 2021 11:06:17 +0000 Received: from localhost ([127.0.0.1]:44949 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lwjf6-0004hi-Rm for submit@debbugs.gnu.org; Fri, 25 Jun 2021 07:06:17 -0400 Received: from lepiller.eu ([89.234.186.109]:45750) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lwjf3-0004hV-PV for 49203@debbugs.gnu.org; Fri, 25 Jun 2021 07:06:15 -0400 Received: from lepiller.eu (localhost [127.0.0.1]) by lepiller.eu (OpenSMTPD) with ESMTP id 338d33a2; Fri, 25 Jun 2021 11:06:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=lepiller.eu; h=date :in-reply-to:references:mime-version:content-type :content-transfer-encoding:subject:to:cc:from:message-id; s= dkim; bh=wbl6Dn1+06TJXuGAatiMLl3R9NZ9QO0v+Yw+uABLhhA=; b=WCRPiGR bIAXsL8Tdhu5nEt/JGsNgSNr6DKNM4Hvsf8Qy1Os6zSiqxaIxX30zKdsIb/YVV5r hcqHT4bX1vLwQ/xHsRSKRtcE5iO/03EOe8YWUyBK+BHqFoeGf8Bb5szomMOCO2A2 ZnVOrFac4HftKZkRTKNjWhOfhMp23j/L5DuvRhlhYc4rP2qJ+gWQTD660w3BfbL4 m3hnvsMk3XqCczmSxrpvFpPun7TC0IUDBFm4Vqt8iDoZzmTWGw23kCxlxso0lYUN ylFL6HWgTK915cboQD0RF8nq0ajVDjkBgh7rRC19JzeCYFhKFkUyH9OsTbfsOsre 6BEWXVv9cmyeMtg== Received: by lepiller.eu (OpenSMTPD) with ESMTPSA id 6e7fac6d (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Fri, 25 Jun 2021 11:06:10 +0000 (UTC) Date: Fri, 25 Jun 2021 07:06:03 -0400 User-Agent: K-9 Mail for Android In-Reply-To: <8735t6jjnl.fsf@yoctocell.xyz> References: <0c74eedb3a07933206ed2127a2b26f433ab77b18.1624528372.git.public@yoctocell.xyz> <86lf6zxwec.fsf@posteo.net> <87a6nf9kef.fsf@yoctocell.xyz> <86k0mjxcwx.fsf@posteo.net> <875yy2joab.fsf@yoctocell.xyz> <86fsx6xmwx.fsf@posteo.net> <8735t6jjnl.fsf@yoctocell.xyz> MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----DIIZG14J2K4KRKXC0OUA0J94L2RV0D" Content-Transfer-Encoding: 7bit From: Julien Lepiller Message-ID: <6960AAD0-85AD-4DB2-ACB8-B5CC7F0042FB@lepiller.eu> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1624619234; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=XVbVu5w+B6OjoJ/MMWSCv0LGogpjGPPt+bgtmjwSNw4=; b=oFVWN+b7Issj1BAHbuj9j8PiAx1t9cFJzFKtP40xYqnoIDS9Au+O2X3e2UcjYJw/Iau0jS UAIDzaRyjED9IfZoK7rxe0bDoQAcCziOs4nVP6RT1wLeW/5EkdHhTj4IOhO/+A75EgsGiK ZQK3Wvi4HYsNQFEm8+oFWJ30/1m+6Rxz6Mxyka2d5AUQR3jhd8irZCyzrZtAT4DTQUBgGM Nr1ICyzeTK6SqO9FnYO15TEfwR+lb5oHKXl0ENOPVPnB0aFrtSVj4uLIMdPaskNXBHI5GL o8t3W2H8Y42r8lMn865usx/cEEOKurRVVsVFY5dO+p7/Rl7FDpODx3XQETrPbw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1624619234; a=rsa-sha256; cv=none; b=NX1O8rKPmxSCn93q/PtIchQCwNZN9zOTGoHfLsKp8oKMN0V3VOYynoo2SpFngWrYBa7TmC GGxhkzrkClfRDJwo/JWi88I33JoTcxeiL+tXjnRSaqFARXaVjas30JfECrulbEZoKKp1tg /n6S8UPGgxEkeEuBTF3FpY3ibGH9W4GY1M9nJEvuUTI8IvQTEa40KoQERX4KsAxK6piRP3 53onl5485HlOSfY9IXxGE4e+XN2Zx1SD4gk8Y5c8hhcQ9UisAxIuMvTjC4J/nxnTOmd0Ug HROlPhk7xuCEs48EKl+7x/BsPYYuc8yeVc6oVAAn9BlwQfbg8Y5a15nz3GiyCw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lepiller.eu header.s=dkim header.b="WCRPiGR "; dmarc=fail reason="SPF not aligned (relaxed)" header.from=lepiller.eu (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.33 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lepiller.eu header.s=dkim header.b="WCRPiGR "; dmarc=fail reason="SPF not aligned (relaxed)" header.from=lepiller.eu (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 8A7E81CDF1 X-Spam-Score: -1.33 X-Migadu-Scanner: scn1.migadu.com X-TUID: SNFS730LYVjO ------DIIZG14J2K4KRKXC0OUA0J94L2RV0D Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi, what matters is that patches focus on one thing, and one one=2E I agree= with Adu here, we should make sure uri anl uri-sexp are the same version= =2E If you really don't want to do that in this series, send it as another = series, and make it blocking for this one=2E I'll try to merge your work th= is week-end=2E Le 25 juin 2021 06:58:06 GMT-04:00, Xinglu Chen a= =C3=A9crit : >On Fri, Jun 25 2021, Adu O'Hara wrote: > >> Xinglu Chen writes: >> >>>> True, what I was suggesting would add another patch to the=20 >>>> series=20 >>>> and mix up intentions of the series=2E >>> >>> Sorry, I don=E2=80=99t get what you are trying to say here=2E >>> >>>> Still, I'd suggest for ocaml-uri-sexp to inherit from >>>> ocaml-uri=2E Otherwise we have them at two different versions=2E >>> >>> I think it makes more sense to do that in a separate series=20 >>> since >>> updating =E2=80=98ocaml-uri=E2=80=99 isn=E2=80=99t really related to a= dding=20 >>> =E2=80=98ocaml-cohttp=E2=80=99=2E >> >> Sorry for being unclear=2E Here's what I mean: >> >> (define-public ocaml-uri-sexp >> (package >> (inherit ocaml-uri) >> (name "ocaml-uri-sexp") >> (arguments >> `(#:package "uri-sexp" >> #:test-target "=2E")) >> (propagated-inputs >> `(("ocaml-uri" ,ocaml-uri) >> ("ocaml-ppx-sexp-conv" ,ocaml-ppx-sexp-conv) >> ("ocaml-sexplib0" ,ocaml-sexplib0))) >> (native-inputs `(("ocaml-ounit" ,ocaml-ounit))))) >> >> Then when `ocaml-uri` eventually gets updated `ocaml-uri` and=20 >> `ocaml-uri-sexp` will be at same version=2E > >But =E2=80=98ocaml-uri=E2=80=99 would first have to be updated to the lat= est version, >which I think is out of scope of this series=2E > >Once this series gets merged, I think it would be great to update >=E2=80=98ocaml-uri=E2=80=99, and then make =E2=80=98ocaml-uri-sexp=E2=80= =99 inherit from it=2E > >WDYT? ------DIIZG14J2K4KRKXC0OUA0J94L2RV0D Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi, what matters is that patches focus on one thin= g, and one one=2E I agree with Adu here, we should make sure uri anl uri-se= xp are the same version=2E If you really don't want to do that in this seri= es, send it as another series, and make it blocking for this one=2E I'll tr= y to merge your work this week-end=2E

Le = 25 juin 2021 06:58:06 GMT-04:00, Xinglu Chen <public@yoctocell=2Exyz>= a =C3=A9crit :
On Fri, Jun 25 2021, Adu O'Hara wrote:

 Xinglu Chen <public@yoctocel=
l=2Exyz> writes:

True, what I was suggesti=
ng would add another patch to the 
series 
and mix up intentions of t=
he series=2E

 Sorry, I don=E2=80=99t get what you are t=
rying to say here=2E

     (=
arguments
      `(#:package "uri-sexp"
        #:test-target "=2E"))<=
br>     (propagated-inputs
       `(("ocaml-uri" ,ocaml-uri)
        =
 ("ocaml-ppx-sexp-conv" ,ocaml-ppx-sexp-conv)
         ("ocaml-sexplib0"=
 ,ocaml-sexplib0)))
     (native-inputs `(("ocaml-ounit" ,ocaml-ounit)))=
))

 Then when `ocaml-uri` eventually gets updated `ocaml-uri` and  `ocaml-uri-sexp` will be at same version=2E

But =E2=
=80=98ocaml-uri=E2=80=99 would first have to be updated to the latest versi=
on,
which I think is out of scope of this series=2E

Once this ser=
ies gets merged, I think it would be great to update
=E2=80=98ocaml-uri=
=E2=80=99, and then make =E2=80=98ocaml-uri-sexp=E2=80=99 inherit from it=
=2E

WDYT?
------DIIZG14J2K4KRKXC0OUA0J94L2RV0D--