unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Leo Prikler <leo.prikler@student.tugraz.at>
To: jgart <jgart@dismail.de>, 47104@debbugs.gnu.org
Subject: [bug#47104] [PATCH 1/2] gnu: Add grumble.
Date: Fri, 12 Mar 2021 21:37:50 +0100	[thread overview]
Message-ID: <68917ec376f1aa2da0e88e9c72a850aa1e531cdd.camel@student.tugraz.at> (raw)
In-Reply-To: <cd89e2168da413f579b889f5d537e6d3@dismail.de>

Hi jgart,

Am Freitag, den 12.03.2021, 16:25 +0000 schrieb jgart:
> Now, to create a grumble-service-type :)
I know you mean this somewhat jokingly, but is there anything (apart
maybe from the name of the binary), that would keep you from reusing
murmur-service-type?

> @@ -4809,7 +4810,7 @@ test results.")
>  (define-public go-github-com-golang-protobuf-proto
>    (package
>      (name "go-github-com-golang-protobuf-proto")
> -    (version "1.3.1")
> +    (version "1.3.5")
>      (source (origin
>                (method git-fetch)
>                (uri (git-reference
> @@ -4818,7 +4819,7 @@ test results.")
>                (file-name (git-file-name name version))
>                (sha256
>                 (base32
> -                "15am4s4646qy6iv0g3kkqq52rzykqjhm4bf08dk0fy2r58knpsy
> l"))))
> +                "1gkd1942vk9n8kfzdwy1iil6wgvlwjq7a3y5jc49ck4lz9rhmgk
> q"))))
>      (build-system go-build-system)
>      (arguments
>       '(#:import-path "github.com/golang/protobuf/proto"
Please refrain from silently bumping other packages 😉

> +      (version (git-version "0.0.0" revision commit))
Three 0s is a bit much for a package, that has declared 1.0~devel since
its inception.  Are there even plans to release this ever?

Apart from the above, there are some other question, that I'd like to
ask before greenlighting this patch.
1. Is this package in its current state usable?
2. Is it still maintained upstream?  It is a little stretch to say
Grumble is undergoing active development after a year of no activity.
3. https://github.com/mumble-voip/grumble#project-status lists quite a
few features that are lacking, but does it maybe contain features, that
would make it worth packaging?

If the answer is "no" to any of the above, I'm not too sure whether it
would be wise to have this in Guix upstream.  If LibreMiami wanted to
host grumble instances on Guix regardless, perhaps a channel might be a
better fit?

> This was packaged by myself, donotshake, and Raghav Gururajan while
> communicating on a grumble instance[...].
I'm not sure whether our broadcasting regulations would require you to
label this patch as product placement, but thanks for the info, I
guess.

Regards,
Leo






  reply	other threads:[~2021-03-12 20:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-12 16:25 [bug#47104] [PATCH 1/2] gnu: Add grumble jgart via Guix-patches via
2021-03-12 20:37 ` Leo Prikler [this message]
2021-04-18 17:25 ` [bug#47104] grumble status update jgart via Guix-patches via
2021-04-18 18:31   ` Leo Prikler
2021-04-18 19:16   ` jgart via Guix-patches via
2022-06-22 18:51     ` bug#47104: [PATCH 1/2] gnu: Add grumble Maxim Cournoyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=68917ec376f1aa2da0e88e9c72a850aa1e531cdd.camel@student.tugraz.at \
    --to=leo.prikler@student.tugraz.at \
    --cc=47104@debbugs.gnu.org \
    --cc=jgart@dismail.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).