From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id 4BetCtMUQGVjSgEAauVa8A:P1 (envelope-from ) for ; Mon, 30 Oct 2023 21:40:51 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id 4BetCtMUQGVjSgEAauVa8A (envelope-from ) for ; Mon, 30 Oct 2023 21:40:51 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C5DA4156B5 for ; Mon, 30 Oct 2023 21:40:50 +0100 (CET) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=BP52LRZ0; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1698698450; a=rsa-sha256; cv=none; b=tkGQgDD6FcNOf3B5NfkG6qZQJi29XWd3DD4TNAGOchaeVBCremSDIjbZk9B8OE+N0o9SUF osg697EjptpvtOAgeD/coyCCWEFxkQL9uzCY6NR/h2OUOcqIzRS8FoLU7Vq+K3FSiOIhe5 +8/wGyFLWlSQWLdZ7Ziqt1Yrq/9yjy9AMfCBPgxrIeecmJ566MTJWev62ADYiIQWC2Gtox 6gj3wWheRUcjMiVrw3Zyjwx602QWonKznjtzHIJ4WIernEdlQkvqcFKRoASGasnTgULaL/ wzdRrUWh6rZ67OS+G+C4UwaDt4QzEdD38eS3/CRaB50R+Jpj20C33aJDBK7ySA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=BP52LRZ0; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1698698450; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=1bf/1/Re/IFGe9Gi6kHtTZXu1irnNzPVBGQxKsuEYIE=; b=lC8bWc7NwNNxD2BodtH17hlUGGmpZtUo67sm7WbKA7I5CGX+4kxacjgxCiqRe/X7gsdadl qzXTKH+wwkWDYQD2CtUuEn9XKpVIlD0WKJF/QiEpAyJtj8iwr/B2y/dDoWSNpmhUr+02db cg3n3HApfpzz4cUDvv0OhlwD9+Q6hDrXugXkuSr6cwE7ogjfrGSqVfG/wk0hSQ0m3Jpd2e 6rYLjKdz8p6PkSVxGwjNkD0ZCXgddY/AB0hkShlE87U0jYOEM+DiFbrZVKtnn0wJLzg/SF 4aunc1B/m3JxHp4ptJfbOmhW3ES6cs8vx+RA9zi3hn5TdQfLv16TgTZwgpDyWg== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qxZ3m-0000uS-LI; Mon, 30 Oct 2023 16:40:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qxZ3l-0000uH-La for guix-patches@gnu.org; Mon, 30 Oct 2023 16:40:29 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qxZ3l-0007up-BH for guix-patches@gnu.org; Mon, 30 Oct 2023 16:40:29 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qxZ4I-0008In-CI for guix-patches@gnu.org; Mon, 30 Oct 2023 16:41:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#66801] [PATCH va3e5ae0f..37252e07 01/32] rebar-build-system and packages. Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 30 Oct 2023 20:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66801 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Pierre-Henry =?UTF-8?Q?Fr=C3=B6hring?= Cc: 66801@debbugs.gnu.org Received: via spool by 66801-submit@debbugs.gnu.org id=B66801.169869844431877 (code B ref 66801); Mon, 30 Oct 2023 20:41:02 +0000 Received: (at 66801) by debbugs.gnu.org; 30 Oct 2023 20:40:44 +0000 Received: from localhost ([127.0.0.1]:46736 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qxZ40-0008I3-5O for submit@debbugs.gnu.org; Mon, 30 Oct 2023 16:40:44 -0400 Received: from mail-ej1-x641.google.com ([2a00:1450:4864:20::641]:46154) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qxZ3y-0008Hp-BD for 66801@debbugs.gnu.org; Mon, 30 Oct 2023 16:40:42 -0400 Received: by mail-ej1-x641.google.com with SMTP id a640c23a62f3a-98377c5d53eso743392366b.0 for <66801@debbugs.gnu.org>; Mon, 30 Oct 2023 13:40:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698698403; x=1699303203; darn=debbugs.gnu.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=1bf/1/Re/IFGe9Gi6kHtTZXu1irnNzPVBGQxKsuEYIE=; b=BP52LRZ0Y2gBY48HkrOQiZPv+U8sDsyQkyheJ/bbG/Q9WDmxtjhp9u5mM8JBKvqQ2c LsVEYaNL+kYwFBzqwiZUz9NY0bBh+XfvV2IJkltP5DITDFf1mAOaUT/HE5a3OKjSdrM2 9xXyBkhCbx5AzBDh8Il+TWrp3Yg/0Xq/hYJaNSbLKWqMdxEidl6Hzo52cZaW0S80dFK2 wnArOg23IumiAbU4QRWFTPCwjFG+aq9wovUA/VhBGjgex8Vzp1RADpuQbwWovPHy211Y afE820bNBX8nB6cqguUuaxVqYiRibeaW6fCVN9zujG1osXEPMd0R8vM2ohSqsKUtMnfW +Lwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698698403; x=1699303203; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=1bf/1/Re/IFGe9Gi6kHtTZXu1irnNzPVBGQxKsuEYIE=; b=WpPjSEp65h1d/5x7J/IElTpKtxPsBv9pB/u/yhurk0p9b/1Zme8/rydsV8e+EMO+BA q3v4d+UniY3hMygdYUK8lG1tw2scDC4/h+MHj5CzMU5jXj4qey2hX/Z7eW9ckDMSr93M 5nenNMAC0CTe+2xc1U8UMIwBaVpXaO4jDaYKeZffXxBXSLvVEYeJe3QrJsKZAPurFcgi IFkoUIpKBIYCsmtx7UmSXAb8wAYQBevZuCCe5HuhvNPb7IRxkSzCqi2DJvJJNO7GkjKN Ekno2kzpLpsqBN5kIrk5YhrSQLUFrX0X975vhn2PhjpgHVZfqP/GGAcpvNey0IR0ucaQ pAuw== X-Gm-Message-State: AOJu0Yzrgb6l91Y+LwQZgAXCW4SrGkyoeI8J+ht1TRs7qt2CaaOvRHKR QHat/DSpfG87a20oUxkwqqA= X-Google-Smtp-Source: AGHT+IFBgGad4ZD4g/h1vO1GMBuBVQb72pjLvBgQA7tot1KBvUgrKQsdzov/EfGl4M3fIsDyUftoig== X-Received: by 2002:a17:907:da0:b0:9bd:a73a:7a0d with SMTP id go32-20020a1709070da000b009bda73a7a0dmr10942089ejc.13.1698698402855; Mon, 30 Oct 2023 13:40:02 -0700 (PDT) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id rp28-20020a170906d97c00b009b296ce13a3sm6609300ejb.18.2023.10.30.13.40.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Oct 2023 13:40:01 -0700 (PDT) Message-ID: <683bb1149e6bfd3f1ade1976463a834edc6d16a3.camel@gmail.com> From: Liliana Marie Prikler Date: Mon, 30 Oct 2023 21:40:00 +0100 In-Reply-To: References: <7ceab0dcbe069f664377786b5bb531e2196fffc1.camel@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4 MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Queue-Id: C5DA4156B5 X-Migadu-Scanner: mx12.migadu.com X-Migadu-Spam-Score: -5.01 X-Spam-Score: -5.01 X-TUID: Gb3vpK65G2iS Am Montag, dem 30.10.2023 um 13:30 +0100 schrieb Pierre-Henry Fr=C3=B6hring= : > [...] > Comment updated with: > #+begin_example > ;; If these directories exist, then no error occurs. So, we make > sure > ;; they exist. > #+end_example > Is this OK? >=20 > I don't see how to prevent rebar3 to do that. It's apparently an > opened issue: > https://github.com/erlang/rebar3/issues/1173 I'd recommend sticking with the current flow, however, and either create those directories unconditionally or inside the=C2=A0 (when (file-exists? =E2=80=A6) =E2=80=A6) In general, don't mix gratuitous "styling" changes into your commits.=20 Try to keep your edits minimal and reviewable. > Here is the approach taken so far: > 1) The objective is to ensure that =3Dmix compile=3D does not attempt to > use the network and, as a result, fails to compile. > 2) For the above to be true, it is necessary to have =E2=80=94 at build t= ime > =E2=80=94 the=C2=A0sources of all Erlang input packages and install th= em as > checkouts. > 3) Thus, the question becomes: How to access all the Erlang package=C2=A0 > sources at build time? > [...] One idea both of us haven't voiced so far is to actually grab these in the (guix build-system =E2=80=A6) code rather than the (guix build =E2=80= =A6) side and make the sources available via a mapping. Think package =E2=86=92 (package= - source package). The downsides of this are quite obvious. First, to my knowledge something like that hasn't been done yet, so there's no reference point. Second, the (guix build =E2=80=A6) side would still need to identif= y what's an erlang source. Given our code for the unpack phase, I'd hazard a guess that this is non-trivial. Thus, even if there's theoretically a way to not store the same tarball twice, in practice it doesn't really matter. You could alternatively also write the sources to a special source output if and only if one such output is requested via the outputs field. Again, I'd hazard a guess that this would be a very standard output for anything that needs to go into mix-build-system and thus not worth the split after all. Alternatively=C2=B2 you could patch mix to only look for compiled stuff and not sources. That would tackle the issue at the root instead of trying to work around it, with the caveat being that we would need to maintain this patch ourselves if upstream doesn't accept it. Cheers=20