From: Leo Prikler <leo.prikler@student.tugraz.at>
To: Raghav Gururajan <rg@raghavgururajan.name>, 45721@debbugs.gnu.org
Subject: [bug#45721] Telegram Desktop (v13)
Date: Sun, 17 Jan 2021 13:13:07 +0100 [thread overview]
Message-ID: <67f3a995fb657c86efd2ecdc403b24cb2d441524.camel@student.tugraz.at> (raw)
In-Reply-To: <ae71c9c2-cdb8-0f13-b212-0a0c8fc4369b@raghavgururajan.name>
Hi,
Am Samstag, den 16.01.2021, 20:52 -0500 schrieb Raghav Gururajan:
> * gnu/packages/fcitx.scm (fcitx-qt5): New variable.
LGTM.
> + (version
> + (git-version "1" revision commit))
You can still use "0" or "0.0.0" for the base version.
> + (add-after 'unpack 'delete-thirdparty
> + (lambda _
> + (with-directory-excursion "src/third_party"
> + (for-each delete-file-recursively
> + ;; [1] Keep Abseil-CPP, LibSRTP, LibVPx,
> LibYuv,
> + ;; OpenH264, PFFFT, RnNoise and UsrSCTP.
> + ;; [2] Tg_owt uses custom fork of Abseil-
> CPP,
> + ;; LibSRTP, OpenH264 and RnNoise.
> + ;; [3] Tg_owt uses specific
> version/commit of LibVPx,
> + ;; which is different from one available
> in Guix.
> + ;; [4] LibYuv, PFFFT and UsrSCTP aren't
> available.
> + (list
> + "yasm")))
I forgot to mention this, but this should be a snippet, perhaps even a
computed origin.
Also, as it has been noted in your Nextcloud patch (IIRC), you should
formulate this in terms of what to keep.
E.g.
'(;; custom forks of existing packages
;; the forks are incompatible with what we have in Guix
"abseil-cpp" "libsrtp" "openh264" "rnnoise"
;; XXX: packages currently lacking a description
"pffft" "usrsctp")
> + (add-after 'delete-thirdparty 'copy-inputs
> + (lambda* (#:key inputs outputs #:allow-other-keys)
> + (let* ((libvpx-from (assoc-ref inputs "libvpx"))
> + (libyuv-from (assoc-ref inputs "libyuv"))
> + (libvpx-to (string-append (getcwd)
> + "/src/third_party/li
> bvpx/source/libvpx"))
> + (libyuv-to (string-append (getcwd)
> + "/src/third_party/li
> byuv")))
> + (copy-recursively libvpx-from libvpx-to)
> + (copy-recursively libyuv-from libyuv-to))
> + #t)))))
Should be after unpack (see above), otherwise LGTM.
> + ("libvpx"
> + ,(origin
> + (method git-fetch)
> + (uri
> + (git-reference
> + (url "https://chromium.googlesource.com/webm/libvpx")
> + (commit "5b63f0f")))
> + (file-name
> + (git-file-name "libvpx" version))
> + (sha256
> + (base32
> "1psvxaddihlw1k5n0anxif3qli6zyw2sa2ywn6mkb8six9myrp68"))))
> + ("libyuv"
> + ,(origin
> + (method git-fetch)
> + (uri
> + (git-reference
> + (url "https://chromium.googlesource.com/libyuv/libyuv
> ")
> + (commit "ad89006")))
> + (file-name
> + (git-file-name "libyuv" version))
> + (sha256
> + (base32
> "01knnk4h247rq536097n9n3s3brxlbby3nv3ppdgsqfda3k159ll"))))
Use long hashes. Also, try to make things work with the nearest
release. You might also want to package them individually as "libvpx-
for-telegram-desktop" etc. if everything else fails, see stepmania as
an example with a custom ffmpeg.
As per our discussion in IRC, this should be part of the telegram
module.
Regards,
Leo
next prev parent reply other threads:[~2021-01-17 12:14 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-08 0:20 [bug#45721] Telegram Desktop Raghav Gururajan
2021-01-08 0:44 ` [bug#45721] Telegram Desktop (v2) Raghav Gururajan
2021-01-12 3:12 ` [bug#45721] Telegram Desktop (v3) Raghav Gururajan
2021-01-12 3:27 ` [bug#45721] Telegram Desktop (v4) Raghav Gururajan
2021-01-13 22:13 ` [bug#45721] Telegram Desktop (v5) Raghav Gururajan
2021-01-14 5:39 ` [bug#45721] Telegram Desktop (v6) Raghav Gururajan
2021-01-14 6:41 ` [bug#45721] Telegram Desktop (v7) Raghav Gururajan
2021-01-14 10:38 ` [bug#45721] Telegram Desktop (v8) Raghav Gururajan
2021-01-16 16:08 ` [bug#45721] Telegram Desktop (v9) Raghav Gururajan
2021-01-16 17:15 ` Nicolò Balzarotti
2021-01-16 21:22 ` Raghav Gururajan
2021-01-16 18:04 ` Leo Prikler
2021-01-17 0:19 ` Raghav Gururajan
2021-01-17 0:36 ` Leo Prikler
2021-01-17 1:10 ` Raghav Gururajan
2021-01-17 0:05 ` [bug#45721] Telegram Desktop (v10) Raghav Gururajan
2021-01-17 0:29 ` [bug#45721] Telegram Desktop (v11) Raghav Gururajan
2021-01-17 1:04 ` [bug#45721] Telegram Desktop (v12) Raghav Gururajan
2021-01-17 1:52 ` [bug#45721] Telegram Desktop (v13) Raghav Gururajan
2021-01-17 12:13 ` Leo Prikler [this message]
2021-01-17 14:49 ` Raghav Gururajan
2021-01-17 19:08 ` [bug#45721] [PATCH v15] Add Telegram Desktop Leo Prikler
2021-01-17 21:59 ` Raghav Gururajan
2021-01-19 10:11 ` [bug#45721] [PATCH v16] " Leo Prikler
2021-01-17 14:43 ` [bug#45721] Telegram Desktop (v14) Raghav Gururajan
2021-01-20 10:41 ` [bug#45721] Telegram Desktop (v17) Raghav Gururajan
2021-01-20 11:07 ` Leo Prikler
2021-01-20 12:32 ` Raghav Gururajan
2021-01-20 12:29 ` [bug#45721] Telegram Desktop (v18) Raghav Gururajan
2021-01-20 13:49 ` [bug#45721] Telegram Desktop (v19) Raghav Gururajan
2021-01-20 14:42 ` [bug#45721] Telegram Desktop (v20) Raghav Gururajan
2021-01-20 15:10 ` Leo Prikler
2021-01-21 3:44 ` [bug#45721] Telegram Desktop (v21) Raghav Gururajan
2021-01-21 19:11 ` [bug#45721] [PATCH v22] Add Telegram Desktop Leo Prikler
2021-01-21 19:37 ` Raghav Gururajan
2021-01-21 19:44 ` Leo Prikler
2021-01-21 19:46 ` Raghav Gururajan
2021-01-22 4:27 ` [bug#45721] Telegram Desktop (v23) Raghav Gururajan
2021-01-22 7:42 ` Leo Prikler
2021-01-28 0:41 ` Raghav Gururajan
2021-01-28 0:41 ` [bug#45721] Telegram Desktop (v24) Raghav Gururajan
2021-01-28 7:47 ` Leo Prikler
2021-01-30 17:04 ` [bug#45721] Telegram Desktop (v25) Raghav Gururajan
[not found] ` <e881733992b22e238f2b90149dbceac6c3467180.camel@student.tugraz.at>
[not found] ` <e5040a67-824f-17c8-e16f-1a68531b3d5f@raghavgururajan.name>
2021-01-30 18:24 ` Leo Prikler
2021-01-30 19:30 ` Raghav Gururajan
2021-01-30 18:02 ` [bug#45721] Telegram Desktop (v26) Raghav Gururajan
2021-01-30 19:02 ` [bug#45721] Telegram Desktop (v27) Raghav Gururajan
2021-01-31 8:37 ` bug#45721: " Leo Prikler
2021-01-31 19:11 ` [bug#45721] " Raghav Gururajan
2021-01-31 13:57 ` Jonathan Brielmaier
2021-01-31 14:10 ` Leo Prikler
2021-01-31 16:50 ` Jonathan Brielmaier
2021-01-31 16:56 ` Leo Prikler
2021-01-31 17:01 ` Jonathan Brielmaier
2021-01-31 19:14 ` Raghav Gururajan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67f3a995fb657c86efd2ecdc403b24cb2d441524.camel@student.tugraz.at \
--to=leo.prikler@student.tugraz.at \
--cc=45721@debbugs.gnu.org \
--cc=rg@raghavgururajan.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).