From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60072) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dwkgy-0008TX-AQ for guix-patches@gnu.org; Tue, 26 Sep 2017 03:54:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dwkgs-0006vC-O8 for guix-patches@gnu.org; Tue, 26 Sep 2017 03:54:08 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:50907) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dwkgs-0006v6-KU for guix-patches@gnu.org; Tue, 26 Sep 2017 03:54:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dwkgs-00047x-BR for guix-patches@gnu.org; Tue, 26 Sep 2017 03:54:02 -0400 Subject: [bug#28560] [PATCH] web: Add try-files for the nginx-service-type. Resent-Message-ID: Date: Tue, 26 Sep 2017 09:53:52 +0200 In-Reply-To: <87fubcynmx.fsf@gmail.com> References: <874lruckq8.fsf@gmail.com> <87k20prshw.fsf@gmail.com> <87h8vtrrlz.fsf@gmail.com> <87d16hrpdq.fsf@gmail.com> <72986E30-EF66-44C3-AAEC-718F0CAD19D4@lepiller.eu> <87fubcynmx.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----U42XU8R6W0RGTOEDTW4OIKXUHDPB33" Content-Transfer-Encoding: 7bit From: Julien Lepiller Message-ID: <67F0DB51-4862-4965-B467-DB517FB3F348@lepiller.eu> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" Cc: 28560@debbugs.gnu.org ------U42XU8R6W0RGTOEDTW4OIKXUHDPB33 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Le 24 septembre 2017 20:09:26 GMT+02:00, Oleg Pykhalov a =C3=A9crit : >Hello Julien, > >Julien Lepiller writes: > >> Thank you for the patch! I think it will be perfect after you update >doc/guix=2Etexi too=2E > >Thank you for review=2E > >I rephrase little bit >https://nginx=2Eorg/en/docs/http/ngx_http_core_module=2Ehtml#try_files > >Here is a new patch=2E Hi, I don't think your rephrasing works, I have some troubles making sense of = it, even though I know what it is supposed to do=2E Maybe: A list of files whose existence is checked in the specified order=2E @code= {nginx} will use the first file it finds to process the request=2E I'm not sure about the last part of your sentence, do we explain what the = "current context" is? Is it even relevant? Could you add a sentence to expl= ain the usage of variables here, such as "$uri"? Maybe a small example woul= d be enough=2E Thank you! ------U42XU8R6W0RGTOEDTW4OIKXUHDPB33 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable
Le 24 septembre 2017 20= :09:26 GMT+02:00, Oleg Pykhalov <go=2Ewigust@gmail=2Ecom> a =C3=A9cri= t :
Hello Julien,

Julien Lepiller <julien@=
lepiller=2Eeu> writes:

 Thank you for the patch! I think it will be perfect after you u=
pdate doc/guix=2Etexi too=2E

Thank you for review=
=2E

I rephrase little bit
https://nginx=2Eorg/en/do=
cs/http/ngx_http_core_module=2Ehtml#try_files

Here is a new =
patch=2E


Hi,

I don't think your rephrasing works, I have some troubles making sense= of it, even though I know what it is supposed to do=2E Maybe:

A list of files whose existence is checked in the specified order=2E @code= {nginx} will use the first file it finds to process the request=2E

I'm not sure about the last part of your sentence, do we explain what = the "current context" is? Is it even relevant? Could you add a se= ntence to explain the usage of variables here, such as "$uri"? Ma= ybe a small example would be enough=2E

Thank you! ------U42XU8R6W0RGTOEDTW4OIKXUHDPB33--