unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Maxime Devos <maximedevos@telenet.be>
To: Gabriel Wicki <gabriel@erlikon.ch>, 56087@debbugs.gnu.org
Subject: [bug#56087] [PATCH] gnu: suckless: add farbfeld and propagate input to sent
Date: Sun, 19 Jun 2022 15:17:54 +0200	[thread overview]
Message-ID: <66ac65e65fb19a239aedcb132c75343b88083306.camel@telenet.be> (raw)
In-Reply-To: <20220619115925.bcrcjpd7yse2n25t@silvi>

[-- Attachment #1: Type: text/plain, Size: 958 bytes --]

Gabriel Wicki schreef op zo 19-06-2022 om 14:23 [+0200]:
> +       `(#:make-flags (list "PREFIX="
> +                            (string-append "DESTDIR=" %output)

Guix does not do staged installation (that's what DESTDIR is for!), so
don't set DESTDIR, instead set PREFIX to #$output instead of DESTDIR
(the difference matters when the compiled program embeds a reference to
its own installation location).  Also, G-exps, because %output isn't
documented IIRC whereas #$output is:

  (arguments
    (list #:make-flags
          #~(list (string-append "PREFIX=" #$output)
                  (string-append "CC=" #$(cc-for-target)))
          #:phases
          #~(modify-phases %standard-phases
              (delete 'configure)
              (delete 'check))))

Also, always add a comment about why tests are skipped (maybe someone
knows how to fix them or the bug they noticed!).

Greetings,
Maxime

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]

  parent reply	other threads:[~2022-06-19 13:19 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-19 12:23 [bug#56087] [PATCH] gnu: suckless: add farbfeld and propagate input to sent Gabriel Wicki
     [not found] ` <handler.56087.B.165564143722867.ack@debbugs.gnu.org>
2022-06-19 12:36   ` [bug#56087] Acknowledgement ([PATCH] gnu: suckless: add farbfeld and propagate input to sent) Gabriel Wicki
2022-06-19 13:12     ` Maxime Devos
2022-06-19 13:17 ` Maxime Devos [this message]
2022-06-21  0:50   ` [bug#56087] [PATCH] gnu: suckless: add farbfeld and propagate input to sent Gabriel Wicki
2022-06-22 21:14     ` bug#56087: " Ludovic Courtès
2022-06-19 13:18 ` [bug#56087] " Maxime Devos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=66ac65e65fb19a239aedcb132c75343b88083306.camel@telenet.be \
    --to=maximedevos@telenet.be \
    --cc=56087@debbugs.gnu.org \
    --cc=gabriel@erlikon.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).