From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54655)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d0Ehl-0001eF-Kw
	for guix-patches@gnu.org; Mon, 17 Apr 2017 18:01:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d0Ehi-0006Bb-K5
	for guix-patches@gnu.org; Mon, 17 Apr 2017 18:01:05 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:54891)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1d0Ehi-0006BI-HU
	for guix-patches@gnu.org; Mon, 17 Apr 2017 18:01:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d0Ehi-00045V-2w
	for guix-patches@gnu.org; Mon, 17 Apr 2017 18:01:02 -0400
Subject: bug#26515: Acknowledgement ([PATCH] gnu: Add emacs-calfw.)
Resent-Message-ID: <handler.26515.D26515.149246642115659@debbugs.gnu.org>
References: <20170415112452.912-1-va511e@yahoo.com>
	<handler.26515.B.14922555097860.ack@debbugs.gnu.org>
	<e22fc83d-3557-9d79-9fc1-d5da89158d7b@yahoo.com>
	<87k26kr9mz.fsf@gmail.com>
From: Vasile Dumitrascu <va511e@yahoo.com>
Message-ID: <664cb696-8da2-017b-6f51-01efeadfb5b1@yahoo.com>
Date: Mon, 17 Apr 2017 22:00:00 +0000
MIME-Version: 1.0
In-Reply-To: <87k26kr9mz.fsf@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Alex Kost <alezost@gmail.com>
Cc: 26515-done@debbugs.gnu.org

  Hi

  I did miss the linter warning, regarding the tarball name, sorry for that.

  I will prepare packages for 'howm' and 'google-maps', in order not to
leave the calfw only partially working, and I will send the patches asap.

  Thank you for the observations,

   Vasile

Alex Kost:
> Vasile Dumitrascu (2017-04-15 14:37 +0000) wrote:
> 
>>    Hi
>>
>> I have added a small correction on the homepage for calfw, as I forgot
>> to update the Url from the code stub I have used.
> 
> Applied¹, thanks!  Next time, if you have corrections to your original
> patch, please send an updated patch instead of the new patch build on
> top of the original one.
> 
> Note that "guix lint emacs-calfw" reports:
> 
>   gnu/packages/emacs.scm:1200:5: emacs-calfw@1.5: the source file name should contain the package name
> 
> This means the source origin should contain:
> 
>   (file-name (string-append name "-" version ".tar.gz"))
> 
> Otherwise, the downloaded tarball will have the following name in the
> store (this is often the case with github tagged releases):
> 
>    /gnu/store/...-v1.5.tar.gz
> 
> while we prefer
> 
>    /gnu/store/...-emacs-calfw-1.5.tar.gz
> 
> 
> Finally, I see that for some additional features, this package require
> 'howm' and 'google-maps' emacs packages, so these features won't work;
> but you probably know about it.
> 
> ¹ http://git.savannah.gnu.org/cgit/guix.git/commit/?id=36890436710032d6c731e31becf6a5bd7aa4afaf
>