unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Vasile Dumitrascu <va511e@yahoo.com>
To: Alex Kost <alezost@gmail.com>
Cc: 26515-done@debbugs.gnu.org
Subject: bug#26515: Acknowledgement ([PATCH] gnu: Add emacs-calfw.)
Date: Mon, 17 Apr 2017 22:00:00 +0000	[thread overview]
Message-ID: <664cb696-8da2-017b-6f51-01efeadfb5b1@yahoo.com> (raw)
In-Reply-To: <87k26kr9mz.fsf@gmail.com>

  Hi

  I did miss the linter warning, regarding the tarball name, sorry for that.

  I will prepare packages for 'howm' and 'google-maps', in order not to
leave the calfw only partially working, and I will send the patches asap.

  Thank you for the observations,

   Vasile

Alex Kost:
> Vasile Dumitrascu (2017-04-15 14:37 +0000) wrote:
> 
>>    Hi
>>
>> I have added a small correction on the homepage for calfw, as I forgot
>> to update the Url from the code stub I have used.
> 
> Applied¹, thanks!  Next time, if you have corrections to your original
> patch, please send an updated patch instead of the new patch build on
> top of the original one.
> 
> Note that "guix lint emacs-calfw" reports:
> 
>   gnu/packages/emacs.scm:1200:5: emacs-calfw@1.5: the source file name should contain the package name
> 
> This means the source origin should contain:
> 
>   (file-name (string-append name "-" version ".tar.gz"))
> 
> Otherwise, the downloaded tarball will have the following name in the
> store (this is often the case with github tagged releases):
> 
>    /gnu/store/...-v1.5.tar.gz
> 
> while we prefer
> 
>    /gnu/store/...-emacs-calfw-1.5.tar.gz
> 
> 
> Finally, I see that for some additional features, this package require
> 'howm' and 'google-maps' emacs packages, so these features won't work;
> but you probably know about it.
> 
> ¹ http://git.savannah.gnu.org/cgit/guix.git/commit/?id=36890436710032d6c731e31becf6a5bd7aa4afaf
> 

  reply	other threads:[~2017-04-17 22:01 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-15 11:24 bug#26515: [PATCH] gnu: Add emacs-calfw Vasile Dumitrascu
     [not found] ` <handler.26515.B.14922555097860.ack@debbugs.gnu.org>
2017-04-15 14:37   ` bug#26515: Acknowledgement ([PATCH] gnu: Add emacs-calfw.) Vasile Dumitrascu
2017-04-16  9:20     ` Alex Kost
2017-04-17 22:00       ` Vasile Dumitrascu [this message]
2017-04-16 10:02 ` bug#26515: [PATCH] gnu: Add emacs-calfw Ludovic Courtès
2017-04-17 22:01   ` Vasile Dumitrascu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=664cb696-8da2-017b-6f51-01efeadfb5b1@yahoo.com \
    --to=va511e@yahoo.com \
    --cc=26515-done@debbugs.gnu.org \
    --cc=alezost@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).