From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id YKoON3j4KmMuEAAAbAwnHQ (envelope-from ) for ; Wed, 21 Sep 2022 13:41:44 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id wKH4Nnj4KmOXQAAAauVa8A (envelope-from ) for ; Wed, 21 Sep 2022 13:41:44 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id AB2ED1A210 for ; Wed, 21 Sep 2022 13:41:44 +0200 (CEST) Received: from localhost ([::1]:44468 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oay6p-0008VL-DJ for larch@yhetil.org; Wed, 21 Sep 2022 07:41:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43500) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oay6A-0008Ps-C9 for guix-patches@gnu.org; Wed, 21 Sep 2022 07:41:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:33615) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oay6A-0000bQ-2c for guix-patches@gnu.org; Wed, 21 Sep 2022 07:41:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oay69-0000QJ-Tr for guix-patches@gnu.org; Wed, 21 Sep 2022 07:41:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#57963] [PATCH 1/1] home: fontutils: Support user's fontconfig. Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 21 Sep 2022 11:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57963 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Taiju HIGASHI Cc: 57963@debbugs.gnu.org Received: via spool by 57963-submit@debbugs.gnu.org id=B57963.16637604221535 (code B ref 57963); Wed, 21 Sep 2022 11:41:01 +0000 Received: (at 57963) by debbugs.gnu.org; 21 Sep 2022 11:40:22 +0000 Received: from localhost ([127.0.0.1]:60925 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oay5W-0000Oh-AP for submit@debbugs.gnu.org; Wed, 21 Sep 2022 07:40:22 -0400 Received: from mailrelay.tugraz.at ([129.27.2.202]:37950) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oay5U-0000OT-Dd for 57963@debbugs.gnu.org; Wed, 21 Sep 2022 07:40:21 -0400 Received: from lprikler-laptop.ist.intra (gw.ist.tugraz.at [129.27.202.101]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4MXc0b59g9z1DPy8; Wed, 21 Sep 2022 13:40:15 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 mailrelay.tugraz.at 4MXc0b59g9z1DPy8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1663760416; bh=7c64LMVhIQbeeocNQtA2/JjHpJK3h9uF/0nODBf+fI0=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=fr86r7sbC1j8Pj2IbPtva/RFnxu6jn40GNKWRrQI5DIhIxajXfKTUifR8+2m4SKdx X3W11fR9tr943ZG4OVLAaTM03zDZy+H2eMumAqvMjExVEL/bcWRNNA0aCRAkfTRGuX NyDBjNaWUqOnOCzkCLNYWIXJnmxwxLy0SerFlzss= Message-ID: <65da0cdb245fe2bcd99589d4fb1a9eb785a1b527.camel@ist.tugraz.at> From: Liliana Marie Prikler Date: Wed, 21 Sep 2022 13:40:14 +0200 In-Reply-To: <871qs5xd30.fsf@taiju.info> References: <20220921002921.23631-2-higashi@taiju.info> <871qs5xd30.fsf@taiju.info> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.45.3 MIME-Version: 1.0 X-TUG-Backscatter-control: waObeELIUl4ypBWmcn/8wQ X-Scanned-By: MIMEDefang 2.74 on 129.27.10.117 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1663760504; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=7c64LMVhIQbeeocNQtA2/JjHpJK3h9uF/0nODBf+fI0=; b=rsbaMU/yTTmC/B9DqIwg99bo3CfTYoPC95PJMUj0ZcLQxo3uRmJfhXuL/d3Gi0pRSkx+oz EWus1N3k0GnHdP3SbBhKggD+dw8ksP9STBElTwvo5/tPdi5U9Dx74kjRy9BLp/Wg5Em3nl Writrg6d7La6XdeMWtb7Yu8Xu4wks5/pvjUKt1eJZRlQa6u+PsPstATkg/47yaVMSMcKdV j1dyDToCxj9hV7lGUkZxIYybTu4QH6Ovm5zZDD1y1BkUHKOLTXsQMyZNKD+Q13bBP17daO pEIA8N70qrU1AWvENpAaRY0qi7QVWW0QnxFyDNnUfKqrdmkOL6vbmg02CdtHXw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1663760504; a=rsa-sha256; cv=none; b=usdjuF02dsq1ChoW2g2twzphlaH24Snm+uKaN7luKTPQtzg8rtUcIk+tRMgTt7EapSCbA1 O6+pDJA5iwcq71hvYlZcuBoAOBV8Z88SEbiLY9GqCeihh3GgwWJhPIPQsULoFHLmDRb5gD j9+JZ7oQorBdCNkQNuOMHJHDDYnjA4PVTohu8oZbnJEAHTyUxyuF1HMHquO9MStmTi3BpF +0HkeaTIiEARQFt+Mmj1Vfa6hA9NyRbMz94E/OuUpYR1aZkJ7sSA0Qzj0SITiqXg5WktD0 g8Qd4rkuq5fkbWQbrytZmA11EZWsBPVHk+36DcgzrWV/Xj7ZkJxPuBZ//R14EQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tugraz.at header.s=mailrelay header.b=fr86r7sb; dmarc=fail reason="SPF not aligned (relaxed)" header.from=tugraz.at (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 5.96 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tugraz.at header.s=mailrelay header.b=fr86r7sb; dmarc=fail reason="SPF not aligned (relaxed)" header.from=tugraz.at (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: AB2ED1A210 X-Spam-Score: 5.96 X-Migadu-Scanner: scn1.migadu.com X-TUID: wSVuJba8exZR Am Mittwoch, dem 21.09.2022 um 18:59 +0900 schrieb Taiju HIGASHI: > Hi Liliana, >=20 > Thank you for your review. >=20 > > > -(define (add-fontconfig-config-file he-symlink-path) > > > +(define (add-fontconfig-config-file font-config) > > > =C2=A0=C2=A0 `(("fontconfig/fonts.conf" > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ,(mixed-text-file > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "fonts.conf" > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 " > > > =C2=A0 > > > =C2=A0 > > > -=C2=A0 ~/.guix-home/profile/share/fonts > > > -")))) > > > +=C2=A0 ~/.guix-home/profile/share/fonts\n" > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (if (null? font-config) > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "" > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (string= -join font-config "\n" 'suffix)) > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "\n")))) > > I think it'd be wiser to pretty-print SXML here. > > The structure could look something like > > `(fontconfig > > =C2=A0=C2=A0 (dir "~/.guix-home/profile/share/fonts") > > =C2=A0=C2=A0 ,@(extra-user-config ...)) >=20 > That's definitely better! > Does this assume that SXML will also accept additional user settings? It assumes that whatever (extra-user-config ...) does, it returns a list of SXML nodes, e.g. ((dir "~/.fonts")). Writing correct SXML should be comparatively simpler to writing correct XML. > > Also, for the particular use case of handling multiple profiles > > gracefully (rather than the current status quo) I think fontconfig- > > service-type should be able to construct (dir > > "#$profile/share/fonts") style entries on its own.=C2=A0 However, given > > that multiple profiles aren't supported yet, this is future work. >=20 > Noted. I believe that even with the current patch, it is possible to > add arbitrary directories, so it will be better than what we have > now. That's fine, just know that this use case might at some point become obsolete thanks to a better implementation :)