unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: paul <goodoldpaul@autistici.org>
To: Sarah Morgensen <iskarian@mgsn.dev>
Cc: 49834@debbugs.gnu.org
Subject: [bug#49834] Add dynaconf
Date: Sat, 28 Aug 2021 13:50:58 +0200	[thread overview]
Message-ID: <6567b413-0db6-5d1e-e979-7807fa086a99@autistici.org> (raw)
In-Reply-To: <86im0l2hj0.fsf@mgsn.dev>

Dear Sarah,

thank you for your review!

On 8/4/21 8:26 PM, Sarah Morgensen wrote:
> The pyproject.toml file does say this is "MIT" (= expat), but there's no
> actual license file in the project. I don't think this is sufficient as
> far as Guix is concerned (perhaps an actual maintainer/committer can
> comment?)

First of all I opened an upstream PR [0] to add an actual LICENSE file: 
I hope that, given its simplicity, it will get merged soon.

I'm no expert about this but I tried building dynaconf without 
flake8-debugger and it seems to work flawlessly. The dependency was put 
there by the python importer, probably the developers have it in some 
dev-dependencies declaration needed to commit well-formatted code in the 
repository.

Since flake8-debugger doesn't appear to be required for the inclusion of 
dynaconf maybe we can exclude it for this time and whenever the PR will 
be merged I'll open another Guix issue to add it.

What do you think about this approach? (I'm attaching an updated 
patch-set without flake8-debugger and rebased on current master).


Thank you for your time :)


Giacomo


[0]: https://github.com/JBKahn/flake8-debugger/pull/29/files






  reply	other threads:[~2021-08-28 11:52 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-02 18:13 [bug#49834] [PATCH 1/7] gnu: Add python-flake8-debugger Giacomo Leidi
2021-08-02 18:13 ` [bug#49830] [PATCH 2/7] gnu: Add python-flake8-todo Giacomo Leidi
2021-08-02 18:13 ` [bug#49833] [PATCH 3/7] gnu: Add python-dotenv Giacomo Leidi
2021-08-04 18:35   ` [bug#49281] Add dynaconf Sarah Morgensen
2021-08-02 18:13 ` [bug#49832] [PATCH 4/7] gnu: Add python-box Giacomo Leidi
2021-08-02 18:13 ` [bug#49829] [PATCH 5/7] gnu: python-ruamel.yaml: Update to 0.17.10 Giacomo Leidi
2021-08-02 18:13 ` [bug#49831] [PATCH 6/7] gnu: Add python-pep8-naming Giacomo Leidi
2021-08-02 18:13 ` [bug#49835] [PATCH 7/7] gnu: Add dynaconf Giacomo Leidi
2021-08-04 19:13   ` [bug#49281] " Sarah Morgensen
2021-08-04 18:26 ` Sarah Morgensen
2021-08-28 11:50   ` paul [this message]
2021-08-28 11:51 ` [bug#49834] [PATCH 1/6] gnu: Add python-flake8-todo Giacomo Leidi
2021-08-28 11:51   ` [bug#49834] [PATCH 2/6] gnu: Add python-dotenv Giacomo Leidi
2021-08-28 11:51   ` [bug#49834] [PATCH 3/6] gnu: Add python-box Giacomo Leidi
2021-08-28 11:51   ` [bug#49834] [PATCH 4/6] gnu: python-ruamel.yaml: Update to 0.17.10 Giacomo Leidi
2021-08-28 11:51   ` [bug#49834] [PATCH 5/6] gnu: Add python-pep8-naming Giacomo Leidi
2021-08-28 11:51   ` [bug#49834] [PATCH 6/6] gnu: Add dynaconf Giacomo Leidi
2021-08-28 22:46 ` [bug#49834] " Sarah Morgensen
2021-08-29 22:52   ` paul
2021-08-29 22:53 ` [bug#49834] [PATCH 1/4] gnu: Add python-dotenv Giacomo Leidi
2021-08-29 22:53   ` [bug#49834] [PATCH 2/4] gnu: python-ruamel.yaml: Update to 0.17.10 Giacomo Leidi
2021-08-29 22:53   ` [bug#49834] [PATCH 3/4] gnu: Add python-dotenv-0.13.0 Giacomo Leidi
2021-08-29 22:53   ` [bug#49834] [PATCH 4/4] gnu: Add dynaconf Giacomo Leidi
2021-10-07 22:49 ` [bug#49834] [PATCH 1/7] gnu: Add python-flake8-debugger paul
2021-11-19 23:40 ` [bug#49834] gnu: Add dynaconf paul via Guix-patches via
2021-12-01 11:59   ` bug#49834: " Efraim Flashner
2021-11-19 23:41 ` [bug#49834] [PATCH 1/4] gnu: Add python-dotenv Giacomo Leidi via Guix-patches via
2021-11-19 23:41   ` [bug#49834] [PATCH 2/4] gnu: python-ruamel.yaml: Update to 0.17.10 Giacomo Leidi via Guix-patches via
2021-11-19 23:41   ` [bug#49834] [PATCH 3/4] gnu: Add python-dotenv-0.13.0 Giacomo Leidi via Guix-patches via
2021-11-19 23:41   ` [bug#49834] [PATCH 4/4] gnu: Add dynaconf Giacomo Leidi via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6567b413-0db6-5d1e-e979-7807fa086a99@autistici.org \
    --to=goodoldpaul@autistici.org \
    --cc=49834@debbugs.gnu.org \
    --cc=iskarian@mgsn.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).