[bug#45337] [PATCH] gnu: evince: Update to 3.38.0.

[bug#45337] [PATCH] gnu: evince: Update to 3.38.0.

[Michael Rohleder]

* gnu/packages/gnome.scm (evince): Update to 3.38.0.
[build-system]: Changed to meson-build-system.
[arguments]: Changed configure-flags to meson style.
Changed phase 'skip-gtk-update-icon-cache to add-after 'unpack.
[inputs]: Removed python2-dogtail, because we have no tests.
---
 gnu/packages/gnome.scm | 19 ++++++++-----------
 1 file changed, 8 insertions(+), 11 deletions(-)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index aff8f89640..bc58c227f9 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -2489,7 +2489,7 @@ forgotten when the session ends.")
 (define-public evince
   (package
     (name "evince")
-    (version "3.36.5")
+    (version "3.38.0")
     (source (origin
              (method url-fetch)
              (uri (string-append "mirror://gnome/sources/evince/"
@@ -2497,17 +2497,17 @@ forgotten when the session ends.")
                                  "evince-" version ".tar.xz"))
              (sha256
               (base32
-               "0z79jl0j9xq9wgwkfr0d1w1qrdy4447y8shs407n5srr0vixc3bg"))))
-    (build-system glib-or-gtk-build-system)
+               "0j0ry0y9qi1mlm7dcjwrmrw45s1225ri8sv0s9vb8ibm85x8kpr6"))))
+    (build-system meson-build-system)
     (arguments
-     `(#:configure-flags '("--disable-nautilus" "--enable-introspection")
+     `(#:configure-flags '("-Dnautilus=false" "-Dgtk_doc=false")
        #:phases
        (modify-phases %standard-phases
-         (add-before 'install 'skip-gtk-update-icon-cache
+         (add-after 'unpack 'skip-gtk-update-icon-cache
            ;; Don't create 'icon-theme.cache'.
            (lambda _
-             (substitute* "data/Makefile"
-               (("gtk-update-icon-cache") "true"))
+             (substitute* "meson_post_install.py"
+               (("gtk-update-icon-cache") (which "true")))
              #t)))))
     (inputs
      `(("libarchive" ,libarchive)
@@ -2536,10 +2536,7 @@ forgotten when the session ends.")
        ("shared-mime-info" ,shared-mime-info)
        ("dconf" ,dconf)
        ("libcanberra" ,libcanberra)
-       ("libsecret" ,libsecret)
-
-       ;; For tests.
-       ("dogtail" ,python2-dogtail)))
+       ("libsecret" ,libsecret)))
     (native-inputs
      `(("itstool" ,itstool)
        ("intltool" ,intltool)
-- 
2.29.2

[bug#45337] [PATCH] gnu: evince: Update to 3.38.0.

[Jonathan Brielmaier]

On 20.12.20 15:10, Michael Rohleder wrote:
> * gnu/packages/gnome.scm (evince): Update to 3.38.0.

Hi Michael, I think we usually try to update GNOME all together. Yet we
are still on GNOME 3.34 and we have a branch for
https://git.savannah.gnu.org/cgit/guix.git/log/?h=wip-gnome3.36

If you need this update for certain features/improvement, we can go. But
otherwise I think we should do updates for GNOME tools all together...

[bug#45337] [PATCH] gnu: evince: Update to 3.38.0.

[Michael Rohleder]

[-- Attachment #1: Type: text/plain, Size: 4163 bytes --]

Hi Jonathan,

Jonathan Brielmaier <jonathan.brielmaier@web.de> writes:
> Hi Michael, I think we usually try to update GNOME all together. Yet we
> are still on GNOME 3.34 and we have a branch for
> https://git.savannah.gnu.org/cgit/guix.git/log/?h=wip-gnome3.36

Oh, ok, than I close this.

I don't think this is good idea, because it would become a huge amount
of work and coordination to do it for _all_ gnome apps, libs, etc....
This means, no one likes to do it and also it would take a lot of time
which means, it becomes outdated "while on the road".
And, it takes all the "dynamics" (and fun) out of the development,
because no one would touch any gnome package.
Also, I don't think it's even clear what belongs to "GNOME" exactly:
There was a time where gimp for example was the beginning of gtk and
therefore "GNOME".  But now, it's not part of it and ok to update?!

Technicaly, I don't see why we should do it that way for leaf packages.
If they work with our current gnome version, what's the problem and what
is the rational behind this?

It might be another story for things like glib or gtk which are deeper
in the tree, but even there I don't think it's a good idea to "cluster"
them _all_ together (for no good reason), because it slows down everything.


PS:
grep 'version "3.3' gnu/packages/gnome.scm
yields:

(version "3.12.2")
    (version "3.8.1")
    (version "3.9.10")
    (version "3.34.2")
    (version "3.34.5")
    (version "3.26.1")
    (version "3.20.0")
   (version "3.32.0")
    (version "3.34.0")
   (version "3.32.1")
   (version "3.33.1")
    (version "3.32.1")
    (version "3.32.0")
   (version "3.32.3")
   (version "3.32.2")
    (version "3.30.0")
    (version "3.18.0")
    (version "3.34")
    (version "3.34.2")
    (version "3.34.0")
    (version "3.30.0")
    (version "3.34.0")
    (version "3.34.0")
    (version "3.12.0")
    (version "3.34.0")
    (version "3.36.5")
    (version "3.34.0")
    (version "3.0.1")
    (version "3.12.0")
    (version "3.34.3")
    (version "3.36.0")
    (version "3.2.6")
    (version "3.32.0")
    (version "3.22.3")
    (version "3.36.2")
    (version "3.22.0")
    (version "3.32.2")
    (version "3.36.1")
    (version "3.35.90")
    (version "3.34.1")
    (version "3.34.2")
    (version "3.26.2")
    (version "3.34.0")
    (version "3.34.1")
   (version "3.26.5")
    (version "3.22.9")
    (version "3.34.0")
    (version "3.0.27")
    (version "3.34.0")
    (version "3.38.0")
   (version "3.4.4")
   (version "3.34.1")
    (version "3.26.4")
    (version "3.38.2")
    (version "3.34.4")
    (version "3.34.2")
    (version "3.32.2")
    (version "3.32.2")
    (version "3.32.3")
    (version "3.34.2")
    (version "3.34.1")
    (version "3.32.0")
    (version "3.34.2")
    (version "3.36.0")
    (version "3.34.2")
    (version "3.0.1")
    (version "3.34.1")
    (version "3.34.2")
    (version "3.34.2")
    (version "3.34.2")
    (version "3.34.2")
    (version "3.32.0")
    (version "3.34.0")
    (version "3.34.0")
    (version "3.34.2")
   (version "3.34.0")
    (version "3.32.2")
    (version "3.34.0")
    (version "3.34.2")
    (version "3.28.1")
    (version "3.26.1")
    (version "3.34.0")
    (version "3.34.2")
    (version "3.26.1")
    (version "3.0.2")
    (version "3.34.1")
    (version "3.32.1")
    (version "3.34.1")
    (version "3.38.0")
    (version "3.99.2")
    (version "3.24.0")
    (version "3.0.2")
    (version "3.18.4")
    (version "3.37.1")
    (version "3.34.2")
    (version "3.8.2")
    (version "3.32.1")
    (version "3.35.1")
    (version "3.28")
    (version "3.38.0")
    (version "3.36.3")
    (version "3.36.6")
    (version "3.34.1")
    (version "3.4.1")
    (version "3.36.0")
    (version "3.34.0")
    (version "3.36.0")
    (version "3.36.1")
    (version "3.36.0")


-- 
Der Mensch ist die duemmste Spezies:
Er verehrt einen unsichtbaren Gott und toetet sichtbare Natur,
ohne zu wissen, dass diese Natur, die er vernichtet, dieser
unsichtbare Gott ist, den er verehrt.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 511 bytes --]

bug#45337: [PATCH] gnu: evince: Update to 3.38.0.

[Michael Rohleder]

[-- Attachment #1: Type: text/plain, Size: 100 bytes --]

bureaucracy/gentooism^Wwrong branch.

-- 
Old programmers never die, they just become managers.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 511 bytes --]

[bug#45337] [PATCH] gnu: evince: Update to 3.38.0.

[Ricardo Wurmus]

Michael Rohleder <mike@rohleder.de> writes:

> Jonathan Brielmaier <jonathan.brielmaier@web.de> writes:
>> Hi Michael, I think we usually try to update GNOME all together. Yet we
>> are still on GNOME 3.34 and we have a branch for
>> https://git.savannah.gnu.org/cgit/guix.git/log/?h=wip-gnome3.36
>
> Oh, ok, than I close this.

Don’t.  IIRC we have updated some Gnome applications independently of
Gnome before.

You only need to make sure that the application works correctly and
doesn’t have any hidden dependency on Gnome infrastructure that our
older packages don’t provide.

-- 
Ricardo