From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id INyDArokBmXrOwEAauVa8A:P1 (envelope-from ) for ; Sat, 16 Sep 2023 23:57:14 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id INyDArokBmXrOwEAauVa8A (envelope-from ) for ; Sat, 16 Sep 2023 23:57:14 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 986B335F3D for ; Sat, 16 Sep 2023 23:57:13 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=ndt4iDP6; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1694901433; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=QkdKiA52I7Hgt7jsroPqx+AsUKj7Ib1XlI65Uw6Aoy8=; b=bwXOXJ1tl/kJ3ve2+ppHTWYgtd+Ui9lOmNJUJZ9gga0xff0fCvUKPA57pbSomiGlomj/pu c8A4xaxbm6r91yhp/Ua/ord4tErGdsr5WezLErrOrR6/9+Nuiu9Ge5Kip29lVj0zE5lpR1 4fg5N6DUwVr43qKXnd4MHQGTUDMYddLgrAeCzExo9pB06mmelhUyCi4UbeC0xyLVMFAqaD 0IV640nqnR5wNVgycaznMP/poRac6FL5ZgfYAqxwdXBA0qbjsp7GA+v+coEJU5YCgI4B2G LROTLd7WKjk652ItbM3hWNlIP1BbZblQ6+Nk2OtBNRqhi40+a8AHtAfffzOYTA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1694901433; a=rsa-sha256; cv=none; b=rMtVgIElJEnMcO0BBfdXK0UUcvkUMMGsGOjbNNzAjWaPpGEvrdqJb5uWxb3gm3IjbieMEF FLNg9Ah6+KFwbpa17lO125UjLF2hk7zNKsIHhZoXNgEpOL2J0e40odwh2657zUId5s6HuZ Ft/5QDjgiaMo1xhKwtMGEQgknMhA3rm4FO+ozUPmZVAT5f/M248cmH5PCJIBZrVif/J+cw G8kXpWnSdpQm6biVIFeLQPKCk1wRph/xCE0cw8KuI/lJYM7RMQIf2wDGPfOMVVpImskSVl TRfbUX8zbNK6aDH/AMSzw9RVQqG14DdVVjTlpxcd57r92AxFJ0xbiudpfanqiA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=ndt4iDP6; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qhdHf-0005Ag-1X; Sat, 16 Sep 2023 17:56:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qhdHc-0005AH-6s for guix-patches@gnu.org; Sat, 16 Sep 2023 17:56:56 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qhdHa-0003EP-S9 for guix-patches@gnu.org; Sat, 16 Sep 2023 17:56:55 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qhdHi-0003lo-2P for guix-patches@gnu.org; Sat, 16 Sep 2023 17:57:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#63985] [PATCH v3 00/11] Service subsystem improvements Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 16 Sep 2023 21:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63985 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Bruno Victal Cc: 63985@debbugs.gnu.org, ludo@gnu.org, maxim.cournoyer@gmail.com Received: via spool by 63985-submit@debbugs.gnu.org id=B63985.169490138014437 (code B ref 63985); Sat, 16 Sep 2023 21:57:02 +0000 Received: (at 63985) by debbugs.gnu.org; 16 Sep 2023 21:56:20 +0000 Received: from localhost ([127.0.0.1]:48691 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qhdH1-0003km-PZ for submit@debbugs.gnu.org; Sat, 16 Sep 2023 17:56:20 -0400 Received: from mail-ed1-x542.google.com ([2a00:1450:4864:20::542]:54356) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qhdGy-0003kS-2y for 63985@debbugs.gnu.org; Sat, 16 Sep 2023 17:56:18 -0400 Received: by mail-ed1-x542.google.com with SMTP id 4fb4d7f45d1cf-52a5c0d949eso3889903a12.0 for <63985@debbugs.gnu.org>; Sat, 16 Sep 2023 14:56:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1694901362; x=1695506162; darn=debbugs.gnu.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=QkdKiA52I7Hgt7jsroPqx+AsUKj7Ib1XlI65Uw6Aoy8=; b=ndt4iDP6Trhc48C+RbDf7BpC73/PnLcPTNpLd2sLyzB0LHp+cpDPmc6FwMWqL6jDk7 WkLUFQXKpEr3LZRa8VymT5f19Lxia+Z+K3rMHS1wgXmCZMO/S0B179y/hq23uRM+2lxX 0rmiwS+dgsKctWF48IEAe1CZaOT2yujvCNO9hBgncKL/o+OIjmt7q5w+a5Y19KvgHA0n J9MXbQ88ivfGgO6hakkubcM3NBa17Xrmq+ooxzSsToDAEcGguu7q+ubVUJkiSwJagqoq QgKMS0kP1khL2UDFcBtr1qpbIOGiSPR9tkY5Mnk3Qe+8A1AIGvX3lDV1fW/wExYee8sD 1EXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694901362; x=1695506162; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=QkdKiA52I7Hgt7jsroPqx+AsUKj7Ib1XlI65Uw6Aoy8=; b=qvc+lslxA1OE/d6zs9FAXpDaBGIxrilT2Hwyf8T/SOuyIZmeTOYezO+cigxGTjLRju /F34m2Wvc4nQQD3r9JMyBzh8sOd4SEx0nS3Zsn4x41Is7NPuStVhR7AYtKjAqDyKiIFF nv3/vZYfug35rn6XVO2joP1pfEncbMPmX5//ODDHq5JiP+Caj/Ho6P50KtzD73hegxuB p1LtsJHVkbjJxYuSfdWzqPE0HkFl7IvGIS2rT4zdBisIwcAAZO1sJ1Oc4Sf2SuSfJ15g beiYE9bMrdAVJJktAEDYLuIUegvFXFoRzNaEMoF+3xPi9tUFvJAEO10PkA4Jjjeb9hFq W2UQ== X-Gm-Message-State: AOJu0YzPcq5buKJJyw/uufuYiB7oOdUxI0VWFX1dssX0rS/JgOjR7wbR 5yRWWk1IGkDWeMVsMPkbZA4= X-Google-Smtp-Source: AGHT+IHNsxMS9ZTYxkS3TtFFPGO0IiHrAbRsRJiQL+tZuskgvpZp9vm4ZJuyciJh2uQyAXyjz93Ngg== X-Received: by 2002:a50:fe8e:0:b0:522:c1b1:8cb0 with SMTP id d14-20020a50fe8e000000b00522c1b18cb0mr4066049edt.33.1694901362061; Sat, 16 Sep 2023 14:56:02 -0700 (PDT) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id m9-20020aa7c2c9000000b0052576969ef8sm3901803edp.14.2023.09.16.14.56.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 16 Sep 2023 14:56:01 -0700 (PDT) Message-ID: <6445e508cbc8a9f92d3a54263193936d168cd7cf.camel@gmail.com> From: Liliana Marie Prikler Date: Sat, 16 Sep 2023 23:55:59 +0200 In-Reply-To: <5613dc86-54ac-4bdb-b75a-400b1cb124bf@makinata.eu> References: <5613dc86-54ac-4bdb-b75a-400b1cb124bf@makinata.eu> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4 MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: 7.23 X-Spam-Score: 7.23 X-Migadu-Queue-Id: 986B335F3D X-Migadu-Scanner: mx0.migadu.com X-TUID: fnURJTU5FB1L Am Samstag, dem 16.09.2023 um 22:22 +0100 schrieb Bruno Victal: > Hi all, >=20 > I've been pondering about the changes here and would like to comment > on them: >=20 > On 2023-06-26 22:57, Bruno Victal wrote: > > Bruno Victal (11): > > =C2=A0 services: configuration: Simplify normalize-extra-args. > > =C2=A0 services: configuration: Use transducers within > > =C2=A0=C2=A0=C2=A0 serialize-configuration. > > =C2=A0 services: fstrim-service-type: Serialize with SRFI-171 > > transducers. > > =C2=A0 doc: Rewrite define-configuration. > > =C2=A0 services: configuration: Add serializer-options field. >=20 > I think these changes are OK on their own since they add some extra > flexibility to the serialize-configuration procedure and address a > TODO item. I'm not sure whether serializer options really add much value. You can use functional programming to define serializers for you and pass those options in a cleaner way IMHO. The documentation should be updated as the changes are made. As for the switch to SRFI 171, I'm not sure whether backwards compatibility with Guile 2.2 is a requirement somewhere; if it isn't, that change is probably fine. > > =C2=A0 services: configuration: New generic-ini module. > > =C2=A0 services: configuration: Add some commonly used predicates. >=20 > IMO I'm afraid this might be somewhat short-sighted and would be > better addressed directly in Guile by implementing SRFI-233, perhaps > by doing some adaptations to the approach taken here. Even if Guile implemented SRFI 233 now, I'm not sure we could use it tomorrow. And even once we can use SRFI 233, we can keep backwards- compatibility be re-exporting things. The question is how necessary it will be for us to maintain our own INI format writer. NetworkManager is one use case, but perhaps we have others (perhaps even in the gnome world =E2=80=93 gdm maybe?) > > =C2=A0 services: NetworkManager: Use define-configuration and generic- > > ini.>=C2=A0=C2=A0 services: NetworkManager: Prefer package over network= - > > manager. > > =C2=A0 services: NetworkManager: add log-configuration field. > > =C2=A0 services: NetworkManager: Add extra-options field. >=20 > Naturally these are no longer relevant if this generic-ini module > approach is abandoned. I think we can still upgrade this to define-configuration without a generic-ini, but see above. That being said, we can certainly split this into two series at the point you currently feel comfortable with and work from there. WDYT?