unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#59694] [PATCH] gnu: dino: Update to 0.3.1.
@ 2022-11-29 20:30 Liliana Marie Prikler
  2022-11-30 17:10 ` Jack Hill
  0 siblings, 1 reply; 3+ messages in thread
From: Liliana Marie Prikler @ 2022-11-29 20:30 UTC (permalink / raw)
  To: 59694

* gnu/packages/messaging.scm (dino): Update to 0.3.1.
[arguments]<#:configure-flags>: Add “-DUSE_SOUP3=true”.
[inputs]: Use ‘libsoup’ rather than ‘libsoup-minimal-2’.
---
 gnu/packages/messaging.scm | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
index 9927c7c323..fd7cbf921d 100644
--- a/gnu/packages/messaging.scm
+++ b/gnu/packages/messaging.scm
@@ -1375,7 +1375,7 @@ (define-public gajim-openpgp
 (define-public dino
   (package
     (name "dino")
-    (version "0.3.0")
+    (version "0.3.1")
     (source
      (origin
        (method url-fetch)
@@ -1383,11 +1383,11 @@ (define-public dino
         (string-append "https://github.com/dino/dino/releases/download/v"
                        version "/dino-" version ".tar.gz"))
        (sha256
-        (base32 "07nw275xfamczzvzps8hsnpbhzvr4qc726fx92w8ncmdag7wlw1r"))))
+        (base32 "1rs6qpkidiww805cd91q059r2lm5lzblrkyn01zz4g1mls8ghk5a"))))
     (build-system cmake-build-system)
     (outputs '("out" "debug"))
     (arguments
-     (list #:configure-flags #~(list "-DBUILD_TESTS=true")
+     (list #:configure-flags #~(list "-DBUILD_TESTS=true" "-DUSE_SOUP3=true")
            #:parallel-build? #f         ; not supported
            #:modules '((guix build cmake-build-system)
                        ((guix build glib-or-gtk-build-system) #:prefix glib-or-gtk:)
@@ -1439,7 +1439,7 @@ (define-public dino
            libgee
            libnice
            libsignal-protocol-c
-           libsoup-minimal-2
+           libsoup
            libsrtp                      ;for calls support
            pango
            qrencode
-- 
2.38.1





^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [bug#59694] [PATCH] gnu: dino: Update to 0.3.1.
  2022-11-29 20:30 [bug#59694] [PATCH] gnu: dino: Update to 0.3.1 Liliana Marie Prikler
@ 2022-11-30 17:10 ` Jack Hill
  2022-12-06 11:40   ` Christopher Baines
  0 siblings, 1 reply; 3+ messages in thread
From: Jack Hill @ 2022-11-30 17:10 UTC (permalink / raw)
  To: Liliana Marie Prikler; +Cc: 59694

[-- Attachment #1: Type: text/plain, Size: 517 bytes --]

On Tue, 29 Nov 2022, Liliana Marie Prikler wrote:

> * gnu/packages/messaging.scm (dino): Update to 0.3.1.
> [arguments]<#:configure-flags>: Add “-DUSE_SOUP3=true”.
> [inputs]: Use ‘libsoup’ rather than ‘libsoup-minimal-2’.

Hi,

I built and ran Dino 0.3.1 on x86_64, and it works well for me with no new 
problems. I was able to receive files, which presumably exercises the 
libsoup code paths (I didn't upload any files). The Guix changes look good 
to me. I did not audit upstream changes.

Best,
Jack

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [bug#59694] [PATCH] gnu: dino: Update to 0.3.1.
  2022-11-30 17:10 ` Jack Hill
@ 2022-12-06 11:40   ` Christopher Baines
  0 siblings, 0 replies; 3+ messages in thread
From: Christopher Baines @ 2022-12-06 11:40 UTC (permalink / raw)
  To: Jack Hill; +Cc: 59694-done, liliana.prikler, 59694

[-- Attachment #1: Type: text/plain, Size: 765 bytes --]


Jack Hill <jackhill@jackhill.us> writes:

> On Tue, 29 Nov 2022, Liliana Marie Prikler wrote:
>
>> * gnu/packages/messaging.scm (dino): Update to 0.3.1.
>> [arguments]<#:configure-flags>: Add “-DUSE_SOUP3=true”.
>> [inputs]: Use ‘libsoup’ rather than ‘libsoup-minimal-2’.
>
> Hi,
>
> I built and ran Dino 0.3.1 on x86_64, and it works well for me with no
> new problems. I was able to receive files, which presumably exercises
> the libsoup code paths (I didn't upload any files). The Guix changes
> look good to me. I did not audit upstream changes.

This also looks good to me. I didn't spot that this was submitted by
Liliana who has commit access, so I ended up pushing this as
d8c8a2987a6709f8a9be007754b5884f189f61f7.

Chris

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-12-06 11:44 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-29 20:30 [bug#59694] [PATCH] gnu: dino: Update to 0.3.1 Liliana Marie Prikler
2022-11-30 17:10 ` Jack Hill
2022-12-06 11:40   ` Christopher Baines

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).