A v2 patch with the suggestions applied is attached. Liliana Marie Prikler schreef op ma 10-01-2022 om 20:43 [+0100]: > Hi, > > Am Montag, dem 10.01.2022 um 15:27 +0000 schrieb Maxime Devos: > > For , > > I'd like to be able to reference some section (not specialised > > for Minetest packages, instead more general) explaining when > > and when not to use git tags/commits. > Generally LGTM. > > > +not tag releases at all, in this case commits are unavoidable. In a > > +very few cases (@pxref{Version Numbers}), Guix intentionally uses a > "In a very few cases" looks like a typo. "In few cases" or "In some > exceptional cases" would work well. ‘In some exceptional cases’ looks better to me, applied. > > +Commits make reviewing somewhat trickier, because the reviewer has > > to > > +verify that that the commit actually corresponds to the package > > version. > I'd also add a line regarding the difficulty to verify that a commit > did once belong to a tag as a future reader, but I'm not sure what > exactly to advise here and how. > Done: ‘Likewise, commits make it more difficult for a future reader to verify that a commit did once correspond to a version tag’. > In the particular case of minetest, we > have an external map of "tags" to commits that can be queried, but for > most repos I fear the tags would simply be lost to time. Here "tags" = releases on content.minetest.net, and not Git tags? > > I'm not familiar with "git describe", so the documentation > > doesn't tell when to use "git describe"-style > > tag-number of commits-commit strings. > That's a general question that has not reached a conclusion yet. IIRC > the goal was to make tags more robust by replacing them with git- > describe like tags. This would also make it easier to port between > revisioned commit and tagged one, since one would have to let-bind > commit either way. FWIW, the git updater in (guix upstream) might need to be modified to support the "git describe" style in commit fields, and a linter to verify that the tag+number corresponds to the commit (to avoid some ‘tricking peer review’ issues), but otherwise this seems rather nice to me. I didn't investigate closely though. Greetings, Maxime.