From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id eEQNLAdXk2DARwAAgWs5BA (envelope-from ) for ; Thu, 06 May 2021 04:40:07 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id aB2oJwdXk2CmAwAAB5/wlQ (envelope-from ) for ; Thu, 06 May 2021 02:40:07 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 577D41A85A for ; Thu, 6 May 2021 04:40:07 +0200 (CEST) Received: from localhost ([::1]:37532 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1leTvq-0003Eq-HY for larch@yhetil.org; Wed, 05 May 2021 22:40:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36446) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1leTvm-0003Ek-DR for guix-patches@gnu.org; Wed, 05 May 2021 22:40:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:52642) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1leTvm-00019y-4u for guix-patches@gnu.org; Wed, 05 May 2021 22:40:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1leTvm-0007RI-1M for guix-patches@gnu.org; Wed, 05 May 2021 22:40:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#48220] [PATCH] gnu: xfce4-session: Add xset to propagated-inputs. Resent-From: Brendan Tildesley Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 06 May 2021 02:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48220 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 48220@debbugs.gnu.org Received: via spool by 48220-submit@debbugs.gnu.org id=B48220.162026875128582 (code B ref 48220); Thu, 06 May 2021 02:40:01 +0000 Received: (at 48220) by debbugs.gnu.org; 6 May 2021 02:39:11 +0000 Received: from localhost ([127.0.0.1]:35952 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leTux-0007Qw-F6 for submit@debbugs.gnu.org; Wed, 05 May 2021 22:39:11 -0400 Received: from mout-p-101.mailbox.org ([80.241.56.151]:21842) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leTuv-0007Qq-7r for 48220@debbugs.gnu.org; Wed, 05 May 2021 22:39:10 -0400 Received: from smtp2.mailbox.org (smtp2.mailbox.org [80.241.60.241]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-101.mailbox.org (Postfix) with ESMTPS id 4FbHpH3z8NzQk20; Thu, 6 May 2021 04:39:03 +0200 (CEST) X-Virus-Scanned: amavisd-new at heinlein-support.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brendan.scot; s=MBO0001; t=1620268741; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8C+BiHavEy6rD6+a4VDg/RML+exW7U09fx2cJmtm+GY=; b=s9QxxFi/UXguLEi4SDBGDEKBsmQBEraOCFBpUbis9rUO/U4dp6qGLlh4r3lxg7iEdRinPP 0fVlHnyJyGETU3w4lIUZHQMijvld3BtcC4CfhDR5FOilr00/1+9cM6xzdtHTSfMoxKgsoR gdhcQFtgDIK7+JGJUvPyu6hxBRsWJBkDD7abABTt0RXH4t2pNr4LdeDnZjOR0CdwI3+0dJ IVbDseUkuPrOiU/iVJCSMbxKQS7vRzfW28yyD1m/ZPVLvfw2HZgVdxaVkk3Pjy/SjF3Ddb VqmOKQ2gVVhASPXZIuPY8jJ1Plu86TDkDCBvqaJIz74qd/r367VO1AU99OyRBQ== Received: from smtp2.mailbox.org ([80.241.60.241]) by spamfilter02.heinlein-hosting.de (spamfilter02.heinlein-hosting.de [80.241.56.116]) (amavisd-new, port 10030) with ESMTP id XfJoPkIOdQ6Q; Thu, 6 May 2021 04:38:59 +0200 (CEST) Date: Thu, 6 May 2021 04:38:58 +0200 (CEST) From: Brendan Tildesley Message-ID: <615974577.179836.1620268738791@office.mailbox.org> In-Reply-To: <87v97xjoux.fsf@gnu.org> References: <20210504092051.24383-1-mail@brendan.scot> <87v97xjoux.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_179835_493377898.1620268738709" X-Priority: 3 Importance: Normal X-MBO-SPAM-Probability: X-Rspamd-Score: -6.17 / 15.00 / 15.00 X-Rspamd-Queue-Id: 3C4B017E8 X-Rspamd-UID: aa6372 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1620268807; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=8C+BiHavEy6rD6+a4VDg/RML+exW7U09fx2cJmtm+GY=; b=dTggB/RMQHPdDHjD+7JWXcMClRSmUHDw7WkaTKsYrif13bnD745AoPyEwnx0ucZcWt952T K/Y/wSjx/ORLCYiJrKYT+fhB9JAT7xtXqn5HLCuSu+WFo60vbQG+7MHQNMHiLKd75O6m5k d4OWU4SI0L58XSEWpoIhSk0Ua6stzpMcXCA9GOKIDlR3WJXuA/iatSE7z3Nu+sAVsL6U4h YYAOfcjijHkW471AHvhRB8aoG0z/vLlt3zVgR43yLzlawDOijFlwBAP3DByYeL86P1sgk+ rLQ8ELXgNfdsmC913xDW+tpGeWKnqKD3atgxVJPF2Hz8cK2iUBN08kuS0g7P+w== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1620268807; a=rsa-sha256; cv=none; b=hWO4LeBxZt7AUe70qNbhZ76AZaqXZ8bCufNIDZX6ZFHbPhRHUvyM/6PLf+z2wEp4P48XV8 X0wOBiR8ct3jm1wGII7N3ioMbsIgImv3UUNk/jzLsjPmyuDdJhDen5L5V4NW4UidDHpD49 F7S0NZyfPK9pceY191XfKe8fiiIDjIFSjjhUcRurfE3C4ILnX6J9eCRQEd8Yhcwt7ymoVj VjnfQm6XeXzoxkKz8FiZANLO4iv4AI7gHkucVdy3P9xSPCGYpcUCfR3Rznc/St9I6I2CrX kxOZqmeXfXwi/DKbuSJPCfC+zoMfIFbzAyePhE9PrBbXsow980fZR7gmfISWXw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=brendan.scot header.s=MBO0001 header.b="s9QxxFi/"; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: 1.14 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=brendan.scot header.s=MBO0001 header.b="s9QxxFi/"; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 577D41A85A X-Spam-Score: 1.14 X-Migadu-Scanner: scn0.migadu.com X-TUID: HMNKCXOiv1AC ------=_Part_179835_493377898.1620268738709 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable > On 05/05/2021 3:23 PM Ludovic Court=C3=A8s wrote: >=20 > =20 > Hi Brendan, >=20 > Brendan Tildesley skribis: >=20 > > * gnu/packages/xfce.scm (xfce4-session):[propagated-inputs]: Add xset s= o > > that xflock4 can turn off the monitor. >=20 > Can=E2=80=99t we instead patch =E2=80=98scripts/xflock4=E2=80=99 so that = it refers to =E2=80=98xset=E2=80=99 by > its absolute file name? >=20 I can. It felt weird just patching one command and not others though. > However, my understanding is that the xset code is already a fallback: >=20 > --8<---------------cut here---------------start------------->8--- > # else run another access locking utility, if installed > for lock_cmd in \ > "xlock -mode blank" \ > "slock" > do > set -- $lock_cmd > if command -v -- $1 >/dev/null 2>&1; then > $lock_cmd >/dev/null 2>&1 & > =09# turn off display backlight: > =09xset dpms force off > exit > fi > done > --8<---------------cut here---------------end--------------->8--- >=20 > Probably we should ensure the first =E2=80=98for=E2=80=99 loop works as e= xpected. > Perhaps we need to replace =E2=80=98xfce4-screensaver-command=E2=80=99 by= its absolute > file name there. >=20 Currently xfce4-screensaver is not installed in the xfce package at all by = default, so it isn't used. I could add it, but for me it was glitchy/flickering and = I would keep=20 clearing the password as I was entering it so I couldn't log back in. It ev= en does it in a VM. I do have a recent amd graphics card with proprietary linux though= , my computer can't boot otherwise :(. If you run guix environment --ad-hoc xfce4-screensaver then xfce4-screensaver &; xfce4-screensaver-command --lock does it work for you? I'm not sure what is best, should we be maximal and include xfce4-screensav= er in the xfce package, or be minimal and make people have to install it manually? > WDYT? >=20 > Thanks, > Ludo=E2=80=99. ------=_Part_179835_493377898.1620268738709 Content-Type: text/x-patch; charset=ISO-8859-1; name=0001-gnu-xfce4-session-Add-xset-to-propagated-inputs.patch Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=0001-gnu-xfce4-session-Add-xset-to-propagated-inputs.patch X-Part-Id: d6d958cff74c452c9c1165769ec3bd2e RnJvbSBlMWU5NjhmMjEzNzRiMmMxMjVkMWZjMTM0OGE1MzFmMTZmYWM2YjRkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBCcmVuZGFuIFRpbGRlc2xleSA8bWFpbEBicmVuZGFuLnNjb3Q+ CkRhdGU6IFR1ZSwgMjcgQXByIDIwMjEgMTU6MzQ6NTAgKzEwMDAKU3ViamVjdDogW1BBVENIXSBn bnU6IHhmY2U0LXNlc3Npb246IEFkZCB4c2V0IHRvIHByb3BhZ2F0ZWQtaW5wdXRzLgoKKiBnbnUv cGFja2FnZXMveGZjZS5zY20gKHhmY2U0LXNlc3Npb24pOltwcm9wYWdhdGVkLWlucHV0c106IEFk ZCB4c2V0IHNvCnRoYXQgeGZsb2NrNCBjYW4gdHVybiBvZmYgdGhlIG1vbml0b3IuCi0tLQogZ251 L3BhY2thZ2VzL3hmY2Uuc2NtIHwgMiArKwogMSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygr KQoKZGlmZiAtLWdpdCBhL2dudS9wYWNrYWdlcy94ZmNlLnNjbSBiL2dudS9wYWNrYWdlcy94ZmNl LnNjbQppbmRleCA5NjU1ZDhjY2Y3Li5mMWU0MGE5NGI4IDEwMDY0NAotLS0gYS9nbnUvcGFja2Fn ZXMveGZjZS5zY20KKysrIGIvZ251L3BhY2thZ2VzL3hmY2Uuc2NtCkBAIC03MTgsNiArNzE4LDgg QEAgeW91ciBzeXN0ZW0gaW4gY2F0ZWdvcmllcywgc28geW91IGNhbiBxdWlja2x5IGZpbmQgYW5k IGxhdW5jaCB0aGVtLiIpCiAgICAgICAgKCJsaWJzbSIgLGxpYnNtKQogICAgICAgICgibGlid25j ayIgLGxpYnduY2spCiAgICAgICAgKCJsaWJ4ZmNlNHVpIiAsbGlieGZjZTR1aSkpKQorICAgIChw cm9wYWdhdGVkLWlucHV0cworICAgICBgKCgieHNldCIgLHhzZXQpKSkKICAgICAoaG9tZS1wYWdl ICJodHRwczovL3d3dy54ZmNlLm9yZy8iKQogICAgIChzeW5vcHNpcyAiWGZjZSBzZXNzaW9uIG1h bmFnZXIiKQogICAgIChkZXNjcmlwdGlvbgotLSAKMi4zMS4xCgo= ------=_Part_179835_493377898.1620268738709 Content-Type: text/x-patch; charset=ISO-8859-1; name=0001-gnu-xfce4-session-Allow-xflock4-to-use-xset.patch Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=0001-gnu-xfce4-session-Allow-xflock4-to-use-xset.patch X-Part-Id: 6cc49077d11b49858d69583e299352ff RnJvbSBlZDY2Y2Y1MGEzYjkyOTRlZmZjOGJiYWUwNGIwZjI1NjRiZDU1YzEwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBCcmVuZGFuIFRpbGRlc2xleSA8bWFpbEBicmVuZGFuLnNjb3Q+ CkRhdGU6IFRodSwgNiBNYXkgMjAyMSAxMjozNDo1NSArMTAwMApTdWJqZWN0OiBbUEFUQ0hdIGdu dTogeGZjZTQtc2Vzc2lvbjogQWxsb3cgeGZsb2NrNCB0byB1c2UgeHNldC4KCiogZ251L3BhY2th Z2VzL3hmY2Uuc2NtICh4ZmNlNC1zZXNzaW9uKToKW2lucHV0c106IEFkZCB4c2V0LgpbYXJndW1l bnRzXTogQWRkIGEgcGhhc2UgdG8gdXNlIGV4YWN0IHN0b3JlIHBhdGggdG8geHNldCBpbiB4Zmxv Y2s0LgotLS0KIGdudS9wYWNrYWdlcy94ZmNlLnNjbSB8IDExICsrKysrKysrKy0tCiAxIGZpbGUg Y2hhbmdlZCwgOSBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2du dS9wYWNrYWdlcy94ZmNlLnNjbSBiL2dudS9wYWNrYWdlcy94ZmNlLnNjbQppbmRleCA4YWEyNzcw ZWU4Li4xNjQ2MzFjZjRkIDEwMDY0NAotLS0gYS9nbnUvcGFja2FnZXMveGZjZS5zY20KKysrIGIv Z251L3BhY2thZ2VzL3hmY2Uuc2NtCkBAIC03MDcsNyArNzA3LDEzIEBAIHlvdXIgc3lzdGVtIGlu IGNhdGVnb3JpZXMsIHNvIHlvdSBjYW4gcXVpY2tseSBmaW5kIGFuZCBsYXVuY2ggdGhlbS4iKQog ICAgICAgIChsaXN0IChzdHJpbmctYXBwZW5kICItLXdpdGgteHNlc3Npb24tcHJlZml4PSIgJW91 dHB1dCkpCiAgICAgICAgOzsgRGlzYWJsZSBpY29uIGNhY2hlIHVwZGF0ZS4KICAgICAgICAjOm1h a2UtZmxhZ3MKLSAgICAgICAnKCJndGtfdXBkYXRlX2ljb25fY2FjaGU9dHJ1ZSIpKSkKKyAgICAg ICAnKCJndGtfdXBkYXRlX2ljb25fY2FjaGU9dHJ1ZSIpCisgICAgICAgIzpwaGFzZXMKKyAgICAg ICAobW9kaWZ5LXBoYXNlcyAlc3RhbmRhcmQtcGhhc2VzCisgICAgICAgICAoYWRkLWFmdGVyICd1 bnBhY2sgJ3BhdGNoLXhmbG9jaworICAgICAgICAgICAobGFtYmRhIF8KKyAgICAgICAgICAgICAo c3Vic3RpdHV0ZSogInNjcmlwdHMveGZsb2NrNCIKKyAgICAgICAgICAgICAgICgoInhzZXQiKSAo d2hpY2ggInhzZXQiKSkpKSkpKSkKICAgICAobmF0aXZlLWlucHV0cwogICAgICBgKCgicGtnLWNv bmZpZyIgLHBrZy1jb25maWcpCiAgICAgICAgKCJpbnRsdG9vbCIgLGludGx0b29sKSkpCkBAIC03 MTcsNyArNzIzLDggQEAgeW91ciBzeXN0ZW0gaW4gY2F0ZWdvcmllcywgc28geW91IGNhbiBxdWlj a2x5IGZpbmQgYW5kIGxhdW5jaCB0aGVtLiIpCiAgICAgICAgKCJwb2xraXQiICxwb2xraXQpCiAg ICAgICAgKCJsaWJzbSIgLGxpYnNtKQogICAgICAgICgibGlid25jayIgLGxpYnduY2spCi0gICAg ICAgKCJsaWJ4ZmNlNHVpIiAsbGlieGZjZTR1aSkpKQorICAgICAgICgibGlieGZjZTR1aSIgLGxp YnhmY2U0dWkpCisgICAgICAgKCJ4c2V0IiAseHNldCkpKQogICAgIChob21lLXBhZ2UgImh0dHBz Oi8vd3d3LnhmY2Uub3JnLyIpCiAgICAgKHN5bm9wc2lzICJYZmNlIHNlc3Npb24gbWFuYWdlciIp CiAgICAgKGRlc2NyaXB0aW9uCi0tIAoyLjMxLjEKCg== ------=_Part_179835_493377898.1620268738709--