From: Carl Dong <contact@carldong.me>
To: Efraim Flashner <efraim@flashner.co.il>
Cc: Michael Ford <fanquake@gmail.com>,
64100@debbugs.gnu.org, lists@coryfields.com,
Cory Fields <cory-nospam-@coryfields.com>
Subject: [bug#64100] [PATCH] gnu: llvm: make clang-make-toolchain public
Date: Sun, 2 Jul 2023 13:16:21 -0400 [thread overview]
Message-ID: <6115F369-B423-4549-91E3-65C7099BB763@carldong.me> (raw)
In-Reply-To: <ZI6mTZ56BzJR_Tla@3900XT>
[-- Attachment #1: Type: text/plain, Size: 1912 bytes --]
Pushed to master as 39a3251feb2559e0b448f25671c26b9dd3318108
I’m not sure I can close this ticket as I didn’t open it.
–Carl
> On Jun 18, 2023, at 2:38 AM, Efraim Flashner <efraim@flashner.co.il> wrote:
>
> On Fri, Jun 16, 2023 at 04:40:22PM -0400, Carl Dong wrote:
>> Simple enough and matches gcc-make-toolchain.
>>
>> Allows for more complex manifests and packages to be built with a custom clang toolchains without forking Guix.
>>
>> I think I still have push rights so I’ll push in 2 weeks if there are no other objections (this shouldn’t trigger any rebuilds at all).
>
> Sounds good to me
>
>>> On Jun 15, 2023, at 2:05 PM, lists@coryfields.com wrote:
>>>
>>> From: Cory Fields <cory-nospam-@coryfields.com>
>>>
>>> Matches gcc-make-toolchain. Allow for llvm build to be patched.
>>>
>>> * gnu/packages/llvm.scm: make clang-make-toolchain public
>>>
>>> Signed-off-by: Cory Fields <cory-nospam-@coryfields.com>
>>> ---
>>> gnu/packages/llvm.scm | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/gnu/packages/llvm.scm b/gnu/packages/llvm.scm
>>> index f59c8e9592..6d83313af6 100644
>>> --- a/gnu/packages/llvm.scm
>>> +++ b/gnu/packages/llvm.scm
>>> @@ -502,7 +502,7 @@ code analysis tools.")
>>> "znver3")
>>> '())))))
>>>
>>> -(define (make-clang-toolchain clang libomp)
>>> +(define-public (make-clang-toolchain clang libomp)
>>> (package
>>> (name (string-append (package-name clang) "-toolchain"))
>>> (version (package-version clang))
>>>
>>> base-commit: 6e1215fb9c03ccb4a2d4440990aee5a66a935268
>>> --
>>> 2.25.1
>>>
>>>
>>>
>>>
>>
>
> --
> Efraim Flashner <efraim@flashner.co.il> רנשלפ םירפא
> GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351
> Confidentiality cannot be guaranteed on emails sent or received unencrypted
[-- Attachment #2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2023-07-02 17:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-15 18:05 [bug#64100] [PATCH] gnu: llvm: make clang-make-toolchain public lists
2023-06-16 20:40 ` Carl Dong
2023-06-18 6:38 ` Efraim Flashner
2023-07-02 17:16 ` Carl Dong [this message]
2023-06-19 13:50 ` Michael Ford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6115F369-B423-4549-91E3-65C7099BB763@carldong.me \
--to=contact@carldong.me \
--cc=64100@debbugs.gnu.org \
--cc=cory-nospam-@coryfields.com \
--cc=efraim@flashner.co.il \
--cc=fanquake@gmail.com \
--cc=lists@coryfields.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).