From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id WCaCH1qMhmCm7QAAgWs5BA (envelope-from ) for ; Mon, 26 Apr 2021 11:48:10 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id ICgRGlqMhmBwOgAA1q6Kng (envelope-from ) for ; Mon, 26 Apr 2021 09:48:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 414DB117B5 for ; Mon, 26 Apr 2021 11:48:10 +0200 (CEST) Received: from localhost ([::1]:38908 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1laxqb-0007Zj-FT for larch@yhetil.org; Mon, 26 Apr 2021 05:48:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44154) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1laxqU-0007ZJ-F6 for guix-patches@gnu.org; Mon, 26 Apr 2021 05:48:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:33069) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1laxqU-00014t-6n for guix-patches@gnu.org; Mon, 26 Apr 2021 05:48:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1laxqU-0003Do-4G for guix-patches@gnu.org; Mon, 26 Apr 2021 05:48:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#48028] [PATCH wip-gnome 5/8] gnu: libsoup: Add missing argument and input. Resent-From: Leo Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 26 Apr 2021 09:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48028 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Raghav Gururajan , 48028@debbugs.gnu.org Cc: Mark H Weaver Received: via spool by 48028-submit@debbugs.gnu.org id=B48028.161943044112335 (code B ref 48028); Mon, 26 Apr 2021 09:48:02 +0000 Received: (at 48028) by debbugs.gnu.org; 26 Apr 2021 09:47:21 +0000 Received: from localhost ([127.0.0.1]:44615 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1laxpo-0003Ct-P4 for submit@debbugs.gnu.org; Mon, 26 Apr 2021 05:47:20 -0400 Received: from mailrelay.tugraz.at ([129.27.2.202]:19475) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1laxpn-0003Cl-6O for 48028@debbugs.gnu.org; Mon, 26 Apr 2021 05:47:20 -0400 Received: from nijino.local (194-96-9-9.adsl.highway.telekom.at [194.96.9.9]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4FTKn0422kz3x76; Mon, 26 Apr 2021 11:47:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1619430436; bh=Rx4Ys4sYg6f8UFZYcoNYhleHjKmrVlurV+ISZkOHu3Q=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=dQADJ/Dz7Xadksqq1oqATcCpNXSS7jrMFGP5zOck7CgjLBI4hvDmwypqF3fg1T13O Lx/nelWLg+2tIQ4Xpedo4sD16rxN8tzgKTYhJdsCnIXpr7Pa/WG9RSJCQNZmfDW0ay 649mchaMCJsD6YqbImnr2wGX0Cgy8GfUD49qx86o= Message-ID: <610e1f33a099e2b8fad8f5df21447f9108082a9c.camel@student.tugraz.at> From: Leo Prikler Date: Mon, 26 Apr 2021 11:47:15 +0200 In-Reply-To: <88a82777-3c12-58d6-912f-196ea150f772@raghavgururajan.name> References: <20210426081145.28926-1-rg@raghavgururajan.name> <20210426081145.28926-5-rg@raghavgururajan.name> <73660fda850714bb152afc392df78addecd29932.camel@student.tugraz.at> <88a82777-3c12-58d6-912f-196ea150f772@raghavgururajan.name> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.117 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -4.00 Authentication-Results: aspmx1.migadu.com; none X-Migadu-Queue-Id: 414DB117B5 X-Spam-Score: -4.00 X-Migadu-Scanner: scn0.migadu.com X-TUID: yBXzrsIkh65w Am Montag, den 26.04.2021, 05:28 -0400 schrieb Raghav Gururajan: > Hi Leo! > > > This looks like it could be its own patch were it not for the fact, > > that samba needs to be added as well (what for?) > > I have split them into two patches and added comment, in v3. > > > That doesn't sound very sure to me. Why are you wrapping binaries > > and/or compiling schemas? > > It is mainly for compiling schemas, as libsoup doesn't have binaries > to > wrap. But I just now realized that there is no > `[out]/share/glib-2.0/schemas` either. So I removed this in v3. > > > Careful with the indentation. > > Ah, good catch. I have fixed it in v3. v3 06/07 LGTM, but could in my opinon be merged into a single patch with the line: "gnu: libsoup: Add missing inputs." or perhaps "gnu: libsoup: Adjust inputs". I've CC'd Mark Weaver to hear their input. Regards, Leo