From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:bcc0::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id QMl3H9GzXWDUkQAAgWs5BA (envelope-from ) for ; Fri, 26 Mar 2021 11:13:37 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id YDyBGdGzXWA9UgAAB5/wlQ (envelope-from ) for ; Fri, 26 Mar 2021 10:13:37 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9CEC723BF5 for ; Fri, 26 Mar 2021 11:13:36 +0100 (CET) Received: from localhost ([::1]:60654 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lPjTD-0006ld-Q7 for larch@yhetil.org; Fri, 26 Mar 2021 06:13:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56222) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lPjSg-0006kD-0A for guix-patches@gnu.org; Fri, 26 Mar 2021 06:13:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:57185) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lPjSf-0004ME-Ob for guix-patches@gnu.org; Fri, 26 Mar 2021 06:13:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lPjSf-00012v-IO for guix-patches@gnu.org; Fri, 26 Mar 2021 06:13:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#47069] [PATCH] etc: Run pre-push make in guix environment. Resent-From: Leo Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 26 Mar 2021 10:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47069 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: zimoun , Tobias Geerinckx-Rice Cc: 47069@debbugs.gnu.org Received: via spool by 47069-submit@debbugs.gnu.org id=B47069.16167535273953 (code B ref 47069); Fri, 26 Mar 2021 10:13:01 +0000 Received: (at 47069) by debbugs.gnu.org; 26 Mar 2021 10:12:07 +0000 Received: from localhost ([127.0.0.1]:40497 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lPjRm-00011h-W6 for submit@debbugs.gnu.org; Fri, 26 Mar 2021 06:12:07 -0400 Received: from mailrelay.tugraz.at ([129.27.2.202]:46685) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lPjRk-00011U-FZ for 47069@debbugs.gnu.org; Fri, 26 Mar 2021 06:12:05 -0400 Received: from nijino.local (194-96-13-79.adsl.highway.telekom.at [194.96.13.79]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4F6Hnr0Yhjz1LZW9; Fri, 26 Mar 2021 11:11:59 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 mailrelay.tugraz.at 4F6Hnr0Yhjz1LZW9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1616753520; bh=SQTdHjk6AbZv5DaYKv6yj7bVZnBjS+DTOt64CafyeKo=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=Zcf+oAchUilotFcz8JMtrGbbSUcELJuE1aOQhnfHHVo6p2ebCvgAKwD1jbKJrQaV6 twRbHafE/iL6Gw+l6rLUAcwUj82htz27Q1PblJP+G9yvlFzrmsf+GDFvqbwVaZJAff L07iizL+pKOhxAAqtSo0Vy9TitJ6Oecvn64V6Z3A= Message-ID: <60a9423555bdb4202c8684d3a5b5780b13422599.camel@student.tugraz.at> From: Leo Prikler Date: Fri, 26 Mar 2021 11:11:59 +0100 In-Reply-To: <86lfaaba2m.fsf@gmail.com> References: <20210311144257.4203-1-me@tobias.gr> <86lfaaba2m.fsf@gmail.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.117 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1616753617; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=SQTdHjk6AbZv5DaYKv6yj7bVZnBjS+DTOt64CafyeKo=; b=cCmPKhBz5SxxUUttRcAQrFCtC2fvmztOa7qd6mtjVRmr9AuqXNPOzby+HyMDx9SoxGqwQq LnCZIF/WM/ZNsN34JWUdycVd0LzGo6ulT5NtrApkI8OtE26ncfg9NI9T0vQ2wztwN0ArEW y5lUlHY1Xr6mL+G/iNQHNunmdR3Lz8+7iOhWTRJkFCsLzU241c38DFkuHUGwGrKSBxo3tu ZNYvNm/H27wu60E9ND/Sx6/aueOaoPKc0yExFt6n30d7Oi0bn7Yp3Q2tIEMwcQ6ANPGwTR Uvp+z52DcdGoc9lmJxIWYuapQ3FC9pBDcUo44E73MeHvEGAnFXMzYRCtN8ND9w== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1616753617; a=rsa-sha256; cv=none; b=Bzi9DgdtEid5zsvincicAhUSmBbcMiITGCSzt7zE295lNoKpND4WkBigrNlVad0q++jjJm CwDz1v7VatNs7U9XLGmQnW9tswWdGWpqxQW7Ow94JDqaPL7f5f+6CUykhgJ03LVgBow8HZ 0HkBdGmBiVqNRHk3NKYzczVNYQs9wI0ZUBFEGCnN6puCcTZ65BHCzlXrBxMy6Ga5SCmMAH 5B1SX9p1gKnk3AAymEF1xFYR4KGtA2LqpyWDXaa1Syo9ewVrdjkFnXhwi6HjWvevRfkN1H QL1GAGOgHQ6S2I198tHHSELdmdUUs1az0xD91FxlvcA1hZuottXK4N0PwnYi/A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tugraz.at header.s=mailrelay header.b=Zcf+oAch; dmarc=fail reason="SPF not aligned (relaxed)" header.from=student.tugraz.at (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.32 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tugraz.at header.s=mailrelay header.b=Zcf+oAch; dmarc=fail reason="SPF not aligned (relaxed)" header.from=student.tugraz.at (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 9CEC723BF5 X-Spam-Score: -1.32 X-Migadu-Scanner: scn0.migadu.com X-TUID: JTbt34YYr8dr Am Freitag, den 26.03.2021, 09:20 +0100 schrieb zimoun: > Hi Tobias, > > On Thu, 11 Mar 2021 at 15:42, Tobias Geerinckx-Rice > wrote: > > * etc/git/pre-push: Exec make in a guix development environment. > > --- > > The pre-push assumes you have make installed, which I didn't. > > How do you rebuild Guix before pushing? If that's a problem for the script, you could add an explicit 'all' target. That said, I think, that many developers (myself included), who would suffer from the problem mentioned by Tobias already run 'git push' inside a guix environment. I know I do. @Tobias: would it make sense to detect that case (via GUIX_ENVIRONMENT) and only optionally construct the guix environment? Regards, Leo