From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id COEyDLV/Vl8fSQAA0tVLHw (envelope-from ) for ; Mon, 07 Sep 2020 18:45:09 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id mLI5CLV/Vl9XYQAAB5/wlQ (envelope-from ) for ; Mon, 07 Sep 2020 18:45:09 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 88A089403C9 for ; Mon, 7 Sep 2020 18:45:08 +0000 (UTC) Received: from localhost ([::1]:56016 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kFM8Z-0005wF-6j for larch@yhetil.org; Mon, 07 Sep 2020 14:45:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47044) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kFM8U-0005vy-JE for guix-patches@gnu.org; Mon, 07 Sep 2020 14:45:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:39291) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kFM8U-0007JA-AI for guix-patches@gnu.org; Mon, 07 Sep 2020 14:45:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kFM8U-0002L8-7T for guix-patches@gnu.org; Mon, 07 Sep 2020 14:45:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#43219] [PATCH] gnu: Handle nfs-root device strings. Resent-From: Stefan Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 07 Sep 2020 18:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43219 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Danny Milosavljevic Cc: 43219@debbugs.gnu.org Received: via spool by 43219-submit@debbugs.gnu.org id=B43219.15995042878963 (code B ref 43219); Mon, 07 Sep 2020 18:45:02 +0000 Received: (at 43219) by debbugs.gnu.org; 7 Sep 2020 18:44:47 +0000 Received: from localhost ([127.0.0.1]:50837 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFM8F-0002KU-8B for submit@debbugs.gnu.org; Mon, 07 Sep 2020 14:44:47 -0400 Received: from mx009.vodafonemail.xion.oxcs.net ([153.92.174.39]:18400) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFM8D-0002KG-CM for 43219@debbugs.gnu.org; Mon, 07 Sep 2020 14:44:46 -0400 Received: from vsmx002.vodafonemail.xion.oxcs.net (unknown [192.168.75.192]) by mta-6-out.mta.xion.oxcs.net (Postfix) with ESMTP id B9E63604D95; Mon, 7 Sep 2020 18:44:38 +0000 (UTC) Received: from macbook-pro.kuh-wiese.my-router.de (unknown [178.5.77.113]) by mta-6-out.mta.xion.oxcs.net (Postfix) with ESMTPA id 41F53604260; Mon, 7 Sep 2020 18:44:34 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) From: Stefan In-Reply-To: <6354A850-CD6B-43EC-8DFA-3B1F172C935B@vodafonemail.de> Date: Mon, 7 Sep 2020 20:44:33 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: <6028D7D4-E880-4E45-8D5B-6FDE196809CD@vodafonemail.de> References: <4D0B1280-3FB5-48E5-B985-24773F966618@vodafonemail.de> <20200907110552.0bdef27e@scratchpost.org> <6354A850-CD6B-43EC-8DFA-3B1F172C935B@vodafonemail.de> X-Mailer: Apple Mail (2.3124) X-VADE-STATUS: LEGIT X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -0.51 X-TUID: 7pZCPJSp4xq0 Hi Danny! > However, the grub.cfg is loaded via TFTP as well, so root must be = preset to =E2=80=98(tftp)=E2=80=99 or even =E2=80=98(http)=E2=80=99 due = to DHCP options. So omitting the search command could be enough and even = allow the use of HTTP. >=20 > It could also be possible to keep the =E2=80=98search =E2=80=94file=E2=80= =99 command, if it does not produce an error. >=20 > I=E2=80=99ll check that.=20 I think we should use that change. + ((? (lambda (device) + (and (string? device) (string-contains device ":/"))) = nfs-uri) + "set root=3D(tftp)") The point is the following: It is possible that GRUB got loaded from a = local storage and that the current system is also on a local storage. = Then the root variable is set to some =E2=80=98(hd0,1)=E2=80=99 or = similar. If you then select to boot an older system generation or a custom menu = entry, which is using TFTP and NFS, then the root variable has to be = changed to =E2=80=98(tftp)=E2=80=99. Bye Stefan