From: Liliana Marie Prikler <liliana.prikler@gmail.com>
To: Kaelyn <kaelyn.alexi@protonmail.com>
Cc: 61067@debbugs.gnu.org
Subject: [bug#61067] [PATCH 2/3] gnu: wine: Build more reproducibly.
Date: Thu, 26 Jan 2023 22:09:07 +0100 [thread overview]
Message-ID: <5f9118b2e770ad5e9e6d38249de08dddf1ea0fef.camel@gmail.com> (raw)
In-Reply-To: <IVMKobpHbzO-lGgDU8JigL3TdYcep83mYRuBOMf8TpUNSYDsyLPjsHKR1EgSH6up7imRuxQkO-8Lzo8gHE2RQ3vL1rq5evkgsFwkvnnd0bw=@protonmail.com>
Am Donnerstag, dem 26.01.2023 um 20:46 +0000 schrieb Kaelyn:
> ------- Original Message -------
> On Thursday, January 26th, 2023 at 7:28 PM, Liliana Marie Prikler
> <liliana.prikler@gmail.com> wrote:
>
>
> >
> >
> > Hi,
> >
> > Am Donnerstag, dem 26.01.2023 um 00:24 +0000 schrieb Kaelyn Takata:
> >
> > > * gnu/packages/wine.scm (wine)[phases]: Add a new 'set-widl-time-
> > > override phase.
> >
> > You're doing this for three packages, so there should be three
> > packages
> > in the ChangeLog as well.
>
> I wasn't quite sure how to handle the changelog for the three
> packages since the various packages are variations of the same piece
> of software. If separate changelogs are desired, the existing can be
> copied and pasted for each of the three with the package name tweaked
> accordingly.
You can simply write (wine, wine64, wine-minimal)[#:phases]. It's just
to mark all the places that have changed.
> > On that note, it's somewhat odd that the wine packages can't share
> > some common phases. Perhaps we should refactor them a little to
> > make that possible.
>
> I agree they could and should be refactored to share more of the
> phases--I just haven't been brave enough to try because of the weird
> mixed-architecture nature of the builds.
I feel you. I can try to figure something out and reply to this thread
or open another one once I'm done.
Cheers
next prev parent reply other threads:[~2023-01-26 21:10 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-26 0:17 [bug#61067] [PATCH 0/3] Update wine and wine-staging packages to 8.0 Kaelyn Takata via Guix-patches via
2023-01-26 0:23 ` [bug#61067] [PATCH 1/3] gnu: wine: Update " Kaelyn Takata via Guix-patches via
2023-01-26 0:24 ` [bug#61067] [PATCH 2/3] gnu: wine: Build more reproducibly Kaelyn Takata via Guix-patches via
2023-01-26 19:28 ` Liliana Marie Prikler
2023-01-26 20:46 ` Kaelyn via Guix-patches via
2023-01-26 21:09 ` Liliana Marie Prikler [this message]
2023-01-27 1:07 ` Kaelyn via Guix-patches via
2023-01-26 0:24 ` [bug#61067] [PATCH 3/3] gnu: wine-staging: Update to 8.0 Kaelyn Takata via Guix-patches via
2023-01-27 1:07 ` [bug#61067] [PATCH v2 0/5] Update wine and wine-staging packages " Kaelyn Takata via Guix-patches via
2023-01-27 1:08 ` [bug#61067] [PATCH v2 1/5] gnu: wine: Update " Kaelyn Takata via Guix-patches via
2023-01-27 1:08 ` [bug#61067] [PATCH v2 2/5] gnu: wine-staging: " Kaelyn Takata via Guix-patches via
2023-01-27 1:08 ` [bug#61067] [PATCH v2 3/5] gnu: wine-minimal: Share phases with parent wine package Kaelyn Takata via Guix-patches via
2023-01-27 18:03 ` Liliana Marie Prikler
2023-01-27 18:15 ` Kaelyn via Guix-patches via
2023-01-30 20:39 ` Kaelyn via Guix-patches via
2023-01-31 19:19 ` Liliana Marie Prikler
2023-01-27 1:08 ` [bug#61067] [PATCH v2 4/5] gnu: wine64: " Kaelyn Takata via Guix-patches via
2023-01-27 1:08 ` [bug#61067] [PATCH v2 5/5] gnu: wine: Build more reproducibly Kaelyn Takata via Guix-patches via
2023-01-30 20:35 ` [bug#61067] [PATCH] gnu: wine: Invert the relationship between wine and wine-minimal Kaelyn Takata via Guix-patches via
2023-02-02 21:23 ` [bug#61067] [PATCH v3 0/5] Update wine and wine-staging packages to 8.0 Kaelyn Takata via Guix-patches via
2023-02-02 21:23 ` [bug#61067] [PATCH v3 1/5] gnu: wine: Update " Kaelyn Takata via Guix-patches via
2023-02-02 21:23 ` [bug#61067] [PATCH v3 2/5] gnu: wine-staging: " Kaelyn Takata via Guix-patches via
2023-02-02 21:23 ` [bug#61067] [PATCH v3 3/5] gnu: wine-minimal: Make the parent of wine so phases can be shared Kaelyn Takata via Guix-patches via
2023-02-02 21:24 ` [bug#61067] [PATCH v3 4/5] gnu: wine64: Share phases with parent wine package Kaelyn Takata via Guix-patches via
2023-02-02 21:24 ` [bug#61067] [PATCH v3 5/5] gnu: wine-minimal: Build more reproducibly Kaelyn Takata via Guix-patches via
2023-02-05 6:13 ` bug#61067: [PATCH v3 0/5] Update wine and wine-staging packages to 8.0 Liliana Marie Prikler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5f9118b2e770ad5e9e6d38249de08dddf1ea0fef.camel@gmail.com \
--to=liliana.prikler@gmail.com \
--cc=61067@debbugs.gnu.org \
--cc=kaelyn.alexi@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).