From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51282) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dxULb-0004Mr-Gi for guix-patches@gnu.org; Thu, 28 Sep 2017 04:39:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dxULW-0002Yt-IQ for guix-patches@gnu.org; Thu, 28 Sep 2017 04:39:07 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:55465) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dxULW-0002Yl-EZ for guix-patches@gnu.org; Thu, 28 Sep 2017 04:39:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dxULW-0005Cf-8U for guix-patches@gnu.org; Thu, 28 Sep 2017 04:39:02 -0400 Subject: [bug#28583] [PATCH 7/7] gnu: Add es-dump-restore. Resent-Message-ID: References: <20170924171717.3855-1-mail@cbaines.net> <20170924171717.3855-7-mail@cbaines.net> From: Ben Woodcroft Message-ID: <5ee025a9-da9b-b178-8649-f72f532467b5@uq.edu.au> Date: Thu, 28 Sep 2017 18:38:19 +1000 MIME-Version: 1.0 In-Reply-To: <20170924171717.3855-7-mail@cbaines.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Christopher Baines , 28583@debbugs.gnu.org On 25/09/17 03:17, Christopher Baines wrote: > * gnu/packages/databases.scm (es-dump-restore): New variable. [..] > + (arguments > + '(#:tests? #f Including a reason here would be good. > + #:phases > + (modify-phases %standard-phases > + (add-after 'install 'wrap-bin-es_dump_restore > + (lambda* (#:key outputs #:allow-other-keys) > + (wrap-program (string-append (assoc-ref outputs "out") > + "/bin/es_dump_restore") > + `("GEM_PATH" ":" prefix (,(string-append > + (getenv "GEM_PATH") > + ":" > + (getenv "GEM_HOME"))))) > + #t))))) Again, it would be preferable to have this done as part of the build system, but OK. > + (propagated-inputs > + `(("ruby-httpclient" ,ruby-httpclient) > + ("ruby-multi-json" ,ruby-multi-json) > + ("ruby-progress_bar" ,ruby-progress_bar) > + ("ruby-rubyzip" ,ruby-rubyzip) > + ("ruby-thor" ,ruby-thor))) > + (synopsis > + "Utility for dumping and restoring ElasticSearch indexes") This can be moved onto the previous line. > + (description > + "This package provides a utility for dumping the contents of an > +ElasticSearch index to a compressed file and restoring the dumpfile back to an > +ElasticSearch server") > + (home-page > + "https://github.com/patientslikeme/es_dump_restore") As can this. Otherwise LGTM - thanks for this series. ben