From: Ben Woodcroft <b.woodcroft@uq.edu.au>
To: Christopher Baines <mail@cbaines.net>, 28583@debbugs.gnu.org
Subject: [bug#28583] [PATCH 7/7] gnu: Add es-dump-restore.
Date: Thu, 28 Sep 2017 18:38:19 +1000 [thread overview]
Message-ID: <5ee025a9-da9b-b178-8649-f72f532467b5@uq.edu.au> (raw)
In-Reply-To: <20170924171717.3855-7-mail@cbaines.net>
On 25/09/17 03:17, Christopher Baines wrote:
> * gnu/packages/databases.scm (es-dump-restore): New variable.
[..]
> + (arguments
> + '(#:tests? #f
Including a reason here would be good.
> + #:phases
> + (modify-phases %standard-phases
> + (add-after 'install 'wrap-bin-es_dump_restore
> + (lambda* (#:key outputs #:allow-other-keys)
> + (wrap-program (string-append (assoc-ref outputs "out")
> + "/bin/es_dump_restore")
> + `("GEM_PATH" ":" prefix (,(string-append
> + (getenv "GEM_PATH")
> + ":"
> + (getenv "GEM_HOME")))))
> + #t)))))
Again, it would be preferable to have this done as part of the build
system, but OK.
> + (propagated-inputs
> + `(("ruby-httpclient" ,ruby-httpclient)
> + ("ruby-multi-json" ,ruby-multi-json)
> + ("ruby-progress_bar" ,ruby-progress_bar)
> + ("ruby-rubyzip" ,ruby-rubyzip)
> + ("ruby-thor" ,ruby-thor)))
> + (synopsis
> + "Utility for dumping and restoring ElasticSearch indexes")
This can be moved onto the previous line.
> + (description
> + "This package provides a utility for dumping the contents of an
> +ElasticSearch index to a compressed file and restoring the dumpfile back to an
> +ElasticSearch server")
> + (home-page
> + "https://github.com/patientslikeme/es_dump_restore")
As can this. Otherwise LGTM - thanks for this series.
ben
next prev parent reply other threads:[~2017-09-28 8:39 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-24 17:10 [bug#28583] [PATCH] Add es-dump-restore and dependencies Christopher Baines
2017-09-24 17:17 ` [bug#28583] [PATCH 1/7] gnu: Add ruby-httpclient Christopher Baines
2017-09-24 17:17 ` [bug#28583] [PATCH 2/7] gnu: Add ruby-multi-json Christopher Baines
2017-09-27 12:03 ` Ben Woodcroft
2017-09-30 8:21 ` Christopher Baines
2017-09-24 17:17 ` [bug#28583] [PATCH 3/7] gnu: Add ruby-options Christopher Baines
2017-09-27 12:10 ` Ben Woodcroft
2017-09-24 17:17 ` [bug#28583] [PATCH 4/7] gnu: Add ruby-highline Christopher Baines
2017-09-27 12:37 ` Ben Woodcroft
2017-09-30 8:23 ` Christopher Baines
2017-09-24 17:17 ` [bug#28583] [PATCH 5/7] gnu: Add ruby-progress_bar Christopher Baines
2017-09-27 12:43 ` Ben Woodcroft
2017-09-30 8:23 ` Christopher Baines
2017-09-24 17:17 ` [bug#28583] [PATCH 6/7] gnu: Add ruby-rubyzip Christopher Baines
2017-09-28 8:34 ` Ben Woodcroft
2017-09-30 8:24 ` Christopher Baines
2017-09-24 17:17 ` [bug#28583] [PATCH 7/7] gnu: Add es-dump-restore Christopher Baines
2017-09-28 8:38 ` Ben Woodcroft [this message]
2017-09-30 8:25 ` Christopher Baines
2017-09-30 10:32 ` Ben Woodcroft
2017-09-30 10:52 ` bug#28583: " Christopher Baines
2017-09-27 11:56 ` [bug#28583] [PATCH 1/7] gnu: Add ruby-httpclient Ben Woodcroft
2017-09-30 8:21 ` Christopher Baines
2017-09-30 8:19 ` [bug#28583] [PATCH 1/8] " Christopher Baines
2017-09-30 8:19 ` [bug#28583] [PATCH 2/8] gnu: Add ruby-multi-json Christopher Baines
2017-09-30 8:19 ` [bug#28583] [PATCH 3/8] gnu: Add ruby-options Christopher Baines
2017-09-30 8:19 ` [bug#28583] [PATCH 4/8] gnu: Add ruby-code-statistics Christopher Baines
2017-09-30 8:19 ` [bug#28583] [PATCH 5/8] gnu: Add ruby-highline Christopher Baines
2017-09-30 8:19 ` [bug#28583] [PATCH 6/8] gnu: Add ruby-progress_bar Christopher Baines
2017-09-30 8:19 ` [bug#28583] [PATCH 7/8] gnu: Add ruby-rubyzip Christopher Baines
2017-09-30 8:19 ` [bug#28583] [PATCH 8/8] gnu: Add ruby-es-dump-restore Christopher Baines
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ee025a9-da9b-b178-8649-f72f532467b5@uq.edu.au \
--to=b.woodcroft@uq.edu.au \
--cc=28583@debbugs.gnu.org \
--cc=mail@cbaines.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).