From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id liD2AvsQvGCkrAAAgWs5BA (envelope-from ) for ; Sun, 06 Jun 2021 02:04:11 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id gBWQOfoQvGB+UwAAB5/wlQ (envelope-from ) for ; Sun, 06 Jun 2021 00:04:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7BD99C632 for ; Sun, 6 Jun 2021 02:04:10 +0200 (CEST) Received: from localhost ([::1]:35380 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lpgGv-0001yt-F0 for larch@yhetil.org; Sat, 05 Jun 2021 20:04:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54030) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lpgGo-0001yk-Nc for guix-patches@gnu.org; Sat, 05 Jun 2021 20:04:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:38761) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lpgGo-0001Pp-GS for guix-patches@gnu.org; Sat, 05 Jun 2021 20:04:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lpgGo-0004iq-7c for guix-patches@gnu.org; Sat, 05 Jun 2021 20:04:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#46955] [ext] Re: [bug#46955] [PATCH 3/3] gnu: python-cooler: Update to 0.8.11. Resent-From: =?UTF-8?Q?M=C4=83d=C4=83lin?= Ionel =?UTF-8?Q?Patra=C8=99cu?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 06 Jun 2021 00:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46955 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: <46955@debbugs.gnu.org> Cc: rekado@elephly.net, Maxime Devos Received: via spool by 46955-submit@debbugs.gnu.org id=B46955.162293782718130 (code B ref 46955); Sun, 06 Jun 2021 00:04:02 +0000 Received: (at 46955) by debbugs.gnu.org; 6 Jun 2021 00:03:47 +0000 Received: from localhost ([127.0.0.1]:50307 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lpgGY-0004iM-WE for submit@debbugs.gnu.org; Sat, 05 Jun 2021 20:03:47 -0400 Received: from a2062.mx.srv.dfn.de ([194.95.232.172]:51425) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lpgGT-0004i3-EV for 46955@debbugs.gnu.org; Sat, 05 Jun 2021 20:03:45 -0400 Received: from localhost (localhost [127.0.0.1]) by a2062.mx.srv.dfn.de (Postfix) with ESMTP id A299CA00E3; Sun, 6 Jun 2021 02:03:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=mdc-berlin.de; h= content-language:content-transfer-encoding:content-type :content-type:in-reply-to:mime-version:user-agent:date:date :message-id:from:from:references:subject:subject:received :received:received; s=mdc; t=1622937814; x=1624752215; bh=z5ypFw oxSNkQymZVoBHdqYX8UVKfUsrht27RbNW1lls=; b=HKz7RtplgU9tqgsC+nsUvs RpMwUxWy/sf/6vp+IfEJin6DYv7lDcqu+Qe2tdVYyfYYsFjdGzaELGyqjK6rdy6W q80aiTXtuykN3TLXM2zHXw4/S8uHO6meBljGKHOPxum2lYP3C0AqL03Dyt44/GcG 6HNAH9s/4p7MDiU7DOFz8= Received: from a2062.mx.srv.dfn.de ([127.0.0.1]) by localhost (mgw4-han.srv.dfn.de [127.0.0.1]) (amavisd-new, port 20134) with ESMTP id O7-cww6Q5Er2; Sun, 6 Jun 2021 02:03:34 +0200 (CEST) Received: from SW-IT-P-EX4.mdc-berlin.net (mgw4.mdc-berlin.de [141.80.113.62]) by a2062.mx.srv.dfn.de (Postfix) with ESMTPS; Sun, 6 Jun 2021 02:03:34 +0200 (CEST) Received: from [192.168.1.220] (31.18.50.167) by SW-IT-P-EX4.mdc-berlin.net (141.80.113.62) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Sun, 6 Jun 2021 02:03:33 +0200 References: <20210603232503.29253-1-madalinionel.patrascu@mdc-berlin.de> <20210603232503.29253-3-madalinionel.patrascu@mdc-berlin.de> <7c35e0fff0b83ca112cbeda0f6a391536fb2abf8.camel@telenet.be> From: =?UTF-8?Q?M=C4=83d=C4=83lin?= Ionel =?UTF-8?Q?Patra=C8=99cu?= Message-ID: <5ec8d2b3-811a-013b-28db-6e79b6d2b556@mdc-berlin.de> Date: Sun, 6 Jun 2021 02:03:33 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <7c35e0fff0b83ca112cbeda0f6a391536fb2abf8.camel@telenet.be> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [31.18.50.167] X-ClientProxiedBy: SW-IT-P-EX4.mdc-berlin.net (141.80.113.62) To SW-IT-P-EX4.mdc-berlin.net (141.80.113.62) X-TM-AS-Product-Ver: SMEX-14.0.0.3080-8.6.1012-26202.003 X-TM-AS-Result: No-10--6.726300-8.000000 X-TMASE-MatchedRID: hls5oAVArl8eimh1YYHcKI61Z+HJnvsO52mltlE2n8jLkl8e9W70i9sU UM4+5JDM75eOGXcagECPWx38Q1qIm4ZKkFFIbQIAA9lly13c/gEEa8g1x8eqFwHA0AOzrXiBOXf Z9OHyzWZKvKQkFlo73R+nBl7Pmyp5O5k/PxBAvv7vdQQaH57xxsnlJe2gk8vIF0dfZ5kV9l+yhy zhSQtL0qCQFlbvrjaOLKJOFcgTP0i9sfpYxWNvCx/R5SKe31ARpnx3aOUcbhcLfbSiIF780tnu9 ZdOygfSfS0Ip2eEHny+qryzYw2E8LLn+0Vm71Lcq7rFUcuGp/HCttcwYNipX55Vb9l0vnaPQAX4 7DDRGDB3sESBa5dQK1ebVrmkF91doT7LQSvOTQal216CGmpWVS4DWCC21TAKXroHbJY3f6iSvcC awf/FHHdMG01tVbKNUdNvZjjOj9C63BPMcrcQuXeYWV2RaAfD+kkf6HhPsBc= X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--6.726300-8.000000 X-TMASE-Version: SMEX-14.0.0.3080-8.6.1012-26202.003 X-TM-SNTS-SMTP: 8CF6AF2E0F7D01EF1D8C5847B04B17CB2C72B02295ADD75F885D7968608163322000:F X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1622937850; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=Xu56H0lt5yTd6qR+lRlRA/HNWEiGGSCfY8RZ0G/IrkU=; b=fVq1bWQw8IjEVQ+4cvt3g0tQD7Ud3ViYxcHmiM4ej1iyENJ/8YEE6bV8xw+V7he5uyJnmF n3gejnrPTk3f+Sdf2OvLfQFupdrMkOg5h+THWDjy2gS83RF4sJ7msYk3QA6GxSGgu+Tv0z LGkEDdFZzJ4SNUB86DFtcb7CJuY1KAiuy6waSEokZ20zkGVEoTUg7Au+pmR0oOwTxjQI9v q3HdO4TtyylhQfAGpPhhNFGQLnh2crAtPxBS0gNW3XgeTeEnaGmRzJzdSoS5e8U0u6mzk1 kesfBTC8cwX/sSsyN4nLtkxuCFf6SK29gW7JsFPrT7/LdVrkjXd5QSW6/2AQtQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1622937850; a=rsa-sha256; cv=none; b=UAueYK5CfLFVYjm3IMAJf/FbBtM3MOtsfl6ih9kzZzkB8J3UKmfx8e7xyyM5C+rcZzZRqZ Wq6jVlIBwoYc15AWjI4jNQ3iT5Yb0OBiAdrCg8xExrifAvvGSP3DIbkNQLdjZxvCoJgEf7 tzI7MuD5M+3Kztu+OFRPT+IdXJU+lg09NbYzv/e3V27b4Dlc4y9kAoaACG0NDUAwAeASn6 Y+6J8YPE5RS101os1Bp1Ls/LVT7A+hNs1hvh+0Yd/KysM1KZ8SmynG8mL34ApcGt8xT7oC 3JYUtWc/3UuSFo78ssH6LRbV3qKaCmFd7UqHkhsBsFIjrMdt8f8YCEJ12o9JCw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=mdc-berlin.de header.s=mdc header.b=HKz7Rtpl; dmarc=fail reason="SPF not aligned (relaxed)" header.from=mdc-berlin.de (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: 0.17 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=mdc-berlin.de header.s=mdc header.b=HKz7Rtpl; dmarc=fail reason="SPF not aligned (relaxed)" header.from=mdc-berlin.de (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 7BD99C632 X-Spam-Score: 0.17 X-Migadu-Scanner: scn0.migadu.com X-TUID: poWVum+VpABA Hi Maxime, Thanks for the explanation, now these things are clear to me! I applied Maxime's advice and I have made some changes on two patches (python-sparse and python-cooler). Because of this reason, I will send again the whole series of patches and I will wait for a full review of them. Thanks, Maxime! On 05.06.2021 12:06, Maxime Devos wrote: > A comment about a build phase. > >> [...] >> + (replace 'check >> + (lambda _ >> + (invoke "python" "-m" "pytest" "-v") >> + #t))))) > This needs to be something like > > + (replace 'check > + (lambda* (#:key tests? #:allow-other-keys) > + (when tests? > + (invoke "python" "-m" "pytest" "-v")))) > > By respecting 'tests?', the --without-tests build transformation can be used. > (Try "guix build python-cooler --without-tests=python-cooler"). > This can also be important for cross-compilation (dunno if it applies here > though). > > Trailing #t are not required anymore. The warning that results if it is removed > will disappear once core-updates is merged. > > Greetings, > Maxime. -- System Administrator Bioinformatics and Omics Data Science BIMSB - MDC