From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id iPdhKKYUu17TKwAA0tVLHw (envelope-from ) for ; Tue, 12 May 2020 21:27:02 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id KJW3CLUUu16lQwAA1q6Kng (envelope-from ) for ; Tue, 12 May 2020 21:27:17 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A5595940FD7 for ; Tue, 12 May 2020 21:27:14 +0000 (UTC) Received: from localhost ([::1]:38240 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jYcQk-0005pK-Qu for larch@yhetil.org; Tue, 12 May 2020 17:27:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35406) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jYcQY-0005pA-Dh for guix-patches@gnu.org; Tue, 12 May 2020 17:27:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:45142) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jYcQY-0007zN-4c for guix-patches@gnu.org; Tue, 12 May 2020 17:27:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jYcQY-0008LB-03 for guix-patches@gnu.org; Tue, 12 May 2020 17:27:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#41219] Enforce "files" directive in node build system Resent-From: goodoldpaul@autistici.org Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 12 May 2020 21:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 41219 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: 41219@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.158931880132031 (code B ref -1); Tue, 12 May 2020 21:27:01 +0000 Received: (at submit) by debbugs.gnu.org; 12 May 2020 21:26:41 +0000 Received: from localhost ([127.0.0.1]:56688 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jYcQD-0008KZ-IU for submit@debbugs.gnu.org; Tue, 12 May 2020 17:26:41 -0400 Received: from lists.gnu.org ([209.51.188.17]:43516) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jYcQB-0008KR-Py for submit@debbugs.gnu.org; Tue, 12 May 2020 17:26:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35382) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jYcQB-0005nX-K0 for guix-patches@gnu.org; Tue, 12 May 2020 17:26:39 -0400 Received: from confino.investici.org ([212.103.72.250]:51501) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jYcQ9-0007u0-SB for guix-patches@gnu.org; Tue, 12 May 2020 17:26:39 -0400 Received: from 1.mail-backend.investici.org (unknown [10.0.0.11]) by confino.investici.org (Postfix) with ESMTP id 7FE3420F9F for ; Tue, 12 May 2020 21:26:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=autistici.org; s=stigmate; t=1589318782; bh=1XC2nQgzwEqHSrwwqLHWS0nyvP4PeC2NGmAg6K3CjV8=; h=Date:From:To:Subject:From; b=eLidAU8k//mG6oqpR2iFF7Iy+hRKiocKDIdjcLZyLKCCjOWuAHHEeu4N/6++tvt/C KpOlUZRN/cVYXTWrKIRs6H5eUZCbSF9ihL7NTHXL1duZJuXWIbYy4Q6hHXi9/ngVEr NgybGONDt14ZLipEyHhN+T9K+bULMbbnrwPmA5PM= Received: from 1.webmail.investici.org (localhost [127.0.0.1]) (Authenticated sender: goodoldpaul@autistici.org) by 1.mail-backend.investici.org (Postfix) with ESMTPA id 52B8BBEE39 for ; Tue, 12 May 2020 21:26:22 +0000 (UTC) MIME-Version: 1.0 Date: Tue, 12 May 2020 21:26:22 +0000 From: goodoldpaul@autistici.org User-Agent: Roundcube Webmail Message-ID: <5ec7ac973bb248a3cca0197836d35459@autistici.org> X-Sender: goodoldpaul@autistici.org Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=212.103.72.250; envelope-from=goodoldpaul@autistici.org; helo=confino.investici.org X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/12 17:12:46 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-Spam-Score: -1.4 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -2.4 (--) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 X-Spam-Score: -0.00 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=autistici.org header.s=stigmate header.b=eLidAU8k; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Scan-Result: default: False [-0.00 / 13.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; GENERIC_REPUTATION(0.00)[-0.53964024979821]; XM_UA_NO_VERSION(0.01)[]; DWL_DNSWL_FAIL(0.00)[209.51.188.17:server fail]; R_SPF_ALLOW(-0.20)[+ip4:209.51.188.0/24:c]; IP_REPUTATION_HAM(0.00)[asn: 22989(0.06), country: US(-0.00), ip: 209.51.188.17(-0.54)]; TO_DN_NONE(0.00)[]; R_DKIM_REJECT(1.00)[autistici.org:s=stigmate]; MX_GOOD(-0.50)[cached: eggs.gnu.org]; DKIM_TRACE(0.00)[autistici.org:-]; MAILLIST(-0.20)[mailman]; FORGED_RECIPIENTS_MAILLIST(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:22989, ipnet:209.51.188.0/24, country:US]; TAGGED_FROM(0.00)[larch=yhetil.org]; FROM_NEQ_ENVFROM(0.00)[goodoldpaul@autistici.org,guix-patches-bounces@gnu.org]; MID_RHS_MATCH_FROM(0.00)[]; ARC_NA(0.00)[]; URIBL_BLOCKED(0.00)[gnu.org:url]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[autistici.org]; HAS_LIST_UNSUB(-0.01)[]; RCPT_COUNT_ONE(0.00)[1]; DNSWL_BLOCKED(0.00)[209.51.188.17:from]; FROM_NO_DN(0.00)[]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.51.188.17:from]; RCVD_COUNT_SEVEN(0.00)[11]; FORGED_SENDER_MAILLIST(0.00)[] X-TUID: AasNkG0CVk9+ Hi, I'm sending a couple of patches to fix https://issues.guix.gnu.org/40710, I tried to base my implementation on [0]. The first patch adds "globstar" support to (guix glob), namely the ability of recursively matching subdirectories in a glob pattern (i.e. "foo/**/bar.scm" matches both "foo/bar.scm" and "foo/baz/bar.scm"). The second patch adds (guix glob) to the imported modules of node-build-system and uses that to parse glob patterns in the "files" array of a package.json and then install all the matching files. I tested the patches by verifying that ./pre-inst-env guix build -K node-semver node-util-deprecate node-statsd-parser node-stack-trace node-oop node-mersenne node-long-stack-traces node-far node-env-variable node-color-name runs without error and and by running make check TESTS="tests/glob.scm" .