From: Alexandros Theodotou <alex@zrythm.org>
To: Marius Bakke <mbakke@fastmail.com>, 38115@debbugs.gnu.org
Subject: [bug#38115] [PATCH] gnu: Add dpf-plugins.
Date: Mon, 11 Nov 2019 04:48:51 +0000 [thread overview]
Message-ID: <5ec075a5ad2b9e880909217dc3d7b300bfc3ea94.camel@zrythm.org> (raw)
In-Reply-To: <87k187jqot.fsf@devup.no>
[-- Attachment #1.1: Type: text/plain, Size: 1153 bytes --]
> > + (arguments
> > + `(#:tests? #f ; no "check" target
> > + #:make-flags
> > + (list (string-append "PREFIX=" (assoc-ref %outputs "out")))
> > + #:phases
> > + (modify-phases %standard-phases
> > + (add-after 'unpack 'skip-dssi-binaries
> > + (lambda _
> > + (substitute* "Makefile"
> > + (("cp -r bin.*-dssi.*$") ":;\n"))
> > + #t))
>
> Can you expand on this comment? What are these binaries, and why do
> we
> need to prevent them from being installed?
I was having trouble building them, but I managed to get them building
now (was missing liblo). Removed this part
>
> > + (license `(license:isc license:gpl3 license:lgpl3 license:mit
> > license:gpl2))))
>
> Does this work? I would expect each of the license entries to have
> to
> be 'unquoted', i.e. `(,license:isc). Alternatively you can use (list
> ...) here.
>
> When a package has multiple licenses like here, please add a comment
> about it. Is there a "main" license, (roughly) which files are under
> what license?
Fixed and added more info
[-- Attachment #1.2: 0001-gnu-Add-dpf-plugins.patch --]
[-- Type: text/x-patch, Size: 2735 bytes --]
From 065b91fd765d8df510bcf969c9f41ae792733632 Mon Sep 17 00:00:00 2001
From: Alexandros Theodotou <alex@zrythm.org>
Date: Fri, 8 Nov 2019 08:55:22 +0000
Subject: [PATCH] gnu: Add dpf-plugins.
* gnu/packages/music.scm: (dpf-plugins): New variable.
---
gnu/packages/music.scm | 48 ++++++++++++++++++++++++++++++++++++++++++
1 file changed, 48 insertions(+)
diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index 2f023685df..784462e56d 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -4737,3 +4737,51 @@ for integration into status line generators or other command-line tools.")
effects. It contains a bitcrusher, delay, distortion, equalizer, compressor,
and reverb.")
(license license:gpl2+)))
+
+(define-public dpf-plugins
+ (package
+ (name "dpf-plugins")
+ (version "1.3")
+ (source
+ (origin
+ (method git-fetch)
+ (uri
+ (git-reference
+ (url "https://github.com/DISTRHO/DPF-Plugins.git")
+ (commit (string-append "v" version))))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "1hsfmpv3kvpiwk8nfw9xpaipzy0n27i83y2v1yr93lznwm5rqrbs"))))
+ (build-system gnu-build-system)
+ (arguments
+ `(#:tests? #f ; no "check" target
+ #:make-flags
+ (list (string-append "PREFIX=" (assoc-ref %outputs "out")))
+ #:phases
+ (modify-phases %standard-phases
+ (add-before 'build 'set-CC-variable
+ (lambda _ (setenv "CC" "gcc") #t))
+ (delete 'configure))))
+ (inputs
+ `(("cairo" ,cairo)
+ ("liblo" ,liblo) ; for dssi plugins
+ ("jack" ,jack-1) ; for standalone applications
+ ("mesa" ,mesa)))
+ (native-inputs
+ `(("pkg-config" ,pkg-config)
+ ("dssi" ,dssi)
+ ("lv2" ,lv2)))
+ (home-page "https://github.com/DISTRHO/DPF-Plugins")
+ (synopsis "Audio plugin collection")
+ (description "Collection of audio plugins built with the DISTRHO Plugin
+Framework (DPF) available in LADSPA, DSSI, LV2 and VST2 formats. This
+package includes the following plugins: glBars, Kars, Max-Gen examples
+(MaBitcrush, MaFreeverb, MaGigaverb, MaPitchshift), Mini-Series (3BandEQ,
+3BandSplitter, PingPongPan), ndc-Plugs (Amplitude Imposer, Cycle Shifter,
+Soul Force), MVerb, Nekobi, and ProM.")
+ ;; This package consists of several plugins refactored to use the
+ ;; DISTHRO Plugin Framework (DPF). Different copyrights and licenses
+ ;; apply to different plugins. The root LICENSE file has a table with
+ ;; license information for each plugin and paths to each license
+ (license (list license:isc license:gpl3 license:lgpl3 license:expat license:gpl2))))
--
2.24.0
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-11-11 4:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-08 8:58 [bug#38115] [PATCH] gnu: Add dpf-plugins Alexandros Theodotou
2019-11-10 22:45 ` Marius Bakke
2019-11-11 4:48 ` Alexandros Theodotou [this message]
2019-11-13 22:30 ` bug#38115: " Marius Bakke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ec075a5ad2b9e880909217dc3d7b300bfc3ea94.camel@zrythm.org \
--to=alex@zrythm.org \
--cc=38115@debbugs.gnu.org \
--cc=mbakke@fastmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).