From: Bruno Victal <mirai@makinata.eu>
To: 60791@debbugs.gnu.org
Cc: dthompson2@worcester.edu
Subject: [bug#60791] [PATCH] gnu: services: Add joycond-service.
Date: Fri, 13 Jan 2023 22:46:19 +0000 [thread overview]
Message-ID: <5eaac013-2a20-c322-24a9-ab389ec974c5@makinata.eu> (raw)
In-Reply-To: <CAJ=RwfZCC=7ZdF2WNs5kGcPh38fub6xN6JbbFew1Q7VD-Yk-Ww@mail.gmail.com>
Hi,
--8<---------------cut here---------------start------------->8---
+@defvar {Scheme Variable} joycond-service-type
+Service type for the joycond service.
+@end defvar
--8<---------------cut here---------------end--------------->8---
Should be `@defvar joycond-service-type'.
--8<---------------cut here---------------start------------->8---
+(define-record-type* <joycond-configuration>
+ joycond-configuration make-joycond-configuration
+ joycond-configuration?
+ (joycond joycond-configuration-joycond (default joycond)))
--8<---------------cut here---------------end--------------->8---
This could be replaced with define-configuration/no-serialization since
the only field here is a package / file-like object. (see [1], [2] for examples)
I'd prefer the field be called 'package' here.
--8<---------------cut here---------------start------------->8---
+(define (joycond-shepherd-service config)
+ (let ((joycond (joycond-configuration-joycond config)))
+ (list (shepherd-service
+ (documentation "Run joycond.")
+ (provision '(joycond))
+ (requirement '(bluetooth))
+ (start #~(make-forkexec-constructor
+ (list #$(file-append joycond "/bin/joycond"))))
+ (stop #~(make-kill-destructor))))))
--8<---------------cut here---------------end--------------->8---
You might prefer match-record here but this is okay as well.
[1]: https://issues.guix.gnu.org/60788
[2]: ddclient-configuration in gnu/services/dns.scm
Cheers,
Bruno
next prev parent reply other threads:[~2023-01-13 22:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-13 22:12 [bug#60791] [PATCH] gnu: services: Add joycond-service Thompson, David
2023-01-13 22:46 ` Bruno Victal [this message]
2023-01-13 23:50 ` Thompson, David
2023-01-14 4:47 ` Bruno Victal
2023-01-14 13:00 ` bug#60791: " Thompson, David
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5eaac013-2a20-c322-24a9-ab389ec974c5@makinata.eu \
--to=mirai@makinata.eu \
--cc=60791@debbugs.gnu.org \
--cc=dthompson2@worcester.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).