From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:50360) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j8t3f-0005F1-V4 for guix-patches@gnu.org; Mon, 02 Mar 2020 16:57:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j8t3e-000658-Fz for guix-patches@gnu.org; Mon, 02 Mar 2020 16:57:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:60691) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j8t3d-00064t-Qp for guix-patches@gnu.org; Mon, 02 Mar 2020 16:57:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j8t3d-00033R-Pz for guix-patches@gnu.org; Mon, 02 Mar 2020 16:57:01 -0500 Subject: [bug#39862] [PATCH 0/4] update Dune finite element packages Resent-Message-ID: References: <20200301194914.899011-1-felgru@posteo.net> From: Felix Gruber Message-ID: <5e890189-d5f7-a646-fe37-1f93115d17f9@posteo.net> Date: Mon, 2 Mar 2020 22:56:20 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: zimoun Cc: 39862@debbugs.gnu.org Hi Simon, Thank you for your feedback. On 3/2/20 3:53 PM, zimoun wrote: > On Sun, 1 Mar 2020 at 21:07, Felix Gruber wrote: > >> BTW, some other packages exist in variants with and without OpenMPI, >> e.g. the dealii and dealii-openmpi packages. Do you think that it would >> be useful to provide similar variants for the dune-* packages, which >> could also be built without OpenMPI? > > As an end-user, I prefer regular packages 'dune-*' without the input > 'openmpi' and so with the related tests disabled and then their > variants; say 'dune-*-openmpi' with the input 'openmpi' correctly > setup-ed, as in your patch. Cool, I'll create an additional patch which splits all the dune packages in those two variants. Still struggling a bit with guile to replace all the dune-* packages with dune-*-openmpi in an inputs list without copy pasting the whole list and changing the packages manually. >> I've checked that all Dune packages still build after my changes (there >> don't seem to be any other packages that depend on the dune-* packages). >> Those builds were done using the updated suitesparse package that I've >> submitted in bug #39839. > > Usually, 'guix refresh -l' lists the packages that would need to be > rebuilt when upgrading a particular one. A `guix refresh -l dune-common` only gives me three other dune-* packages that would result in rebuilding 10 packages overall. Since dune-common is in the input of all the other dune-* packages, I think that tells me that there are no non-dune packages that depend on any dune-* package. Best, Felix