* [bug#71898] [PATCH] gnu: erlang-lfe: Make LFE compiler deterministic.
@ 2024-07-02 8:57 Igor Goryachev via Guix-patches via
2024-07-02 11:01 ` Andrew Tropin via Guix-patches via
2024-07-07 7:52 ` bug#71898: " Andrew Tropin via Guix-patches via
0 siblings, 2 replies; 3+ messages in thread
From: Igor Goryachev via Guix-patches via @ 2024-07-02 8:57 UTC (permalink / raw)
To: 71898; +Cc: Igor Goryachev, Andrew Tropin
* gnu/packages/erlang.scm (erlang-lfe): Make LFE compiler deterministic.
Change-Id: I0cf00eeda8502384b746795802f1b2291d0e8a3b
---
gnu/packages/erlang.scm | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/gnu/packages/erlang.scm b/gnu/packages/erlang.scm
index dd07c1a617..58aac2bead 100644
--- a/gnu/packages/erlang.scm
+++ b/gnu/packages/erlang.scm
@@ -792,6 +792,11 @@ (define-public erlang-lfe
#:phases
#~(modify-phases %standard-phases
(delete 'configure)
+ (add-after 'unpack 'make-deterministic
+ (lambda _
+ (substitute* "src/lfe_env.erl"
+ (("maps:fold\\(F, A, D\\)")
+ "lists:sort(maps:fold(F, A, D))"))))
;; The following is inspired by rebar-build-system.scm
(add-before 'check 'erlang-depends
(lambda* (#:key inputs #:allow-other-keys)
base-commit: 5f1e4e4c0242af6bcba656aedf8b49afbe7247b7
--
2.45.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* [bug#71898] [PATCH] gnu: erlang-lfe: Make LFE compiler deterministic.
2024-07-02 8:57 [bug#71898] [PATCH] gnu: erlang-lfe: Make LFE compiler deterministic Igor Goryachev via Guix-patches via
@ 2024-07-02 11:01 ` Andrew Tropin via Guix-patches via
2024-07-07 7:52 ` bug#71898: " Andrew Tropin via Guix-patches via
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Tropin via Guix-patches via @ 2024-07-02 11:01 UTC (permalink / raw)
To: igor, 71898; +Cc: Igor Goryachev
[-- Attachment #1: Type: text/plain, Size: 1198 bytes --]
On 2024-07-02 11:57, Igor Goryachev wrote:
> * gnu/packages/erlang.scm (erlang-lfe): Make LFE compiler deterministic.
>
> Change-Id: I0cf00eeda8502384b746795802f1b2291d0e8a3b
> ---
> gnu/packages/erlang.scm | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/gnu/packages/erlang.scm b/gnu/packages/erlang.scm
> index dd07c1a617..58aac2bead 100644
> --- a/gnu/packages/erlang.scm
> +++ b/gnu/packages/erlang.scm
> @@ -792,6 +792,11 @@ (define-public erlang-lfe
> #:phases
> #~(modify-phases %standard-phases
> (delete 'configure)
> + (add-after 'unpack 'make-deterministic
> + (lambda _
> + (substitute* "src/lfe_env.erl"
> + (("maps:fold\\(F, A, D\\)")
> + "lists:sort(maps:fold(F, A, D))"))))
It would be useful to add some explanation in the comment and probably a
link to upstream PR/thread.
> ;; The following is inspired by rebar-build-system.scm
> (add-before 'check 'erlang-depends
> (lambda* (#:key inputs #:allow-other-keys)
>
> base-commit: 5f1e4e4c0242af6bcba656aedf8b49afbe7247b7
--
Best regards,
Andrew Tropin
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread* bug#71898: [PATCH] gnu: erlang-lfe: Make LFE compiler deterministic.
2024-07-02 8:57 [bug#71898] [PATCH] gnu: erlang-lfe: Make LFE compiler deterministic Igor Goryachev via Guix-patches via
2024-07-02 11:01 ` Andrew Tropin via Guix-patches via
@ 2024-07-07 7:52 ` Andrew Tropin via Guix-patches via
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Tropin via Guix-patches via @ 2024-07-07 7:52 UTC (permalink / raw)
To: Igor Goryachev via Guix-patches via, 71898-done; +Cc: Igor Goryachev
[-- Attachment #1: Type: text/plain, Size: 1136 bytes --]
On 2024-07-02 11:57, Igor Goryachev via Guix-patches via wrote:
> * gnu/packages/erlang.scm (erlang-lfe): Make LFE compiler deterministic.
>
> Change-Id: I0cf00eeda8502384b746795802f1b2291d0e8a3b
> ---
> gnu/packages/erlang.scm | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/gnu/packages/erlang.scm b/gnu/packages/erlang.scm
> index dd07c1a617..58aac2bead 100644
> --- a/gnu/packages/erlang.scm
> +++ b/gnu/packages/erlang.scm
> @@ -792,6 +792,11 @@ (define-public erlang-lfe
> #:phases
> #~(modify-phases %standard-phases
> (delete 'configure)
> + (add-after 'unpack 'make-deterministic
> + (lambda _
> + (substitute* "src/lfe_env.erl"
> + (("maps:fold\\(F, A, D\\)")
> + "lists:sort(maps:fold(F, A, D))"))))
> ;; The following is inspired by rebar-build-system.scm
> (add-before 'check 'erlang-depends
> (lambda* (#:key inputs #:allow-other-keys)
>
> base-commit: 5f1e4e4c0242af6bcba656aedf8b49afbe7247b7
Superseded by 71899.
--
Best regards,
Andrew Tropin
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-07-07 7:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-02 8:57 [bug#71898] [PATCH] gnu: erlang-lfe: Make LFE compiler deterministic Igor Goryachev via Guix-patches via
2024-07-02 11:01 ` Andrew Tropin via Guix-patches via
2024-07-07 7:52 ` bug#71898: " Andrew Tropin via Guix-patches via
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).